Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 )
Change subject: [location_awareness] Add location info in ksck report ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11422/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11422/2/src/kudu/client/client.h@602 PS2, Line 602: /// @return The location of the tablet server. What if there's no location? http://gerrit.cloudera.org:8080/#/c/11422/2/src/kudu/client/tablet_server-internal.h File src/kudu/client/tablet_server-internal.h: http://gerrit.cloudera.org:8080/#/c/11422/2/src/kudu/client/tablet_server-internal.h@35 PS2, Line 35: const std::string location_ Please document what's implicit here: an empty string means no location is assigned. http://gerrit.cloudera.org:8080/#/c/11422/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/11422/2/src/kudu/tools/ksck_remote.cc@460 PS2, Line 460: s->location() Put this on a separate line, please. -- To view, visit http://gerrit.cloudera.org:8080/11422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideff2dd4975c99a1135002624debbbb2620fb95c Gerrit-Change-Number: 11422 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 24 Sep 2018 18:48:42 +0000 Gerrit-HasComments: Yes
