Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )
Change subject: util: remove all gscoped_ptr ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/tablet/concurrent_btree.h File src/kudu/tablet/concurrent_btree.h: http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/tablet/concurrent_btree.h@1101 PS1, Line 1101: > nit: maybe, drop the extra space while you are at it? Done http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc@1522 PS1, Line 1522: [] > Actually nevermind. Interesting that this worked before. Yeah it was pretty weird. http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/user.cc File src/kudu/util/user.cc: http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/user.cc@60 PS1, Line 60: size_t bufsize = retval > 0 ? retval : 16384; : : unique_ptr<char[]> buf(new char[bufsize]); > nit: is it possible to allocate 16K buffer on stack and then use it or it's Well we still need to account for the possibility that sysconf() returns a value much greater than 16K. It's very unlikely, but I don't know if it's a guarantee. -- To view, visit http://gerrit.cloudera.org:8080/15377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196 Gerrit-Change-Number: 15377 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Mar 2020 04:15:33 +0000 Gerrit-HasComments: Yes
