Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/ranger/ranger_client.cc@150 PS2, Line 150: outbound_queue_time_ms, ranger_subprocess_outbound_queue_time_ms); : HISTINIT(sp_execution_time_ms, ranger_subprocess_execution_time_m > +1; at the very least, shouldn't we NOT pass these args if Kudu isn't Kerbe Done http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/security/init.cc@441 PS2, Line 441: static const auto& kHostToken = "_HOST"; > This can be made static. Done -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 14 Mar 2020 18:50:15 +0000 Gerrit-HasComments: Yes
