Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17446 )

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc
File src/kudu/integration-tests/txn_participant-itest.cc:

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc@873
PS3, Line 873:       /*begin_commit_timestamp*/nullpt
> Does it make sense to add coverage to make sure this field is populated whe
Done


http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto
File src/kudu/tserver/tserver_admin.proto:

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto@127
PS3, Line 127: absen
> nit: if no metadata exists on the given participant, is it going to be rath
Done



--
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 01:07:33 +0000
Gerrit-HasComments: Yes

Reply via email to