cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r740223188
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala ########## @@ -36,7 +36,8 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper { import DataSourceV2Implicits._ def apply(plan: LogicalPlan): LogicalPlan = { - applyColumnPruning(applyLimit(pushDownAggregates(pushDownFilters(createScanBuilder(plan))))) + applyColumnPruning( + applyLimit(applySample(pushDownAggregates(pushDownFilters(createScanBuilder(plan)))))) Review comment: shouldn't we push down sample first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org