cloud-fan commented on a change in pull request #34451:
URL: https://github.com/apache/spark/pull/34451#discussion_r740224359
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -261,15 +284,17 @@ case class ScanBuilderHolder(
builder: ScanBuilder) extends LeafNode {
var pushedLimit: Option[Int] = None
private[sql] def setLimit(limit: Option[Int]): Unit = pushedLimit = limit
+
+ var pushedSample: Option[TableSample] = None
+ private[sql] def setSample(sample: Option[TableSample]): Unit = pushedSample
= sample
Review comment:
since the var is public, we can just set it without a `setXXX` method??
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -261,15 +284,17 @@ case class ScanBuilderHolder(
builder: ScanBuilder) extends LeafNode {
var pushedLimit: Option[Int] = None
private[sql] def setLimit(limit: Option[Int]): Unit = pushedLimit = limit
+
+ var pushedSample: Option[TableSample] = None
+ private[sql] def setSample(sample: Option[TableSample]): Unit = pushedSample
= sample
Review comment:
since the var is public, we can just set it without a `setXXX` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
