gengliangwang commented on a change in pull request #22037:
URL: https://github.com/apache/spark/pull/22037#discussion_r741597255
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
##########
@@ -18,19 +18,28 @@
package org.apache.spark.sql.avro
import scala.collection.JavaConverters._
+import scala.util.Random
+import com.fasterxml.jackson.annotation.ObjectIdGenerators.UUIDGenerator
import org.apache.avro.{LogicalType, LogicalTypes, Schema, SchemaBuilder}
-import org.apache.avro.LogicalTypes.{Date, TimestampMicros, TimestampMillis}
+import org.apache.avro.LogicalTypes.{Date, Decimal, TimestampMicros,
TimestampMillis}
import org.apache.avro.Schema.Type._
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.util.RandomUUIDGenerator
import org.apache.spark.sql.internal.SQLConf.AvroOutputTimestampType
import org.apache.spark.sql.types._
+import org.apache.spark.sql.types.Decimal.{maxPrecisionForBytes,
minBytesForPrecision}
/**
* This object contains method that are used to convert sparkSQL schemas to
avro schemas and vice
* versa.
*/
object SchemaConverters {
+ private lazy val uuidGenerator = RandomUUIDGenerator(new Random().nextLong())
Review comment:
Yes, I made a PR to clean it up:
https://github.com/apache/spark/pull/34472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
