venkata91 commented on a change in pull request #33896: URL: https://github.com/apache/spark/pull/33896#discussion_r748574875
########## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ########## @@ -1716,7 +1739,31 @@ private[spark] class DAGScheduler( if (runningStages.contains(shuffleStage) && shuffleStage.pendingPartitions.isEmpty) { if (!shuffleStage.shuffleDep.shuffleMergeFinalized && shuffleStage.shuffleDep.getMergerLocs.nonEmpty) { - scheduleShuffleMergeFinalize(shuffleStage) + // Check if a finalize task has already been scheduled. This is to prevent the + // following scenario: Stage A attempt 0 fails and gets retried. Stage A attempt 1 + // succeeded, triggering the scheduling of shuffle merge finalization. However, + // tasks from Stage A attempt 0 might still be running and sending task completion + // events to DAGScheduler. This check prevents multiple attempts to schedule merge + // finalization get triggered due to this. Review comment: @Ngone51 Do you mean we can have a `finalize` flag corresponding to the `ScheduledTask` and then set it to `false` when we are about to cancel and schedule a new one. In the `finalizeShuffleMerge`, we basically check if this `finalize` flag is true or false and accordingly complete the shuffle merge finalization instead going the route of canceling the task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org