cloud-fan opened a new pull request, #55238:
URL: https://github.com/apache/spark/pull/55238

   ### What changes were proposed in this pull request?
   
   This is a follow-up to #55168. The SBT launcher script 
(`build/sbt-launch-lib.bash`) did not respect `MAVEN_MIRROR_URL`. This patch 
adds support for it in two places:
   
   1. **Launcher JAR download**: `MAVEN_MIRROR_URL` is used as the default for 
`DEFAULT_ARTIFACT_REPOSITORY` when neither is explicitly set.
   2. **SBT boot phase**: When `MAVEN_MIRROR_URL` is set, a temporary SBT 
repositories config is generated and passed via `-Dsbt.repository.config` so 
SBT resolves itself and Scala through the mirror.
   
   ### Why are the changes needed?
   
   SPARK-56338 added `MAVEN_MIRROR_URL` support for Maven (`pom.xml`) and SBT 
project builds (`SparkBuild.scala`), but the SBT launcher script was not 
covered. In environments where default Maven repositories are unreachable, the 
SBT launcher JAR download and boot phase still fail without manual 
configuration (e.g. `~/.sbt/repositories`).
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manually tested by setting `MAVEN_MIRROR_URL` and building Spark with SBT 
from scratch (launcher JAR removed, no `~/.sbt/repositories`).
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to