LuciferYang commented on code in PR #55230:
URL: https://github.com/apache/spark/pull/55230#discussion_r3048933881
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java:
##########
@@ -240,6 +240,10 @@ public static void setMemory(long address, byte value,
long size) {
public static void copyMemory(
Object src, long srcOffset, Object dst, long dstOffset, long length) {
+ if (length <= UNSAFE_COPY_THRESHOLD) {
Review Comment:
@AngersZhuuuu Is it end-to-end, or just this API? Do we get consistent
performance gains on Java 17, 21, and 25? If you think `PlatformBenchmark` does
not capture this improvement, could you provide reproducible jmh benchmark code
and the results run on GitHub Actions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
