hvanhovell opened a new pull request, #55262:
URL: https://github.com/apache/spark/pull/55262
### What changes were proposed in this pull request?
Added `PARSE_FORMAT_XML` to the `Parse.ParseFormat` enum in the Spark
Connect proto
(`relations.proto`) and wired it through the full stack:
- **Client** (`DataFrameReader.scala`): `xml(Dataset[String])` now sends
`PARSE_FORMAT_XML`
instead of `PARSE_FORMAT_UNSPECIFIED`
- **Server** (`SparkConnectPlanner.scala`): handles `PARSE_FORMAT_XML` by
dispatching to
`dataFrameReader.xml(ds)`
- **Proto generated files**: regenerated Python proto bindings
### Why are the changes needed?
`DataFrameReader.xml(Dataset[String])` was sending
`PARSE_FORMAT_UNSPECIFIED` to the server,
causing it to fail. This adds proper XML support to the Connect Parse
protocol.
### Does this PR introduce _any_ user-facing change?
Yes. `spark.read.xml(dataset)` now works correctly in Spark Connect
(previously it threw an error).
### How was this patch tested?
- Added `ClientE2ETestSuite` tests: `xml from Dataset[String] inferSchema`,
`xml from Dataset[String] with schema`, `xml from Dataset[String] with
invalid schema`
- Added `PlanGenerationTestSuite` test: `xml from dataset`
- Added query plan golden files: `xml_from_dataset.json` /
`xml_from_dataset.proto.bin`
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
