Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7657#discussion_r36674387
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -528,7 +528,11 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
}
// Optionally scale number of executors dynamically based on workload.
Exposed for testing.
- val dynamicAllocationEnabled =
_conf.getBoolean("spark.dynamicAllocation.enabled", false)
+ val dynamicAllocationEnabled = Utils.isDynamicAllocationEnabled(_conf)
+ if (!dynamicAllocationEnabled) {
+ logInfo(s"Dynamic Allocation and num executors both set, thus
dynamic allocation disabled.")
--- End diff --
This log is not right. It will be printed anytime dynamic allocation is
disabled, not just when it's disabled because of the configuration conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
