Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54141380 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala --- @@ -157,6 +157,12 @@ private[ml] class WeightedLeastSquares( private[ml] object WeightedLeastSquares { /** + * In order to take the normal equation approach efficiently, [[WeightedLeastSquares]] + * only supports the number of features is no more than 4096. + */ + val MaxNumFeatures: Int = 4096 --- End diff -- For constant, do we have naming convention? Like `MAX_NUM_FEATURES`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org