GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/12472
[SPARK-14704][CORE][WIP] create accumulators in TaskMetrics
## What changes were proposed in this pull request?
It's cleaner to create accumulators inside `TaskMetrics` directly, instead
of creating them somewhere else and pass them into `TaskMetrics`.
One problem is when should we register these internal accumulators. It
seems that sometimes we call `InternalAccumulator.createAll(sc: SparkContext)`,
which register accumulators, but sometimes we don't.
TODO:
1. figure out when we should register accumulators and fix all tests.
2. `TaskContextImpl.initialAccumulators` is no longer needed, we can remove
it in follow-ups since it's a lot of change.
## How was this patch tested?
existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark acc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12472
----
commit 9eb2a874b91962e58f5f72775b2529f5a117b41e
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2016-04-18T15:42:38Z
create accumulators in TaskMetrics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
