Github user sjbrunst commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1717#discussion_r17091665
  
    --- Diff: 
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
 ---
    @@ -33,15 +33,20 @@ object TwitterUtils {
        *        twitter4j.oauth.consumerSecret, twitter4j.oauth.accessToken and
        *        twitter4j.oauth.accessTokenSecret
        * @param filters Set of filter strings to get only those tweets that 
match them
    +   * @param locations Set of longitude and latitude coordinates to get 
only those tweets within the
    +            bounding box defined by those points. Example: 
Seq(Seq(-180.0,-90.0),Seq(180.0,90.0))
    +            gives any geotagged tweet. If locations and filters are both 
nonempty, then any tweet
    +            matching either condition may be returned.
        * @param storageLevel Storage level to use for storing the received 
objects
        */
       def createStream(
           ssc: StreamingContext,
           twitterAuth: Option[Authorization],
           filters: Seq[String] = Nil,
    +      locations: Seq[Seq[Double]] = Nil,
    --- End diff --
    
    I'm having a bit of trouble here. I tried adding the following code to 
ensure binary compatibility, but it doesn't compile:
    ```scala
      def createStream(
          ssc: StreamingContext,
          twitterAuth: Option[Authorization],
          filters: Seq[String] = Nil,
          storageLevel: StorageLevel = StorageLevel.MEMORY_AND_DISK_SER_2
        ): ReceiverInputDStream[Status] = {
        createStream(ssc, twitterAuth, filters, Nil, storageLevel)
      }
    ```
    
    When include that I get the following error:
    ```
    [error] 
/home/shawn/Research/git-spark/spark/external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala:70:
 overloaded method value createStream with alternatives:
    [error]   (jssc: 
org.apache.spark.streaming.api.java.JavaStreamingContext,twitterAuth: 
twitter4j.auth.Authorization)org.apache.spark.streaming.api.java.JavaReceiverInputDStream[twitter4j.Status]
 <and>
    [error]   (jssc: 
org.apache.spark.streaming.api.java.JavaStreamingContext,filters: 
Array[String])org.apache.spark.streaming.api.java.JavaReceiverInputDStream[twitter4j.Status]
 <and>
    [error]   (ssc: org.apache.spark.streaming.StreamingContext,twitterAuth: 
Option[twitter4j.auth.Authorization],filters: Seq[String],storageLevel: 
org.apache.spark.storage.StorageLevel)org.apache.spark.streaming.dstream.ReceiverInputDStream[twitter4j.Status]
 <and>
    [error]   (ssc: org.apache.spark.streaming.StreamingContext,twitterAuth: 
Option[twitter4j.auth.Authorization],filters: Seq[String],locations: 
Seq[Seq[Double]],storageLevel: 
org.apache.spark.storage.StorageLevel)org.apache.spark.streaming.dstream.ReceiverInputDStream[twitter4j.Status]
    [error]  cannot be applied to (org.apache.spark.streaming.StreamingContext, 
None.type)
    [error]     createStream(jssc.ssc, None)
    ```
    And similar errors for three more of the Java functions. @tdas Do you have 
any suggestions for how I can get this working?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to