Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126315856 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -259,6 +344,7 @@ package object config { " over estimate, then the partitions with small files will be faster than partitions with" + " bigger files.") .longConf + .checkValue(_ > 0, "The number of CostInBytes event queue must not be negative") --- End diff -- Since `_ > 0`, we should avoid 0, too. `must not be negative` => `must be positive`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org