Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3518#discussion_r21786754
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -873,6 +943,10 @@ class DAGScheduler(
           // We've already serialized RDDs and closures in taskBinary, but 
here we check for all other
           // objects such as Partition.
           try {
    +        if(debugSerialization)
    --- End diff --
    
    Please see our code style guide; there should be spaces after the `if` and 
the brace should be included on this line.
    
    https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to