On Oct 18, 2007, at 12:21 PM, William Stein wrote: > > On 10/18/07, David Roe <[EMAIL PROTECTED]> wrote: >> Yeah, that doesn't sound like a good idea. > > There were far more complaints when it did show up, > since people got confused by it, though it was a typo, > couldn't paste it into sessions, etc. > > I think it should be replaced by > > sage: f.factor_padic() # not tested > > i.e., "putting not tested" as a comment has the same effect > as sage.:. I wrote the"sage." notation before there were > doctesting comment modifiers. > > Does this seem ok with everybody? Comment modifiers are definitely > much clearer than "sage.:".
Sounds better to me. > >> >> David >> >> On 10/18/07, David Harvey <[EMAIL PROTECTED] > wrote: >>> >>> Arrggghhh. When you do code inspection via factor_padic?, the period >> apparently gets filtered out. That's not very helpful somehow. >>> >>> >>> david >>> >>> >>> >>> >>> On Oct 18, 2007, at 10:37 AM, David Roe wrote: >>> >>> The reason is that that doctest has sage.: >>> David >>> >>> >>> On 10/18/07, David Harvey <[EMAIL PROTECTED] > wrote: >>>> >>>> Ummmmmm...... >>>> >>>> sage: R.<x> = QQ[] >>>> sage: f = x^3 - 2 >>>> sage: f.factor_padic(2) >>>> >> --------------------------------------------------------------------- >> --- >>>> --- >>>> <type 'exceptions.TypeError'> Traceback (most recent >>>> call >>>> last) >>>> >>>> /Users/david/sage- 2.8.4/<ipython console> in <module>() >>>> >>>> >> /Users/david/sage-2.8.4/local/lib/python2.5/site-packages/sage/rings/ >>>> polynomial/polynomial_element_generic.py in >> factor_padic(self, p, prec) >>>> 875 K = Qp(p, prec, type='capped-rel') >>>> 876 R = >>>> sage.rings.polynomial.polynomial_ring.PolynomialRing(K, >>>> names=self.parent().variable_name()) >>>> --> 877 return R(self).factor(absprec = prec) >>>> 878 >>>> 879 def list(self): >>>> >>>> <type 'exceptions.TypeError'>: factor() got an unexpected keyword >>>> argument 'absprec' >>>> >>>> >>>> This happens on the current version of sage on sage.math, it also >>>> happens on sage 2.8.5 on my machine at home. But that's exactly the >>>> example code in the doctest for factor_padic! Why isn't it failing >>>> doctests? >>>> >>>> david >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >> >> >>> >> > > > -- > William Stein > Associate Professor of Mathematics > University of Washington > http://wstein.org > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
