On Aug 27, 9:56 pm, "Arnaud Bergeron" <[EMAIL PROTECTED]> wrote:
> 2008/8/27 John Cremona <[EMAIL PROTECTED]>:
>
Hi Arnaud,
> Since this bugged me (I did the adaptive rendering thing) I timed the
> doctests for plot.py on my machine:
>
> sage 3.1.1 vanilla
> sage -t devel/sage-main/sage/plot/plot.py
> [146.8 s]
>
> ----------------------------------------------------------------------
> All tests passed!
> Total time for all tests: 146.8 seconds
>
> sage 3.1.1 with trac #3813 applied
>
> sage -t devel/sage-plotting/sage/plot/plot.py *** ***
> Error: TIMED OUT! *** ***
> For whitespace errors, see the file
> /Volumes/Place/anakha/Applications/sage/tmp/.doctest_plot.py*** ***
> Error: TIMED OUT! *** ***
> [532.7 s]
> exit code: 1024
>
> ----------------------------------------------------------------------
> The following tests failed:
>
> sage -t devel/sage-plotting/sage/plot/plot.py
> Total time for all tests: 532.7 seconds
>
> So yeah, there is definitly something wrong there. After
> investigation, I realized that I messed the order of xmin and xmax in
> the submitted patch making delta negative. With only that change, the
> timings go down to more reasonable levels.
>
> sage 3.1.1 with trac #3813 and this little diff
> """
> diff -r c5f36741c6d9 sage/plot/plot.py
> --- a/sage/plot/plot.py Wed Aug 27 23:52:34 2008 -0400
> +++ b/sage/plot/plot.py Thu Aug 28 00:41:01 2008 -0400
> @@ -3820,8 +3820,8 @@
> #be all plotted together.
> if isinstance(funcs, (list, tuple)) and not parametric:
> return reduce(operator.add, (plot(f, (xmin, xmax), polar=polar,
> **k
> wds) for f in funcs))
> -
> - delta = float(xmin-xmax) / plot_points
> +
> + delta = float(xmax-xmin) / plot_points
>
> random = current_randstate().python_random().random
> exceptions = 0; msg=''
>
> """
> sage -t devel/sage-plotting2/sage/plot/plot.py
> [195.5 s]
>
> ----------------------------------------------------------------------
> All tests passed!
> Total time for all tests: 195.5 seconds
>
> It is still slower, but much better than before so this little patch
> above should really be applied. I don't think it warrants its own
> trac ticket, but if that makes the life of Michael simpler, I will do
> it. I could also just add it to #3813 if the posting is all that's
> needed.
Thanks for tracking this down. Please open a new ticket and attach the
patch to it.
We generally attempt to avoid reopening tickets or adding patches to
tickets that were closed in previous milestones since that makes
reconstructing the exact sequence of patches hard.
> Arnaud
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
