Justin, Two things: (1) Does your patch take into account the substantial patches concerning binary quadratic forms already merged in 3.1.2, see #3857 and #3946? (2) you have posted a raw diff, not a mercurial patch, which is why trac does not display it properly -- and which will make it harder for reviewers to deal with.
I certainly like the idea of extending the bqf code. John 2008/9/14 Justin Walker <[EMAIL PROTECTED]>: > > Hi, all, > > I took a look at the quadratic forms code, to start getting back to > working on Sage. I've made some additions and a few changes, and I > have a patch ready for review. I welcome all comments. > > I've doc-tested it, and run some other tests of my own. It seems > stable, but if anyone depends on it, I'd appreciate feedback on how it > behaves. The code should "just work", but that's just the theory :-}. > > See trac #4120. It's not assigned a milestone yet. > > Also, Trac complains that there's no HTML version of the patch. Where > is that described? I did a quick search for 'patch' in the doc and > FAQ, but found nothing obvious. > > Thanks! > > Justin > > -- > Justin C. Walker, Curmudgeon at Large > Director > Institute for the Enhancement of the Director's Income > ----------- > Nobody knows the trouble I've been > ----------- > > > > > > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
