On Sep 17, 1:01 pm, "Bill Page" <[EMAIL PROTECTED]> wrote:
> Michael,
Hi Bill,
> #4028: Mike Hansen: doctest and improve sage/interfaces/axiom.py
> [Reviewed by Michael Abshoff]
>
> was originally in 3.1.2.alpha4 but got removed somewhere along the
> line. In trac is now says it's closed and "Merged in Sage
> 3.1.2.alpha4" but I do not think that is actually true. Or did some
> part of this actually get into 3.1.2?
Yes, the complete patch is it:
changeset: 10443:c48ff6dc4888
user: Mike Hansen <[EMAIL PROTECTED]>
date: Sun Aug 31 20:06:36 2008 -0700
summary: Doctest sage/interfaces/axiom.py
It is also still there:
[EMAIL PROTECTED]:/scratch/mabshoff/release-cycle/sage-3.1.2.rc5/devel/sage
$ patch -p1 -R --dry-run < ~/release-cycles-3.1.2/alpha4/
trac_4028.patch
patching file sage/interfaces/axiom.py
patching file sage/interfaces/expect.py
Hunk #1 succeeded at 1193 (offset 5 lines).
Hunk #2 succeeded at 1210 (offset 5 lines).
Hunk #3 succeeded at 1229 (offset 5 lines).
Hunk #4 succeeded at 1294 (offset 5 lines).
patching file sage/interfaces/gp.py
Hunk #1 succeeded at 687 (offset 22 lines).
> Mike, Martin and I have been discussing and improving on this change in
>
> http://trac.sagemath.org/sage_trac/ticket/4036
>
> which is still listed as "needs work".
>
> Can we set some kind of milestone for getting this into the next
> release? What do we really need to do to make this happen?
Some doctests failed and at that point in the release cycle I
considered it too risky to merge. Mike has posted a patch that fixes
the issue I found while doctesting, so it needs a fresh review.
> I have sent a few more patches related to this to Mike, but I am not
> sure if he really wants to carry this task or not. Mike?
>
> Also I sent Michael a request some days ago that I me added as a user
> to trac, that way I could post patches there (once I figure out how).
> Is there any problem with that?
Mhhh, I remember that email and thought I created the account, but
maybe I got things mixed up. I can't seem to find that email, so could
you resend it?
> Regards,
> Bill Page.
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
