Tim Daly wrote:
Dr. David Kirkby wrote:
I submitted a patch which I believe is very simple and should not break anything, but it could not be merged into sage-4.3.1.rc0 because it breaks the Singular installation on Sage. (It was marked as fixed, then changed to 'needs work' as it fails.)

Can anyone spot what is wrong with it?

Here's the patch.
http://trac.sagemath.org/sage_trac/attachment/ticket/7898/singular-variables-to-names.patch

heres the ticket.

http://trac.sagemath.org/sage_trac/ticket/7898

Note sage-env has for a long time defined there, and that is unchanged. So why should that break.


if [ "$RM" = "" ]; then
    RM="rm"  && export RM
fi

if [ "$LN" = "" ]; then
    LN="ln"  && export LN
fi


if [ "$CHMOD" = "" ]; then
    CHMOD="chmod"  && export CHMOD
fi


Is this change in a Makefile?

No, the changes are to a shell script, spkg-install.

Then the syntax is wrong. Try

${CHMOD}

because

$CHMOD is interpreted as $C

Tim

In any case, I'm changing from the $CHMOD to just chmod, rather than the other way around.

I can't possibly see how a hard-coded 'chmod' can be any different from a $CHMOD which is set to 'chmod'. Likewise for $RM and $LN.

I did say this one was a challenge!


Dave


-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to