2010/1/19 William Stein <wst...@gmail.com>: > On Tue, Jan 19, 2010 at 1:16 AM, John Cremona <john.crem...@gmail.com> wrote: >> If someone is looking into that please say so on the ticket, otherwise >> I'll look at it today (GMT). > > John -- go for it; none of us are doing it!
OK. I just did #7992 too. John > >> >> John >> >> 2010/1/19 William Stein <wst...@gmail.com>: >>> On Mon, Jan 18, 2010 at 4:59 PM, John H Palmieri <jhpalmier...@gmail.com> >>> wrote: >>>> Ticket #7532 deals with this issue: in ring.pyx, code says "return >>>> NotImplementedError" where it should say "raise NotImplementedError". >>>> But if I make this change: >>>> >>>> diff -r c86168806012 -r 919f3924ef5c sage/rings/ >>>> ring.pyx >>>> --- a/sage/rings/ring.pyx Mon Jan 18 12:40:07 2010 -0800 >>>> +++ b/sage/rings/ring.pyx Mon Jan 18 13:14:58 2010 -0800 >>>> @@ -692,7 +692,7 @@ >>>> return False >>>> >>>> if proof: >>>> - return NotImplementedError >>>> + raise NotImplementedError >>>> else: >>>> return False >>>> >>>> then I get doctest failures in various files in sage/schemes/ >>>> elliptic_curves. I'm assuming this is a problem in the elliptic curves >>>> code, so can someone who is familiar with it take a look at this >>>> problem? (Even better: two people, one to write a patch and one to >>>> review it :) >>>> >>>> Thanks, >>>> John >>>> >>> >>> I added that to my list: http://trac.sagemath.org/sage_trac/wiki/sd19-bugs >>> >>> Any chance you're going to drop by the mansion... 5218 16th ave NE, >>> Seattle, WA 98105 >>> >>> -- >>> To post to this group, send an email to sage-devel@googlegroups.com >>> To unsubscribe from this group, send an email to >>> sage-devel+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/sage-devel >>> URL: http://www.sagemath.org >>> >>> >> >> -- >> To post to this group, send an email to sage-devel@googlegroups.com >> To unsubscribe from this group, send an email to >> sage-devel+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/sage-devel >> URL: http://www.sagemath.org >> >> > > > > -- > William Stein > Associate Professor of Mathematics > University of Washington > http://wstein.org > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > >
-- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
