As I am working on patching this, I wonder if we shouldn't have an API change in sage. Currently several functions, namely cliques_number_of take a 'with_labels' argument as a Bool to determine whether a dictionary of values is returned or a list. In the new networkx version, the function always returns a dictionairy, and one can access the list of values with a call to .values(). This seems more natural and intuitive to me, and I think we should change the sage function to be consistent with the networkx method. Thoughts?
On Jul 22, 9:33 am, Ben Edwards <bjedwa...@gmail.com> wrote: > Yep, > > I'm starting this morning. I'm a little new with mercurial, but will > hopefully have a patch soon. > > Ben > > On Jul 22, 2:22 am, François Bissey <f.r.bis...@massey.ac.nz> wrote: > > > > > > Here's the ticket: > > > >http://trac.sagemath.org/sage_trac/ticket/9567 > > > > And the new links on the google code pages > > > >http://spkg-upload.googlecode.com/files/networkx-1.1.spkg > > > >http://code.google.com/p/spkg-upload/downloads/detail?name=networkx-1... > > > g.md5&can=2&q= > > > Hi Ben, > > > will you take care of the tests that this upgrade breaks? > > We already can use this version ofnetworkxin sage-on-gentoo > > but it breaks a fair number of tests. > > > Francois -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
