The branch, v3-devel has been updated
       via  0d824d7188518aaa7b4e890885e6bc42e94397c5 (commit)
      from  a03b0dde01e4cebe07a65af3943d178dbdeda276 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-devel


- Log -----------------------------------------------------------------
commit 0d824d7188518aaa7b4e890885e6bc42e94397c5
Author: Jeremy Allison <[EMAIL PROTECTED]>
Date:   Wed Sep 10 16:22:51 2008 -0700

    Fix bug #5052 - not work cancel inheritance on share. We were
    using the parent security descriptor type and flags instead
    of using the passed in SD.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/posix_acls.c |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/posix_acls.c b/source/smbd/posix_acls.c
index 427cfc9..7479aea 100644
--- a/source/smbd/posix_acls.c
+++ b/source/smbd/posix_acls.c
@@ -3398,10 +3398,17 @@ static NTSTATUS append_parent_acl(files_struct *fsp,
                        parent_name));
        }
 
-       parent_sd->dacl->aces = new_ace;
-       parent_sd->dacl->num_aces = i;
+       /* This sucks. psd should be const and we should
+        * be doing a deep-copy here. We're getting away
+        * with is as we know parent_sd is talloced off
+        * talloc_tos() as well as psd. JRA. */
 
-       *pp_new_sd = parent_sd;
+       psd->dacl->aces = new_ace;
+       psd->dacl->num_aces = i;
+       psd->type &= ~(SE_DESC_DACL_AUTO_INHERITED|
+                         SE_DESC_DACL_AUTO_INHERIT_REQ);
+
+       *pp_new_sd = psd;
        return status;
 }
 


-- 
Samba Shared Repository

Reply via email to