[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-562976199 @rhtyd closed in favor of cloudstack primate development https://github.com/apache/cloudstack-primate/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-500733804 @rafaelweingartner ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498599819 @rafaelweingartner thanks for the comment. Yes, the proposal is to change this "standard" and add a to create/propose a migration path for people who use the default settings. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-495935740 @PaulAngus just so I understand it correctly... 1. add the disk offering from for domain router, CPVM, SSVM ... to the service offering table. right? 2. remove them, after unused from disk offering? is that correct? i need to add that if you have a managed storage the VPC, SSVM, CPVM will be created with... ![image](https://user-images.githubusercontent.com/5433844/58372856-6b76aa80-7f24-11e9-8d0c-3076384335c6.png) i dont know if this is hard coded... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-49701 Yes you are right at the moment we have two way to set default values 1. global settings 2. this PR First of all we introduced this to make it possible to use the UI to change the service offering for the routers not to use this ugly database hack. before you could set it in the global settings and the hack. now you can set in in the UI. we focused on not to break the functionality. there are different tables. "disk offering" and "service offering" they are connected. there are a "unique_name" and "default_use" ... they seems to be connected. first we thought to rewrite them but there is a lot of work to do and it would break the existing functionality. okay here is the plan, 1. we implement this PR 2. we and our team will work on all our issues and we will improve and change them step by step accordingly. we remove in a second PR the global settings _it can be under discussion to change/adapt the "network offering" "but" i have to admit "network offering" the present network offerings meet all recent requirements. if we change them we would create a huge and complex beast. these mean, change the database and the UI. its a lot of work._ at the moment i think the System Offering is the best location to set up values. ![image](https://user-images.githubusercontent.com/5433844/58320086-2dda2a80-7e1b-11e9-8d5d-af969f7dbd06.png) the main problem here is the awful connection between the "disk offering" "service offering" because in "Service Offering" there will be saved CPU, RAM and so one... lets try to work out best solution... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-494902697 > @svenvogel @pbankonier - I can see that you've put a lot of work into this, but unless I've missed something, couldn't this be done a bit simpler by populating the service_offering_id for all of the default network offerings as: 9 or 10 (shared/local storage offerings for domainrouter). i try to understand this... maybe we dont have them anymore. you mean populating the service_offering_id. what do you mean practically with this? after some changes you will have different ids because you have different ram and cpu sizes each linked to a domainrouter. the only difference is the default use flag. ![image](https://user-images.githubusercontent.com/5433844/58196277-3e2ec000-7cca-11e9-8884-3f0fe845833a.png) > Migrating from the global settings if people have updated them wouldn't be difficult, the service offerings 9 and 10 would just have to be updated with the values in the global settings. you mean that these values are always fix? whats with different sizes? whats the difference between globalsettings vs http://docs.cloudstack.apache.org/projects/archived-cloudstack-administration/en/latest/service_offerings.html database hack? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-494805376 @PaulAngus can you make it more clear what you mean with "service_offering_id" 9 and 10? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-494569336 @PaulAngus thanks for info i will discuss this with @pbankonier and come back This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-490160128 @ustcweizhou can you approve it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-489090313 @DaanHoogland we dont agree. we would prefer this functionality. we dont think its somehow like "clunky". "clunky" was it implemented before. we think it should be easier so set it for all types of system vms. this feature allow to set different type of system vm images. to get this a graphical menu is more user friendly than one value for each type of system vm in global settings. at the moment its a > I would prefer to add a global setting to specify the default service offering for routers. > The service offering will be determined in findServiceOfferingId() in RouterDeploymentDefinition.java and VpcRouterDeploymentDefinition.java > > If you do not mind, I can create a PR for it. what this means its determined in this functions? is there any functionality they breaks this? why it should set this in global setting when all other things for "offering" are set there? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-489090813 > Also we may be changing names against the convention that someone might want to maintain. @DaanHoogland which function? which convention? please declare it exactly what you mean. at the moment we dont think we break anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-487914592 @DaanHoogland can you approve? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services