[JIRA] [cvs] (JENKINS-16314) cvs plugin removes sticky branch tag
Adriano Andrulis commented on JENKINS-16314 cvs plugin removes sticky branch tag Hi Michael, do you know when the next version will be release? Thanks in advance. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16314) cvs plugin removes sticky branch tag
Adriano Andrulis
commented on JENKINS-16314
cvs plugin removes sticky branch tag
Hi Michael, while debugging the code I found the problem is in the cleanout method on the FileCallable inner class on the AbstractCVS.java line 695.
It call entry.setDate(null) that also removes the tag entry as it's stated on its javadoc "Set the sticky date information. Note that setting this will remove any tag information that is currently set."
private void cleanup(File directory, AdminHandler adminHandler) throws IOException {
for (File file : adminHandler.getAllFiles(directory)) {
Entry entry = adminHandler.getEntry(file);
String savedTag = entry.getTag();
entry.setDate(null);
adminHandler.setEntry(file, entry);
}
I hope that helps your analysis.
As a quick fix I've changed my AbstractCVS code as below but I'm not fully sure of the consequences.
entry.setDate(null);
to
String savedTag = entry.getTag();
entry.setDate(null);
if(savedTag != null) {
entry.setTag(savedTag);
}
Thanks and Regards.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16314) cvs plugin removes sticky branch tag
Adriano Andrulis commented on JENKINS-16314 cvs plugin removes sticky branch tag Hi Michael, following is the xml for the job mentioned by James. Thanks for looking at. "maven-plugin@1.499"> server branch build false "jenkinswalldisplay@0.6.15"/> "hudson.scm.CVSSCM" plugin="cvs@2.8"> true "hudson.scm.browsers.ViewCVS"> https://viewvc/cgi-bin/viewvc.cgi/server/?root=root :pserver:builder@pserver:/cvsroot-root Component/services/server "hudson.scm.CvsRepositoryLocation$BranchRepositoryLocation"> BRANCH RC_repServer2_6 false -1 B5SEyM3MM3X7KWpcw= true false false true true false true dev02 false false false false sun_jdk_7 "vector"> # every 10 mins */10 * * * * false false com.components.server server -U -DskipITs=false clean install -e -Xmx512M -Dm3plugin.lib=/space/jenkins_slave/main/workspace/artifactory-plugin/2.1.3 true false true false false false false -1 false false "jenkins.mvn.DefaultSettingsProvider"/> "jenkins.mvn.DefaultGlobalSettingsProvider"/> d...@mail.com false true true "m2release@0.9.1"> IS_M2RELEASEBUILD -Dresume=false release:prepare release:perform -Dmaven.scm.provider.cvs.implementation=cvs_native -X -X -Dresume=false -DdryRun=true release:prepare -Dmaven.scm.provider.cvs.implementation=cvs_native -e false false false "artifactory@2.1.3"> http://artifactory/artifactory http://artifactory/artifactory repository SUCCESS 0 BLUE This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
