Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
On Tue, Jun 3, 2014 at 7:22 AM, Lucas Stach wrote: > Hello Bjorn, > > Am Freitag, den 30.05.2014, 11:30 -0600 schrieb Bjorn Helgaas: >> On Mon, May 12, 2014 at 10:59:43AM +0200, Lucas Stach wrote: >> > Hi Bjorn, >> > >> > just a friendly reminder. It would be nice if you could pull those in. >> > >> > Shawn already pulled the DT change and as it is a binding change this >> > means PCIe on i.MX6 is broken in -next, as long as the remaining patches >> > are missing. >> >> I applied these to pci/host-imx6 for v3.16. >> >> Sorry I didn't do this sooner; I get a lot of email and it's easy to >> overlook things. I mostly work from patchwork >> (http://patchwork.ozlabs.org/project/linux-pci/list/?order=date), and I had >> dropped this series from there because there was enough discussion that I >> expected a re-post, so it wasn't on my radar screen anymore. >> >> Bjorn >> >> > Am Dienstag, den 29.04.2014, 14:31 +0200 schrieb Lucas Stach: >> > > Hi Bjorn, >> > > >> > > Am Freitag, den 25.04.2014, 08:39 -0600 schrieb Bjorn Helgaas: >> > > [...] >> > > > >> > PCI: designware: split Exynos and i.MX bindings > > It seems you missed this one patch. This isn't too urgent, as it is just > the doc update, but it should still go into 3.16 along with the other > changes. I would have expected that is ok for this to go through your > tree. Oops, sorry. I had mentioned patches 4-8 earlier in the conversation, so that's what I merged. I added patch 2 to pci/host-imx6, and I'll ask Linus to pull it later along with some other things I forgot. Thanks for the reminder! Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
Hello Bjorn, Am Freitag, den 30.05.2014, 11:30 -0600 schrieb Bjorn Helgaas: > On Mon, May 12, 2014 at 10:59:43AM +0200, Lucas Stach wrote: > > Hi Bjorn, > > > > just a friendly reminder. It would be nice if you could pull those in. > > > > Shawn already pulled the DT change and as it is a binding change this > > means PCIe on i.MX6 is broken in -next, as long as the remaining patches > > are missing. > > I applied these to pci/host-imx6 for v3.16. > > Sorry I didn't do this sooner; I get a lot of email and it's easy to > overlook things. I mostly work from patchwork > (http://patchwork.ozlabs.org/project/linux-pci/list/?order=date), and I had > dropped this series from there because there was enough discussion that I > expected a re-post, so it wasn't on my radar screen anymore. > > Bjorn > > > Am Dienstag, den 29.04.2014, 14:31 +0200 schrieb Lucas Stach: > > > Hi Bjorn, > > > > > > Am Freitag, den 25.04.2014, 08:39 -0600 schrieb Bjorn Helgaas: > > > [...] > > > > >> > PCI: designware: split Exynos and i.MX bindings It seems you missed this one patch. This isn't too urgent, as it is just the doc update, but it should still go into 3.16 along with the other changes. I would have expected that is ok for this to go through your tree. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
On Mon, May 12, 2014 at 10:59:43AM +0200, Lucas Stach wrote: > Hi Bjorn, > > just a friendly reminder. It would be nice if you could pull those in. > > Shawn already pulled the DT change and as it is a binding change this > means PCIe on i.MX6 is broken in -next, as long as the remaining patches > are missing. I applied these to pci/host-imx6 for v3.16. Sorry I didn't do this sooner; I get a lot of email and it's easy to overlook things. I mostly work from patchwork (http://patchwork.ozlabs.org/project/linux-pci/list/?order=date), and I had dropped this series from there because there was enough discussion that I expected a re-post, so it wasn't on my radar screen anymore. Bjorn > Am Dienstag, den 29.04.2014, 14:31 +0200 schrieb Lucas Stach: > > Hi Bjorn, > > > > Am Freitag, den 25.04.2014, 08:39 -0600 schrieb Bjorn Helgaas: > > [...] > > > >> > PCI: designware: split Exynos and i.MX bindings > > > >> > ARM: dts: imx6: update pcie to bring in line with new binding > > > >> > PCI: imx6: use new clock names > > > >> > PCI: imx6: drop old irq mapping > > > >> > PCI: imx6: rip out optional (and unused) irqs > > > >> > PCI: designware: make MSI isr shared irq aware > > > >> > PCI: imx6: add support for MSI > > > >> > > > >> What's the status of all these? I would normally apply patches 4-8 of > > > >> this > > > >> series through my tree, given the appropriate acks, but I haven't seen > > > >> those yet. And I'm not sure what dependencies there are between the > > > >> non-PCI patches and the PCI ones. > > > >> > > > > It's a complete binding change, so applying one part without the other > > > > is going to horribly break things. > > > > > > > > So I would at least want to see an ack for the binding change on the > > > > i.MX side from Shawn and Richard. This will need some follow on patches, > > > > as some boards adding PCIe using the old binding have cropped up in > > > > linux-next, but I can do the patches on short notice if everyone agrees > > > > to merge this patchset. > > > > > > > > The designware part is pretty simple and doesn't change anything for > > > > other users than i.MX. Though I would like to see an ack from Jingoo for > > > > those. > > > > > > > > I have some more stuff in the pipes regarding multiple MSI irqs, that > > > > depend on this series and also the Keystone people are waiting for this > > > > to be applied in order to consolidate the clock handling of the > > > > designware core driver, so it would be nice to get this moving again. > > > > > > OK, just poke me again when you're ready for me to do something with > > > these. > > > > > > > As both Richard and Jingoo gave their ack for the respective patches I > > think this is good to go in and I would expect all the PCI patches to go > > through your tree for 3.16. > > > > Shawn, if you are not okay with this change, please speak up now. > > Otherwise please pick the dts change for 3.16. I'll go over linux-next > > and prepare the patches to fix up the boards there. > > > > > -- > Pengutronix e.K. | Lucas Stach | > Industrial Linux Solutions | http://www.pengutronix.de/ | > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
Hi Bjorn, On Mon, May 12, 2014 at 5:59 AM, Lucas Stach wrote: > Hi Bjorn, > > just a friendly reminder. It would be nice if you could pull those in. > > Shawn already pulled the DT change and as it is a binding change this > means PCIe on i.MX6 is broken in -next, as long as the remaining patches > are missing. We still have imx6q pcie broken in linux-next: imx6q-pcie 1ffc000.pcie: lvds_gate clock select missing or invalid imx6q-pcie: probe of 1ffc000.pcie failed with error -2 Could you please apply Lucas' series? -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
Hi Bjorn, just a friendly reminder. It would be nice if you could pull those in. Shawn already pulled the DT change and as it is a binding change this means PCIe on i.MX6 is broken in -next, as long as the remaining patches are missing. Regards, Lucas Am Dienstag, den 29.04.2014, 14:31 +0200 schrieb Lucas Stach: > Hi Bjorn, > > Am Freitag, den 25.04.2014, 08:39 -0600 schrieb Bjorn Helgaas: > [...] > > >> > PCI: designware: split Exynos and i.MX bindings > > >> > ARM: dts: imx6: update pcie to bring in line with new binding > > >> > PCI: imx6: use new clock names > > >> > PCI: imx6: drop old irq mapping > > >> > PCI: imx6: rip out optional (and unused) irqs > > >> > PCI: designware: make MSI isr shared irq aware > > >> > PCI: imx6: add support for MSI > > >> > > >> What's the status of all these? I would normally apply patches 4-8 of > > >> this > > >> series through my tree, given the appropriate acks, but I haven't seen > > >> those yet. And I'm not sure what dependencies there are between the > > >> non-PCI patches and the PCI ones. > > >> > > > It's a complete binding change, so applying one part without the other > > > is going to horribly break things. > > > > > > So I would at least want to see an ack for the binding change on the > > > i.MX side from Shawn and Richard. This will need some follow on patches, > > > as some boards adding PCIe using the old binding have cropped up in > > > linux-next, but I can do the patches on short notice if everyone agrees > > > to merge this patchset. > > > > > > The designware part is pretty simple and doesn't change anything for > > > other users than i.MX. Though I would like to see an ack from Jingoo for > > > those. > > > > > > I have some more stuff in the pipes regarding multiple MSI irqs, that > > > depend on this series and also the Keystone people are waiting for this > > > to be applied in order to consolidate the clock handling of the > > > designware core driver, so it would be nice to get this moving again. > > > > OK, just poke me again when you're ready for me to do something with these. > > > > As both Richard and Jingoo gave their ack for the respective patches I > think this is good to go in and I would expect all the PCI patches to go > through your tree for 3.16. > > Shawn, if you are not okay with this change, please speak up now. > Otherwise please pick the dts change for 3.16. I'll go over linux-next > and prepare the patches to fix up the boards there. > -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
Hi Bjorn, Am Freitag, den 25.04.2014, 08:39 -0600 schrieb Bjorn Helgaas: [...] > >> > PCI: designware: split Exynos and i.MX bindings > >> > ARM: dts: imx6: update pcie to bring in line with new binding > >> > PCI: imx6: use new clock names > >> > PCI: imx6: drop old irq mapping > >> > PCI: imx6: rip out optional (and unused) irqs > >> > PCI: designware: make MSI isr shared irq aware > >> > PCI: imx6: add support for MSI > >> > >> What's the status of all these? I would normally apply patches 4-8 of this > >> series through my tree, given the appropriate acks, but I haven't seen > >> those yet. And I'm not sure what dependencies there are between the > >> non-PCI patches and the PCI ones. > >> > > It's a complete binding change, so applying one part without the other > > is going to horribly break things. > > > > So I would at least want to see an ack for the binding change on the > > i.MX side from Shawn and Richard. This will need some follow on patches, > > as some boards adding PCIe using the old binding have cropped up in > > linux-next, but I can do the patches on short notice if everyone agrees > > to merge this patchset. > > > > The designware part is pretty simple and doesn't change anything for > > other users than i.MX. Though I would like to see an ack from Jingoo for > > those. > > > > I have some more stuff in the pipes regarding multiple MSI irqs, that > > depend on this series and also the Keystone people are waiting for this > > to be applied in order to consolidate the clock handling of the > > designware core driver, so it would be nice to get this moving again. > > OK, just poke me again when you're ready for me to do something with these. > As both Richard and Jingoo gave their ack for the respective patches I think this is good to go in and I would expect all the PCI patches to go through your tree for 3.16. Shawn, if you are not okay with this change, please speak up now. Otherwise please pick the dts change for 3.16. I'll go over linux-next and prepare the patches to fix up the boards there. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Friday, April 25, 2014 10:40 PM > To: Lucas Stach > Cc: Zhu Richard-R65037; Jingoo Han; Shawn Guo; linux-...@vger.kernel.org; > linux-arm; linux-samsung-soc@vger.kernel.org; devicet...@vger.kernel.org; Sean > Cross; Marek Vasut; Ian Campbell; Mark Rutland; Pawel Moll; Rob Herring; Arnd > Bergmann; Tim Harvey; ker...@pengutronix.de > Subject: Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support > > On Fri, Apr 25, 2014 at 4:21 AM, Lucas Stach wrote: > > Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: > >> On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: > >> > While working on MSI support for the i.MX6 PCIe host driver it has > >> > been discovered that the binding for this host controller is broken > >> > in many ways (refer to the patch descriptions for more > >> > info) and was introduced without proper discussion about what > >> > should/should not be in the binding. > >> > > >> > This series fixes this and minimizes the difference of the > >> > i.MX6 binding to the common designware PCIe binding. I'm aware that > >> > this is a quite radical change, but I think it's justified to do > >> > this as long as there aren't many user of the old binding (most of > >> > the optional properties in the binding aren't even implemented). > >> > > >> > Looking forward to your feedback. > >> > > >> > Lucas Stach (8): > >> > ARM: imx6q-clk: parent lvds_gate from lvds_sel > > This one is already applied. > > > >> > PCI: designware: split Exynos and i.MX bindings > >> > ARM: dts: imx6: update pcie to bring in line with new binding > >> > PCI: imx6: use new clock names > >> > PCI: imx6: drop old irq mapping > >> > PCI: imx6: rip out optional (and unused) irqs > >> > PCI: designware: make MSI isr shared irq aware > >> > PCI: imx6: add support for MSI > >> > >> What's the status of all these? I would normally apply patches 4-8 > >> of this series through my tree, given the appropriate acks, but I > >> haven't seen those yet. And I'm not sure what dependencies there are > >> between the non-PCI patches and the PCI ones. > >> > > It's a complete binding change, so applying one part without the other > > is going to horribly break things. > > > > So I would at least want to see an ack for the binding change on the > > i.MX side from Shawn and Richard. This will need some follow on > > patches, as some boards adding PCIe using the old binding have cropped > > up in linux-next, but I can do the patches on short notice if everyone > > agrees to merge this patchset. > > > > The designware part is pretty simple and doesn't change anything for > > other users than i.MX. Though I would like to see an ack from Jingoo > > for those. > > > > I have some more stuff in the pipes regarding multiple MSI irqs, that > > depend on this series and also the Keystone people are waiting for > > this to be applied in order to consolidate the clock handling of the > > designware core driver, so it would be nice to get this moving again. [Richard] Hi Lucas, thanks. I'm ok for this patch-set. Acked-by: Richard Zhu > > OK, just poke me again when you're ready for me to do something with these. > > Bjorn > Best Regards Richard Zhu
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
On Fri, Apr 25, 2014 at 4:21 AM, Lucas Stach wrote: > Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: >> On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: >> > While working on MSI support for the i.MX6 PCIe host driver >> > it has been discovered that the binding for this host controller >> > is broken in many ways (refer to the patch descriptions for more >> > info) and was introduced without proper discussion about what >> > should/should not be in the binding. >> > >> > This series fixes this and minimizes the difference of the >> > i.MX6 binding to the common designware PCIe binding. I'm aware >> > that this is a quite radical change, but I think it's justified >> > to do this as long as there aren't many user of the old binding >> > (most of the optional properties in the binding aren't even >> > implemented). >> > >> > Looking forward to your feedback. >> > >> > Lucas Stach (8): >> > ARM: imx6q-clk: parent lvds_gate from lvds_sel > This one is already applied. > >> > PCI: designware: split Exynos and i.MX bindings >> > ARM: dts: imx6: update pcie to bring in line with new binding >> > PCI: imx6: use new clock names >> > PCI: imx6: drop old irq mapping >> > PCI: imx6: rip out optional (and unused) irqs >> > PCI: designware: make MSI isr shared irq aware >> > PCI: imx6: add support for MSI >> >> What's the status of all these? I would normally apply patches 4-8 of this >> series through my tree, given the appropriate acks, but I haven't seen >> those yet. And I'm not sure what dependencies there are between the >> non-PCI patches and the PCI ones. >> > It's a complete binding change, so applying one part without the other > is going to horribly break things. > > So I would at least want to see an ack for the binding change on the > i.MX side from Shawn and Richard. This will need some follow on patches, > as some boards adding PCIe using the old binding have cropped up in > linux-next, but I can do the patches on short notice if everyone agrees > to merge this patchset. > > The designware part is pretty simple and doesn't change anything for > other users than i.MX. Though I would like to see an ack from Jingoo for > those. > > I have some more stuff in the pipes regarding multiple MSI irqs, that > depend on this series and also the Keystone people are waiting for this > to be applied in order to consolidate the clock handling of the > designware core driver, so it would be nice to get this moving again. OK, just poke me again when you're ready for me to do something with these. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: > On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: > > While working on MSI support for the i.MX6 PCIe host driver > > it has been discovered that the binding for this host controller > > is broken in many ways (refer to the patch descriptions for more > > info) and was introduced without proper discussion about what > > should/should not be in the binding. > > > > This series fixes this and minimizes the difference of the > > i.MX6 binding to the common designware PCIe binding. I'm aware > > that this is a quite radical change, but I think it's justified > > to do this as long as there aren't many user of the old binding > > (most of the optional properties in the binding aren't even > > implemented). > > > > Looking forward to your feedback. > > > > Lucas Stach (8): > > ARM: imx6q-clk: parent lvds_gate from lvds_sel This one is already applied. > > PCI: designware: split Exynos and i.MX bindings > > ARM: dts: imx6: update pcie to bring in line with new binding > > PCI: imx6: use new clock names > > PCI: imx6: drop old irq mapping > > PCI: imx6: rip out optional (and unused) irqs > > PCI: designware: make MSI isr shared irq aware > > PCI: imx6: add support for MSI > > What's the status of all these? I would normally apply patches 4-8 of this > series through my tree, given the appropriate acks, but I haven't seen > those yet. And I'm not sure what dependencies there are between the > non-PCI patches and the PCI ones. > It's a complete binding change, so applying one part without the other is going to horribly break things. So I would at least want to see an ack for the binding change on the i.MX side from Shawn and Richard. This will need some follow on patches, as some boards adding PCIe using the old binding have cropped up in linux-next, but I can do the patches on short notice if everyone agrees to merge this patchset. The designware part is pretty simple and doesn't change anything for other users than i.MX. Though I would like to see an ack from Jingoo for those. I have some more stuff in the pipes regarding multiple MSI irqs, that depend on this series and also the Keystone people are waiting for this to be applied in order to consolidate the clock handling of the designware core driver, so it would be nice to get this moving again. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: > While working on MSI support for the i.MX6 PCIe host driver > it has been discovered that the binding for this host controller > is broken in many ways (refer to the patch descriptions for more > info) and was introduced without proper discussion about what > should/should not be in the binding. > > This series fixes this and minimizes the difference of the > i.MX6 binding to the common designware PCIe binding. I'm aware > that this is a quite radical change, but I think it's justified > to do this as long as there aren't many user of the old binding > (most of the optional properties in the binding aren't even > implemented). > > Looking forward to your feedback. > > Lucas Stach (8): > ARM: imx6q-clk: parent lvds_gate from lvds_sel > PCI: designware: split Exynos and i.MX bindings > ARM: dts: imx6: update pcie to bring in line with new binding > PCI: imx6: use new clock names > PCI: imx6: drop old irq mapping > PCI: imx6: rip out optional (and unused) irqs > PCI: designware: make MSI isr shared irq aware > PCI: imx6: add support for MSI What's the status of all these? I would normally apply patches 4-8 of this series through my tree, given the appropriate acks, but I haven't seen those yet. And I'm not sure what dependencies there are between the non-PCI patches and the PCI ones. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
On Friday, March 28, 2014 at 05:52:51 PM, Lucas Stach wrote: > While working on MSI support for the i.MX6 PCIe host driver > it has been discovered that the binding for this host controller > is broken in many ways (refer to the patch descriptions for more > info) and was introduced without proper discussion about what > should/should not be in the binding. > > This series fixes this and minimizes the difference of the > i.MX6 binding to the common designware PCIe binding. I'm aware > that this is a quite radical change, but I think it's justified > to do this as long as there aren't many user of the old binding > (most of the optional properties in the binding aren't even > implemented). > > Looking forward to your feedback. Other but 2/8, which needs further discussion, Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
