Re: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable

[Gonglei (Arei)]

Hi,

> Subject: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable
> 
>   Hi,
> 
> This series the usb host adapters hot-pluggable.  Problem is that we
> can NOT hotplug host adapters which are part of a companion setup.  The
> way this is tackled now is to split the usb host adapter variants into
> two groups:
> 
>   * All ich9-* variants (both uhci and ehci) support companion controller
> and are NOT hot-pluggable.
>   * All other variants do NOT support companion controller setups and
> can be hotplugged.
> 
> [ ohci is to be done, we have only one type there, so we have to create
>   a new one and put the existing into one of the two groups,  /me wants
>   collect feedback on the approach though. ]
> 
> Comments?  Other suggestions?
> 

I agree with you. 

Because we must set 'dc->hotpluggable = false or true' at
$hci_class_init() to assure the host adapters whether supporting hotplugging or 
not.
And we can only pass parameters from Typeinfo struct's class_data property to
$hci_class_init() at present.

Best regards,
-Gonglei

[Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable

[Gerd Hoffmann]

  Hi,

This series the usb host adapters hot-pluggable.  Problem is that we
can NOT hotplug host adapters which are part of a companion setup.  The
way this is tackled now is to split the usb host adapter variants into
two groups:

  * All ich9-* variants (both uhci and ehci) support companion controller
and are NOT hot-pluggable.
  * All other variants do NOT support companion controller setups and
can be hotplugged.

[ ohci is to be done, we have only one type there, so we have to create
  a new one and put the existing into one of the two groups,  /me wants
  collect feedback on the approach though. ]

Comments?  Other suggestions?

cheers,
  Gerd

Gerd Hoffmann (4):
  usb: tag xhci as hotpluggable
  usb: tag standalone uhci as hotpluggable
  usb: tag standalone ehci as hotpluggable
  [wip] usb: tag ohci as hotpluggable

Gonglei (1):
  tests: add usb hcds hotplugging qtest

 hw/usb/hcd-ehci-pci.c| 12 ++-
 hw/usb/hcd-ehci.c|  8 +++--
 hw/usb/hcd-ehci.h|  1 +
 hw/usb/hcd-ohci.c|  1 -
 hw/usb/hcd-uhci.c| 16 +++--
 hw/usb/hcd-xhci.c|  1 -
 tests/Makefile   |  2 ++
 tests/usb-hcd-hotplug-test.c | 86 
 8 files changed, 119 insertions(+), 8 deletions(-)
 create mode 100644 tests/usb-hcd-hotplug-test.c

-- 
1.8.3.1