[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL reopened this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks like there is missing dependency in CMake: https://lab.llvm.org/buildbot/#/builders/57/builds/27531 FAILED: lib/libclangTidyUtils.so.17git : && /home/buildbots/clang.15.0.4/bin/c

[clang-tools-extra] 529633c - Revert "[clang-tidy] Move formatDereference to FixitHintUtils"

Author: Piotr Zegar Date: 2023-06-12T06:27:20Z New Revision: 529633ccfd7595d80f05a4efc7b700517e153770 URL: https://github.com/llvm/llvm-project/commit/529633ccfd7595d80f05a4efc7b700517e153770 DIFF: https://github.com/llvm/llvm-project/commit/529633ccfd7595d80f05a4efc7b700517e153770.diff LOG: R

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

SixWeining created this revision. SixWeining added reviewers: xen0n, MaskRay, xry111, peter.smith, wangleiat. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. I meant to fold this int

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

This revision was automatically updated to reflect the committed changes. Closed by commit rG636c67275142: [clang-tidy] Move formatDereference to FixitHintUtils (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL added a comment. I will push this change, no point to keep it open. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] 636c672 - [clang-tidy] Move formatDereference to FixitHintUtils

Author: Mike Crowe Date: 2023-06-12T06:09:17Z New Revision: 636c672751425f1c73c28bea57c1913043cd21b2 URL: https://github.com/llvm/llvm-project/commit/636c672751425f1c73c28bea57c1913043cd21b2 DIFF: https://github.com/llvm/llvm-project/commit/636c672751425f1c73c28bea57c1913043cd21b2.diff LOG: [c

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

This revision was automatically updated to reflect the committed changes. Closed by commit rG90bbe97036a1: [clang-tidy] Readability-container-data-pointer adds new option to ignore… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 4099053 - [clang-tidy][NFC] Sort changes by check name in ReleaseNotes

Author: Piotr Zegar Date: 2023-06-12T06:07:27Z New Revision: 4099053646a051533a9b1016da665fc9854b18cb URL: https://github.com/llvm/llvm-project/commit/4099053646a051533a9b1016da665fc9854b18cb DIFF: https://github.com/llvm/llvm-project/commit/4099053646a051533a9b1016da665fc9854b18cb.diff LOG: [

[clang-tools-extra] 90bbe97 - [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

Author: Felix Date: 2023-06-12T06:07:27Z New Revision: 90bbe97036a156156759f1555d760890321d50fc URL: https://github.com/llvm/llvm-project/commit/90bbe97036a156156759f1555d760890321d50fc DIFF: https://github.com/llvm/llvm-project/commit/90bbe97036a156156759f1555d760890321d50fc.diff LOG: [clang-

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:69 void StringConstructorCheck::registerMatchers(MatchFinder *Finder) { + const auto SignedCharType = qualType(isAnyCharacter(), isSignedInteger()); const auto ZeroEx

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 530384. mikecrowe added a comment. Rebase, no changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 Files: clang-tools-extra/clang-tidy/readability/RedundantSt

[PATCH] D152561: [AST] Always set dependent-type for the CallExpr for error-recovery in C.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG752b97129789: [AST] Always set dependent-type for the CallExpr for error-recovery in C. (authored by hokein). Repository: rG LLVM Github Monorepo

[clang] 752b971 - [AST] Always set dependent-type for the CallExpr for error-recovery in C.

Author: Haojian Wu Date: 2023-06-12T07:04:39+02:00 New Revision: 752b97129789dec1c2b6093bcbf848d6efb14523 URL: https://github.com/llvm/llvm-project/commit/752b97129789dec1c2b6093bcbf848d6efb14523 DIFF: https://github.com/llvm/llvm-project/commit/752b97129789dec1c2b6093bcbf848d6efb14523.diff LO

[PATCH] D152561: [AST] Always set dependent-type for the CallExpr for error-recovery in C.

hokein updated this revision to Diff 530382. hokein added a comment. add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152561/new/ https://reviews.llvm.org/D152561 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

[PATCH] D152139: [6/6][Clang][RISCV] Replace indexed segment store with tuple type interfaces

eopXD updated this revision to Diff 530374. eopXD added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152139/new/ https://reviews.llvm.org/D152139 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv

[PATCH] D152138: [5/6][Clang][RISCV] Replace indexed segment load with tuple type interfaces

eopXD updated this revision to Diff 530373. eopXD added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152138/new/ https://reviews.llvm.org/D152138 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv

[PATCH] D152137: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces

eopXD updated this revision to Diff 530371. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152137/new/ https://reviews.llvm.org/D152137 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D152136: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces

eopXD updated this revision to Diff 530370. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152136/new/ https://reviews.llvm.org/D152136 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

eopXD updated this revision to Diff 530369. eopXD added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152135/new/ https://reviews.llvm.org/D152135 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv

[PATCH] D152134: [1/6][Clang][RISCV] Replace unit-stride (fault-first) segment load with tuple type interfaces

eopXD updated this revision to Diff 530367. eopXD added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152134/new/ https://reviews.llvm.org/D152134 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv

[PATCH] D152079: [11/11][Clang][RISCV] Expand all variants for vset on tuple types

eopXD updated this revision to Diff 530364. eopXD added a comment. Herald added a subscriber: arphaman. Remove `vset_tuple.c`. Adjust test case under `vset-index-out-of-range.c` since the suffix is fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

pcwang-thead added a comment. In D70401#4411560 , @david-sawatzke wrote: > Thank you for the reply, I've compiled this with the most recent patch and > also didn't see a problem (but can't get it running with rustc). Building the > .ll with the older pa

[PATCH] D152078: [10/11][Clang][RISCV] Expand all variants for vget on tuple types

eopXD updated this revision to Diff 530361. eopXD added a comment. Remove `vget_tuple.c`. The test cases are collected into `vget.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152078/new/ https://reviews.llvm.org/D152078 Files: clang/include

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. Hi @PiotrZSL, I have made the requested changes. If everything looks good to you would you mind committing this patch for me as I don't have commit access to the repository. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

rsmith added a comment. I have a concern with the name of this builtin. People are going to assume it produces a nondeterministic value, and use it for seeding random number generators and similar, and will be surprised when the value produced is actually deterministic, and, worse, might leak i

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 530360. felix642 added a comment. Updated documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-tidy/readability/ContainerDa

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

zixuan-wu added inline comments. Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:26 +// CHECK-LABEL: entry +// CHECK: [[A:%.*]] = alloca double, align 8 +// CHECK: store double [[X:%.*]], ptr [[A]], align 8 ManuelJBrito wrote: > zixuan-wu wrote:

[clang] abe7ef6 - Make test more flexible for platforms that may emit extra arguments.

Author: Douglas Yung Date: 2023-06-11T17:55:18-07:00 New Revision: abe7ef60957f9d7e1b0fca4f59b4d256a798ba90 URL: https://github.com/llvm/llvm-project/commit/abe7ef60957f9d7e1b0fca4f59b4d256a798ba90 DIFF: https://github.com/llvm/llvm-project/commit/abe7ef60957f9d7e1b0fca4f59b4d256a798ba90.diff

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter added a comment. Thanks, fixed the first false positive example you gave. Let me think about the second example in your most recent post: char c = '\n'; using Size = int; Size size = 10U; std::string str2(c, size); This is my newly added case `swapped4`, where one of my original

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 530349. ccotter added a comment. - Exclude false positive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/bugprone/StringConstru

[PATCH] D152443: Add operator style options to clang-format

KitsuneAlex updated this revision to Diff 530348. KitsuneAlex marked 2 inline comments as done. KitsuneAlex added a comment. Fix broken style in TokenAnnotator.cpp. I don't know how i keep missing these, trying to get better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 63bd6d9 - [Driver] Default to -fxray-function-index

Author: Fangrui Song Date: 2023-06-11T15:38:13-07:00 New Revision: 63bd6d9e644335c8138a59281aafbf65a82fc47a URL: https://github.com/llvm/llvm-project/commit/63bd6d9e644335c8138a59281aafbf65a82fc47a DIFF: https://github.com/llvm/llvm-project/commit/63bd6d9e644335c8138a59281aafbf65a82fc47a.diff

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2219 defm xray_function_index : BoolFOption<"xray-function-index", - CodeGenOpts<"XRayOmitFunctionIndex">, DefaultTrue, - NegFlag, DefaultFalse, + NegFlaghttps://reviews.llvm.org/D145848/new/ ht

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

MaskRay added a comment. > This option has undergone several refactorings and got inverted along the > way. The XRayOmitFunctionIndex flag governs codegen behavior, *omitting* > "xray_fn_idx" section if it is set. But the command-line flag behavior was > not adjusted at the time. Right now it's

[clang] 849f1dd - [XRay] Rename XRayOmitFunctionIndex to XRayFunctionIndex

Author: Fangrui Song Date: 2023-06-11T15:27:22-07:00 New Revision: 849f1dd15e92fda2b83dbb6144e6b28b2cb946e0 URL: https://github.com/llvm/llvm-project/commit/849f1dd15e92fda2b83dbb6144e6b28b2cb946e0 DIFF: https://github.com/llvm/llvm-project/commit/849f1dd15e92fda2b83dbb6144e6b28b2cb946e0.diff

[PATCH] D152443: Add operator style options to clang-format

KitsuneAlex updated this revision to Diff 530346. KitsuneAlex marked 4 inline comments as done. KitsuneAlex added a comment. Added missing test case for default operator declarations as requested, as well as blank lines between the blocks inside the test functions as visual separators. Reposito

[PATCH] D152443: Add operator style options to clang-format

KitsuneAlex updated this revision to Diff 530343. KitsuneAlex added a comment. Revamped the formatting logic again and added the requested unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ https://reviews.llvm.org/D152443 Files

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

nlopes added inline comments. Comment at: llvm/lib/Target/X86/X86InstCombineIntrinsic.cpp:3102-3105 case Intrinsic::x86_sse4a_extrqi: case Intrinsic::x86_sse4a_insertq: case Intrinsic::x86_sse4a_insertqi: +PoisonElts.setHighBits(VWidth / 2); this cha

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

aaronpuchert added a comment. That's a tough one. The change seems to be correct, and makes more patterns visible. Of course I wonder how it comes that we see calls of a function pointer with a uniquely determined value, as that would seem like obfuscation. Maybe you can show an example how thi

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay added a comment. This is a kinda odd case. Normally we should enable the option in the driver when the feature actually works. However, `Triple.isMacOSX()` is allowed before the feature actually works and `compiler-rt/test/xray/lit.cfg.py` tests it. `clang/test/Driver/XRay/` is broken a

[clang] 706c442 - [CodeGen] Use DenseMapBase::lookup (NFC)

Author: Kazu Hirata Date: 2023-06-11T13:19:26-07:00 New Revision: 706c442e72320a144da642aca8c59adb5bc2c858 URL: https://github.com/llvm/llvm-project/commit/706c442e72320a144da642aca8c59adb5bc2c858 DIFF: https://github.com/llvm/llvm-project/commit/706c442e72320a144da642aca8c59adb5bc2c858.diff L

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

MaskRay added inline comments. Comment at: clang/test/CodeGen/xray-function-index.cpp:1 +// REQUIRES: x86-registered-target +// RUN: %clang_cc1 -fxray-instrument -x c++ -std=c++11 -triple x86_64-unknown-linux-gnu -S -o - %s | FileCheck %s --check-prefix

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 530328. kuganv marked 6 inline comments as done. kuganv added a comment. Updated based on the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://reviews.llvm.org/D148088 Files:

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. After I came across some of my code, where I'd really like a feature like this, I'm back at wishing to align the colons. Same as in a bit field. And when you would do that I think there would be no open issue with empty statements, right? So for my code I'd f

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

HazardyKnusperkeks added a comment. In D152443#4412069 , @KitsuneAlex wrote: > This revision of the diff changes the names of the new style options to > **SpaceAfterOperatorOverload** and **SpaceAfterOperatorCall**, which > clarifies their scope a lot

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

ManuelJBrito updated this revision to Diff 530321. ManuelJBrito added a comment. Completely drop alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152547/new/ https://reviews.llvm.org/D152547 Files: clang/test/CodeGen/builtins-nondetermin

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; PiotrZSL wrote: > isuckatcs wrote: > > isuckatcs wrote: > > > P

[clang] c6e065e - [Driver] Simplify xray options

Author: Fangrui Song Date: 2023-06-11T12:03:08-07:00 New Revision: c6e065ef22c29a341dcc764f8f6ed9ab5ec1c57a URL: https://github.com/llvm/llvm-project/commit/c6e065ef22c29a341dcc764f8f6ed9ab5ec1c57a DIFF: https://github.com/llvm/llvm-project/commit/c6e065ef22c29a341dcc764f8f6ed9ab5ec1c57a.diff

[clang] d25992e - [Driver] Simplify -fxray-instrument handling

Author: Fangrui Song Date: 2023-06-11T11:19:02-07:00 New Revision: d25992e70160dafcde4809bf97884e9dacd5058f URL: https://github.com/llvm/llvm-project/commit/d25992e70160dafcde4809bf97884e9dacd5058f DIFF: https://github.com/llvm/llvm-project/commit/d25992e70160dafcde4809bf97884e9dacd5058f.diff

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Driver/Options.td:2303 + Group, Flags<[NoXarchOption, CC1Option, CoreOption]>, + HelpText<"Set the maximum number of source lines to

[clang] ca4bb8d - [Driver] Place -ffixed-r19 and some -m* options in m_Group

Author: Fangrui Song Date: 2023-06-11T10:06:39-07:00 New Revision: ca4bb8d8820ab5c15a4700780651dd001662b22f URL: https://github.com/llvm/llvm-project/commit/ca4bb8d8820ab5c15a4700780651dd001662b22f DIFF: https://github.com/llvm/llvm-project/commit/ca4bb8d8820ab5c15a4700780651dd001662b22f.diff

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

MaskRay created this revision. MaskRay added reviewers: Sanitizers, vitalybuka. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Mention that -fsanitize= and -fno-sanitize= apply to check groups. - Ment

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; isuckatcs wrote: > isuckatcs wrote: > > Please cover this line w

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 530306. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Add one test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 530304. rZhBoYao added a comment. Overhaul for `dr25xx.cpp`. For each test case, tried to support as many language modes as possible. Not sure what those `-triple x86_64-unknown-unknown` are for? I leave them there nonetheless. `-Wdeprecated-literal-operat

[clang] c8c28ac - [Driver] Place -mharden-sls= in m_Group

Author: Fangrui Song Date: 2023-06-11T08:59:42-07:00 New Revision: c8c28ac5caf875771f9a424e46255948004cbeab URL: https://github.com/llvm/llvm-project/commit/c8c28ac5caf875771f9a424e46255948004cbeab DIFF: https://github.com/llvm/llvm-project/commit/c8c28ac5caf875771f9a424e46255948004cbeab.diff

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 530303. KitsuneAlex marked 2 inline comments as done. KitsuneAlex removed reviewers: lattner, craig.topper, RKSimon, respindola, rymiel, owenpan. KitsuneAlex added a comment. Herald added reviewers: rymiel, owenpan. This revision of the diff changes the n

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGdaac014fec42: [clang-tidy] Check functions called from catch blocks (authored by denizevrenci). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152330/new/ ht

[clang-tools-extra] daac014 - [clang-tidy] Check functions called from catch blocks

Author: Deniz Evrenci Date: 2023-06-11T16:40:29+01:00 New Revision: daac014fec427eda305f93da7891c0122a161bb3 URL: https://github.com/llvm/llvm-project/commit/daac014fec427eda305f93da7891c0122a161bb3 DIFF: https://github.com/llvm/llvm-project/commit/daac014fec427eda305f93da7891c0122a161bb3.diff

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:2 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify -Wdeprecated-literal-operator +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify -Wdeprecated -

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

denizevrenci updated this revision to Diff 530296. denizevrenci added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152330/new/ https://reviews.llvm.org/D152330 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyze

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal added a comment. I left my comment at https://github.com/llvm/llvm-project/issues/55019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152435/new/ https://reviews.llvm.org/D152435 ___ cfe-commits

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 530292. rZhBoYao added a comment. Addressed comments. Thanks for letting me know how to structure tests for DRs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. I run into false positive with this example: using UInt8 = unsigned char; UInt8 size = 5U; std::string str2(size, 'x'); // warning: string constructor arguments are proba

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal added a comment. In D152436#4408811 , @balazske wrote: > In D152436#4408301 , @steakhal > wrote: > >> I looked at the TPs, and if the violation was introduced by an assumption >> (instead of an assignme

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

ilammy updated this revision to Diff 530285. ilammy added a comment. Addressing feedback by @MaskRay: - Moved `// REQUIRES:` directive to the top of the test file - Replaced legacy `-target` option with proper `--target` in tests - Also rebased on updated trunk CHANGES SINCE LAST ACTION http

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

ilammy updated this revision to Diff 530284. ilammy added a comment. Addressing feedback by @MaskRay: - Moved `// REQUIRES:` directive to the top of the test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145848/new/ https://reviews.llvm.org/D145848 Files: clang/include/clang/Dr

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

nridge added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:38 + if (const auto *TD = dyn_cast(Decls[0])) { +return Ctx.getTypeDeclType(TD).getTypePtr(); + } I wanted to call out the change on this line which is easy to overlook