[jira] [Comment Edited] (FLINK-31570) Remove outdated versions

2023-04-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707787#comment-17707787 ] Matthias Pohl edited comment on FLINK-31570 at 4/3/23 6:43 AM: ---

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #227: [FLINK-31623] Fix DataStreamUtils#sample to uniform sampling.

2023-04-02 Thread via GitHub
zhipeng93 commented on code in PR #227: URL: https://github.com/apache/flink-ml/pull/227#discussion_r1155538452 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/DataStreamUtils.java: ## @@ -288,13 +291,20 @@ public static DataStream aggregate( public st

[jira] [Commented] (FLINK-31570) Remove outdated versions

2023-04-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707787#comment-17707787 ] Matthias Pohl commented on FLINK-31570: --- What's the state of this issue? Looks lik

[jira] [Commented] (FLINK-30909) Running HA (hashmap, sync) end-to-end test

2023-04-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707785#comment-17707785 ] Matthias Pohl commented on FLINK-30909: --- https://dev.azure.com/apache-flink/apache

[jira] [Resolved] (FLINK-31189) Allow special handle of less frequent values in StringIndexer

2023-04-02 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang resolved FLINK-31189. --- Resolution: Fixed Resolved via 560532d99c4330949d4da2c94d0e5228bdfbc9cd on master > Allow s

[GitHub] [flink-ml] zhipeng93 merged pull request #221: [FLINK-31189] Add HasMaxIndexNum param to StringIndexer

2023-04-02 Thread via GitHub
zhipeng93 merged PR #221: URL: https://github.com/apache/flink-ml/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] reswqa commented on pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-04-02 Thread via GitHub
reswqa commented on PR #22084: URL: https://github.com/apache/flink/pull/22084#issuecomment-1493721859 FYI:If there are no other concerns, I will merge this PR tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] yangjf2019 commented on pull request #22274: [FLINK-31617] Upgrade the SnakeYaml Maven dependency

2023-04-02 Thread via GitHub
yangjf2019 commented on PR #22274: URL: https://github.com/apache/flink/pull/22274#issuecomment-1493715710 @MartijnVisser Thanks for your review, and i will update as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Assigned] (FLINK-31674) [JUnit5 Migration] Module: flink-table-planner (BatchAbstractTestBase)

2023-04-02 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31674: -- Assignee: Ryan Skraba > [JUnit5 Migration] Module: flink-table-planner (BatchAbstractTestBase

[jira] [Closed] (FLINK-31690) The current key is not set for KeyedCoProcessOperator

2023-04-02 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-31690. --- Fix Version/s: 1.16.2 1.18.0 1.17.1 Resolution: Fixed Fixed in:

[GitHub] [flink] dianfu closed pull request #22323: [FLINK-31690][python] Fix KeyedCoProcessFunction to set the current k…

2023-04-02 Thread via GitHub
dianfu closed pull request #22323: [FLINK-31690][python] Fix KeyedCoProcessFunction to set the current k… URL: https://github.com/apache/flink/pull/22323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Closed] (FLINK-31688) Broken links in docs for Azure Table Storage

2023-04-02 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31688. -- Fix Version/s: 1.18.0 Resolution: Fixed master(1.18) via 6101ad313be78a658cc25487b9d3976252625f

[GitHub] [flink] reswqa merged pull request #22321: [FLINK-31688][docs] Fix the broken links in docs for Azure Table Storage

2023-04-02 Thread via GitHub
reswqa merged PR #22321: URL: https://github.com/apache/flink/pull/22321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] flinkbot commented on pull request #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-04-02 Thread via GitHub
flinkbot commented on PR #22324: URL: https://github.com/apache/flink/pull/22324#issuecomment-1493647373 ## CI report: * 8a534fe42ef69bc595fe9b87f1de924fdc173815 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31691) Add MAP_FROM_ENTRIES supported in SQL & Table API

2023-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31691: --- Labels: pull-request-available (was: ) > Add MAP_FROM_ENTRIES supported in SQL & Table API

[GitHub] [flink] liuyongvs opened a new pull request, #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-04-02 Thread via GitHub
liuyongvs opened a new pull request, #22324: URL: https://github.com/apache/flink/pull/22324 - What is the purpose of the change This is an implementation of MAP_FROM_ENTRIES - Brief change log MAP_FROM_ENTRIES for Table API and SQL ``` map_from_entries(map) - Retur

[jira] [Updated] (FLINK-31691) Add MAP_FROM_ENTRIES supported in SQL & Table API

2023-04-02 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated FLINK-31691: - Description: map_from_entries(map) - Returns a map created from an arrays of row with two fields. Note

[GitHub] [flink] Samrat002 commented on pull request #22308: [FLINK-31518][Runtime / REST] Fix StandaloneHaServices#getClusterRestEndpointLeaderRetreiver to return correct rest port

2023-04-02 Thread via GitHub
Samrat002 commented on PR #22308: URL: https://github.com/apache/flink/pull/22308#issuecomment-1493618741 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-31691) Add MAP_FROM_ENTRIES supported in SQL & Table API

2023-04-02 Thread jackylau (Jira)
jackylau created FLINK-31691: Summary: Add MAP_FROM_ENTRIES supported in SQL & Table API Key: FLINK-31691 URL: https://issues.apache.org/jira/browse/FLINK-31691 Project: Flink Issue Type: Improve

[jira] [Commented] (FLINK-31602) Add ARRAY_POSITION supported in SQL & Table API

2023-04-02 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707755#comment-17707755 ] jackylau commented on FLINK-31602: -- Merged to master as [a1e4ba2a0ac39a667b9c3169f2542

[jira] [Comment Edited] (FLINK-31602) Add ARRAY_POSITION supported in SQL & Table API

2023-04-02 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707755#comment-17707755 ] jackylau edited comment on FLINK-31602 at 4/3/23 4:06 AM: -- Merg

[jira] [Closed] (FLINK-31602) Add ARRAY_POSITION supported in SQL & Table API

2023-04-02 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau closed FLINK-31602. Resolution: Fixed > Add ARRAY_POSITION supported in SQL & Table API >

[GitHub] [flink] flinkbot commented on pull request #22323: [FLINK-31690][python] Fix KeyedCoProcessFunction to set the current k…

2023-04-02 Thread via GitHub
flinkbot commented on PR #22323: URL: https://github.com/apache/flink/pull/22323#issuecomment-1493609975 ## CI report: * e1e4b7235fbdcc5390e5db33ad6b6c69cf313b8d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31690) The current key is not set for KeyedCoProcessOperator

2023-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31690: --- Labels: pull-request-available (was: ) > The current key is not set for KeyedCoProcessOpera

[GitHub] [flink] dianfu opened a new pull request, #22323: [FLINK-31690][python] Fix KeyedCoProcessFunction to set the current k…

2023-04-02 Thread via GitHub
dianfu opened a new pull request, #22323: URL: https://github.com/apache/flink/pull/22323 …ey into the context ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we av

[GitHub] [flink] flinkbot commented on pull request #22322: [BP-1.16][FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase

2023-04-02 Thread via GitHub
flinkbot commented on PR #22322: URL: https://github.com/apache/flink/pull/22322#issuecomment-1493594228 ## CI report: * b84af1fbef1bb8d057a36a5ef90a585047dd89ce UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #227: [FLINK-31623] Fix DataStreamUtils#sample to uniform sampling.

2023-04-02 Thread via GitHub
Fanoid commented on code in PR #227: URL: https://github.com/apache/flink-ml/pull/227#discussion_r1155451901 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/DataStreamUtils.java: ## @@ -280,6 +280,15 @@ public static DataStream aggregate( * This metho

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-04-02 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1493592946 @Aitozi Sorry to pin you, all your comments have been addressed, can you help to re-check it ? thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] xintongsong closed pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase

2023-04-02 Thread via GitHub
xintongsong closed pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase URL: https://github.com/apache/flink/pull/22311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [flink] xintongsong commented on a diff in pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase

2023-04-02 Thread via GitHub
xintongsong commented on code in PR #22311: URL: https://github.com/apache/flink/pull/22311#discussion_r1155446163 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriverTest.java: ## @@ -184,6 +184,18 @@ void testOnPodDeleted() throws Excep

[jira] [Commented] (FLINK-31689) Filesystem sink fails when parallelism of compactor operator changed

2023-04-02 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707742#comment-17707742 ] luoyuxia commented on FLINK-31689: -- Please remember the state is not compatible as you

[GitHub] [flink] FangYongs commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-02 Thread via GitHub
FangYongs commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155438551 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java: ## @@ -18,34 +18,67 @@ package org.apache.flink.table.jdbc;

[jira] [Created] (FLINK-31690) The current key is not set for KeyedCoProcessOperator

2023-04-02 Thread Dian Fu (Jira)
Dian Fu created FLINK-31690: --- Summary: The current key is not set for KeyedCoProcessOperator Key: FLINK-31690 URL: https://issues.apache.org/jira/browse/FLINK-31690 Project: Flink Issue Type: Bug

[GitHub] [flink] BoYiZhang commented on pull request #22204: [Flink 31170] [docs]The spelling error of the document word causes sq…

2023-04-02 Thread via GitHub
BoYiZhang commented on PR #22204: URL: https://github.com/apache/flink/pull/22204#issuecomment-1493542108 This is my first PR, please help me find out where it doesn't meet the regulations ... @reswqa @healchow -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] libenchao commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-02 Thread via GitHub
libenchao commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155415681 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java: ## @@ -18,34 +18,67 @@ package org.apache.flink.table.jdbc;

[GitHub] [flink] libenchao commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-02 Thread via GitHub
libenchao commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155415681 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java: ## @@ -18,34 +18,67 @@ package org.apache.flink.table.jdbc;

[GitHub] [flink-connector-kafka] paul8263 commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…

2023-04-02 Thread via GitHub
paul8263 commented on PR #5: URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1493499385 Hi @tzulitai , Could you please help approve the workflow? It seems that the CI process won't run anymore. I tried pushing the same commit to both this project and

[jira] [Updated] (FLINK-31108) Use StreamARN for API calls in Kinesis Connector

2023-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31108: --- Labels: pull-request-available (was: ) > Use StreamARN for API calls in Kinesis Connector >

[GitHub] [flink-connector-aws] hlteoh37 opened a new pull request, #64: [FLINK-31108][Connectors/Kinesis] Use Stream ARN instead of Stream Na…

2023-04-02 Thread via GitHub
hlteoh37 opened a new pull request, #64: URL: https://github.com/apache/flink-connector-aws/pull/64 …me for Kinesis API calls ## Purpose of the change Modifies Kinesis Source to use Stream ARN instead of Stream name. ## Verifying this change This change added tests and can

[GitHub] [flink-kubernetes-operator] mateczagany commented on a diff in pull request #558: [FLINK-31303] Expose Flink application resource usage via metrics and status

2023-04-02 Thread via GitHub
mateczagany commented on code in PR #558: URL: https://github.com/apache/flink-kubernetes-operator/pull/558#discussion_r1155350156 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -627,14 +637,42 @@ public

[jira] [Created] (FLINK-31689) Filesystem sink fails when parallelism of compactor operator changed

2023-04-02 Thread jirawech.s (Jira)
jirawech.s created FLINK-31689: -- Summary: Filesystem sink fails when parallelism of compactor operator changed Key: FLINK-31689 URL: https://issues.apache.org/jira/browse/FLINK-31689 Project: Flink

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-04-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707680#comment-17707680 ] Qingsheng Ren commented on FLINK-28440: --- Redirected to here from FLINK-30107: htt

[jira] [Commented] (FLINK-26974) Python EmbeddedThreadDependencyTests.test_add_python_file failed on azure

2023-04-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707679#comment-17707679 ] Qingsheng Ren commented on FLINK-26974: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-30299) TaskManagerRunnerTest fails with 239 exit code (i.e. FatalExitExceptionHandler was called)

2023-04-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707678#comment-17707678 ] Qingsheng Ren commented on FLINK-30299: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] flinkbot commented on pull request #22321: [FLINK-31688][docs] Fix the broken links in docs for Azure Table Storage

2023-04-02 Thread via GitHub
flinkbot commented on PR #22321: URL: https://github.com/apache/flink/pull/22321#issuecomment-1493343603 ## CI report: * a7cd7d1f5b2fbf437caec2f52a00dc72e72b05b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31688) Broken links in docs for Azure Table Storage

2023-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31688: --- Labels: pull-request-available (was: ) > Broken links in docs for Azure Table Storage > ---

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22321: [FLINK-31688][docs] Fix the broken links in docs for Azure Table Storage

2023-04-02 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22321: URL: https://github.com/apache/flink/pull/22321 ## What is the purpose of the change *Fix the broken links in docs for Azure Table Storage* ## Brief change log - *Fix the broken links in docs for Azure Table St

[GitHub] [flink] flinkbot commented on pull request #22320: [FLINK-31664][Table SQL/API] Add ARRAY_INTERSECT supported in SQL & Table API

2023-04-02 Thread via GitHub
flinkbot commented on PR #22320: URL: https://github.com/apache/flink/pull/22320#issuecomment-1493338855 ## CI report: * f86f9fd01d402441cdacd977f71f52461e10fa45 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31688) Broken links in docs for Azure Table Storage

2023-04-02 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-31688: -- Description: The doc page of https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/connector

[jira] [Assigned] (FLINK-31688) Broken links in docs for Azure Table Storage

2023-04-02 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-31688: - Assignee: Yuxin Tan > Broken links in docs for Azure Table Storage > --

[jira] [Created] (FLINK-31688) Broken links in docs for Azure Table Storage

2023-04-02 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-31688: - Summary: Broken links in docs for Azure Table Storage Key: FLINK-31688 URL: https://issues.apache.org/jira/browse/FLINK-31688 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-31664) Add ARRAY_INTERSECT supported in SQL & Table API

2023-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31664: --- Labels: pull-request-available (was: ) > Add ARRAY_INTERSECT supported in SQL & Table API >

[GitHub] [flink] zzzzzzzs opened a new pull request, #22320: [FLINK-31664][Table SQL/API] Add ARRAY_INTERSECT supported in SQL & Table API

2023-04-02 Thread via GitHub
zzzs opened a new pull request, #22320: URL: https://github.com/apache/flink/pull/22320 ## What is the purpose of the change Add `array_intersect(array1, array2)` SQL function. - `array1`: An ARRAY of any type with comparable elements. - `array2`: n ARRAY of eleme

[GitHub] [flink] FangYongs commented on pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-02 Thread via GitHub
FangYongs commented on PR #22289: URL: https://github.com/apache/flink/pull/22289#issuecomment-1493319117 Thanks @libenchao , I have rebased master and updated this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink] Aitozi commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

2023-04-02 Thread via GitHub
Aitozi commented on code in PR #22301: URL: https://github.com/apache/flink/pull/22301#discussion_r1155295984 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java: ## @@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #558: [FLINK-31303] Expose Flink application resource usage via metrics and status

2023-04-02 Thread via GitHub
mbalassi commented on code in PR #558: URL: https://github.com/apache/flink-kubernetes-operator/pull/558#discussion_r1155274830 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -627,14 +637,42 @@ public Map

[GitHub] [flink] Aitozi commented on a diff in pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-04-02 Thread via GitHub
Aitozi commented on code in PR #22179: URL: https://github.com/apache/flink/pull/22179#discussion_r1154263645 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowCatalogs.java: ## @@ -28,15 +31,61 @@ import java.util.Collections; import java.