[libvirt] Question about more finer access control permission on libvirt

2008-05-08 Thread Atsushi SAKAI
Hi, Dan I have a question of libvirt with Polkit. Currently, the libvirt w/ Polkit has 2 access control permissions. (Read Only and Read Write) Have you planned to expand the access control more finer? In my use case, Policy should define by domain, operation, operator. Of course, operator is alr

Re: [libvirt] [PATCH] Implement autostart commands for xen

2008-05-08 Thread Cole Robinson
Cole Robinson wrote: > The attached patch implements the domain autostart commands for > xen. The xen sexpr (since at least 3.0.4 = 1.5 years) has a > on_xend_start field which can be used to autostart a domain. > Updated patch with fixes Dan recommended. Thanks, Cole diff --git a/src/xen_unif

Re: [libvirt] PATCH: Add bus attribute for Xen driver

2008-05-08 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > To complement soren's patch adding a bus attribute to the QEMU driver, > here is a minimal patch adding bus attribute to the Xen drivers. It merely > adds it on when generating the XML. It isn't making any attempt to interpret > it when creating a V

Re: [libvirt] [PATCH] avoid one more ctype vs. sign-extension problem

2008-05-08 Thread Daniel P. Berrange
On Thu, May 08, 2008 at 04:44:38PM +0200, Jim Meyering wrote: > This change demonstrates that the new syntax-check rule's > regexp can be improved. It missed the unsafe tolower use, > since there was already a to_uchar use on that line. ACK Dan -- |: Red Hat, Engineering, Boston -o- http://

[libvirt] [PATCH] avoid one more ctype vs. sign-extension problem

2008-05-08 Thread Jim Meyering
This change demonstrates that the new syntax-check rule's regexp can be improved. It missed the unsafe tolower use, since there was already a to_uchar use on that line. >From 5fc8de9825215e28773f2230ac6c1e1b3d724602 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Thu, 8 May

[libvirt] [PATCH] sytnax-check: add a check for risky ctype macro use

2008-05-08 Thread Jim Meyering
A follow-up to the patch that introduced to_uchar. This rule will ensure no new offenders sneak back in. >From d141d07c7e21cc228fe46d90f21dd86685d7e424 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Thu, 8 May 2008 16:18:13 +0200 Subject: [PATCH] sytnax-check: add a check fo

Re: [libvirt] [PATCH] add "const" to file-scoped statics

2008-05-08 Thread Daniel P. Berrange
On Thu, May 08, 2008 at 04:40:11PM +0200, Jim Meyering wrote: > > >From fed1a1abfd2b9ece7bd8e44aae13de91eaad4f5d Mon Sep 17 00:00:00 2001 > From: Jim Meyering <[EMAIL PROTECTED]> > Date: Wed, 7 May 2008 23:12:13 +0200 > Subject: [PATCH] add "const" to file-scoped statics > > These were relatively

[libvirt] [PATCH] add "const" to file-scoped statics

2008-05-08 Thread Jim Meyering
>From fed1a1abfd2b9ece7bd8e44aae13de91eaad4f5d Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Wed, 7 May 2008 23:12:13 +0200 Subject: [PATCH] add "const" to file-scoped statics These were relatively new additions to the list from here: nm src/*.o|grep ' D '. This is another

Re: [libvirt] Re-write the domain XML reference docs

2008-05-08 Thread Daniel Veillard
On Wed, May 07, 2008 at 01:01:11AM +0100, Daniel P. Berrange wrote: > The current domain XML format documentation reference on the website is > very out of date and not well structured since we organically added random > bits to it as we wrote drivers. This patch is starting from a clean slate. > I

Re: [libvirt] [PATCH] Implement autostart commands for xen

2008-05-08 Thread Daniel P. Berrange
On Wed, May 07, 2008 at 04:21:25PM -0400, Cole Robinson wrote: > +int > +xenDaemonDomainGetAutostart(virDomainPtr domain, > +int *autostart) > +{ > +struct sexpr *root; > +const char *tmp; > + > +if ((domain == NULL) || (domain->conn == NULL) || (domain->nam

Re: [libvirt] [PATCH] Fix PolicyKit.conf example docs

2008-05-08 Thread Daniel P. Berrange
On Wed, May 07, 2008 at 04:29:40PM -0400, Cole Robinson wrote: > The current docs showing a possible PolicyKit.conf with the example: > > > > > > With PolicyKit-0.6-2.fc8, polkit-config-file-validate complains > about this format. 'man PolicyKit.conf' gives a similar example > with the

Re: [libvirt] [PATCH] Implement autostart commands for xen

2008-05-08 Thread Daniel P. Berrange
On Wed, May 07, 2008 at 04:21:25PM -0400, Cole Robinson wrote: > The attached patch implements the domain autostart commands for > xen. The xen sexpr (since at least 3.0.4 = 1.5 years) has a > on_xend_start field which can be used to autostart a domain. > > A couple things: > > 1) This works on

Re: [libvirt] [PATCH] Implement autostart commands for xen

2008-05-08 Thread Daniel P. Berrange
On Thu, May 08, 2008 at 06:42:13PM +0900, S.Sakamoto wrote: > > The attached patch implements the domain autostart commands for > > xen. The xen sexpr (since at least 3.0.4 = 1.5 years) has a > > on_xend_start field which can be used to autostart a domain. > > > It is a good patch for me. > It mo

Re: [libvirt] [PATCH] Implement autostart commands for xen

2008-05-08 Thread Atsushi SAKAI
Hi, Cole Cole Robinson <[EMAIL PROTECTED]> wrote: > 1) This works on a running guest, but will only show the >sexpr changes after the guest is restarted. Just curious >if there is any better way to do this? This is current Xen behavior. If you need to work as you hope, you should change

Re: [libvirt] [PATCH] Implement autostart commands for xen

2008-05-08 Thread S.Sakamoto
> The attached patch implements the domain autostart commands for > xen. The xen sexpr (since at least 3.0.4 = 1.5 years) has a > on_xend_start field which can be used to autostart a domain. > It is a good patch for me. It moved without a problem when I tested it. By the way, I have a question.

[libvirt] Re: [Libvir] [PATCH] lxc: loop in tty forwarding process

2008-05-08 Thread Daniel Veillard
On Wed, May 07, 2008 at 12:47:40PM -0700, Dave Leskovec wrote: > Daniel Veillard wrote: > > On Tue, May 06, 2008 at 12:51:08AM -0700, Dave Leskovec wrote: > [...] > >> -close(vm->parentTty); > >> +//close(vm->parentTty); > >> close(vm->containerTtyFd); > > > > if we really don't nee