Re: [libvirt] PATCH: Misc fixes to events code

2008-11-07 Thread Ben Guthro
Daniel P. Berrange wrote on 11/04/2008 05:05 PM: > Well lets just start with STARTED/STOPPED from xenstore, and possibly > try ADDED/REMOVED using inotify on /etc/xen or /var/lib/xend/domains. > These are what virt-manager cares about the most. The others are just > a nice-to-have. Perhaps I just

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Ben Guthro
These look good to me +1 Daniel P. Berrange wrote on 11/04/2008 02:56 PM: > I'm trying out the new events code with virt-manager and stumbled on some > minor bugs > > - The python binding forgot to call LIBVIRT_BEGIN_ALLOW_THREADS, >LIBVIRT_END_ALLOW_THREADS, LIBVIRT_ENSURE_THREAD_STATE or >

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Daniel P. Berrange
On Tue, Nov 04, 2008 at 04:51:27PM -0500, Ben Guthro wrote: > > > Daniel P. Berrange wrote on 11/04/2008 04:42 PM: > > > Then there is XenAPI in Xen >= 3.1.0. We don't currently use XenAPI > > at all, and I'm not up2date on its level of functionality, but in > > the original scope it was intende

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Ben Guthro
Daniel P. Berrange wrote on 11/04/2008 04:42 PM: > Then there is XenAPI in Xen >= 3.1.0. We don't currently use XenAPI > at all, and I'm not up2date on its level of functionality, but in > the original scope it was intended to provide full event notification > capabilities for VMs. If the XenAPI

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Daniel P. Berrange
On Tue, Nov 04, 2008 at 03:31:56PM -0500, Ben Guthro wrote: > > > Daniel P. Berrange wrote on 11/04/2008 02:56 PM: > > A couple more things I've not fixed but are on the todo list > > > > - THe QEMU driver doesn't emit the ADDED or REMOVED events for VMs > >which virt-manager requires in or

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Ben Guthro
Daniel P. Berrange wrote on 11/04/2008 02:56 PM: > A couple more things I've not fixed but are on the todo list > > - THe QEMU driver doesn't emit the ADDED or REMOVED events for VMs >which virt-manager requires in order to fully avoid polling. Not to derail this topic from your patch...bu

[libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Daniel P. Berrange
I'm trying out the new events code with virt-manager and stumbled on some minor bugs - The python binding forgot to call LIBVIRT_BEGIN_ALLOW_THREADS, LIBVIRT_END_ALLOW_THREADS, LIBVIRT_ENSURE_THREAD_STATE or LIBVIRT_RELEASE_THREAD_STATE which meant virt-manager crashed and burned in a he