Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-25 Thread Jiri Olsa
On Tue, Jul 24, 2018 at 08:20:07AM +0100, Alexander Kapshuk wrote: SNIP > > > % file1=file1; file2=file2 > > > % cmd="echo diff $file1 $file2" > > > % test -f $file2 && > > > eval $cmd || echo "Warning: Kernel ABI header at 'tools/$file1' > > > differs from latest version at '$file2'" >&2 > > > W

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-24 Thread Alexander Kapshuk
On Mon, Jul 23, 2018, 08:01 Jiri Olsa wrote: > On Fri, Jul 20, 2018 at 06:22:49PM +0300, Alexander Kapshuk wrote: > > On Fri, Jul 20, 2018 at 6:16 PM Jiri Olsa wrote: > > > > > > On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Jul 20, 2018 at 01:00:35P

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-23 Thread Jiri Olsa
On Fri, Jul 20, 2018 at 06:22:49PM +0300, Alexander Kapshuk wrote: > On Fri, Jul 20, 2018 at 6:16 PM Jiri Olsa wrote: > > > > On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Fri, Jul 20, 2018 at 01:00:35PM +0200, Jiri Olsa escreveu: > > > > The warning message in

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-20 Thread Alexander Kapshuk
On Fri, Jul 20, 2018 at 6:16 PM Jiri Olsa wrote: > > On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jul 20, 2018 at 01:00:35PM +0200, Jiri Olsa escreveu: > > > The warning message in check_w function uses wrongly > > > the $file variable instead of $file1 and

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-20 Thread Jiri Olsa
On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jul 20, 2018 at 01:00:35PM +0200, Jiri Olsa escreveu: > > The warning message in check_w function uses wrongly > > the $file variable instead of $file1 and $file2. > > Humm, > > Before: > > Warning: Kernel ABI he

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 20, 2018 at 01:00:35PM +0200, Jiri Olsa escreveu: > The warning message in check_w function uses wrongly > the $file variable instead of $file1 and $file2. Humm, Before: Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/unistd.h' differs from latest version at 'arch

[PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-20 Thread Jiri Olsa
The warning message in check_w function uses wrongly the $file variable instead of $file1 and $file2. Fixes: 582472973593 ("perf check-headers.sh: Add support to check 2 independent files") Link: http://lkml.kernel.org/n/tip-oh56ckqztoc07we7mtdph...@git.kernel.org Signed-off-by: Jiri Olsa --- t