Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-26 Thread Atchley, Scott
On Jun 26, 2014, at 12:38 PM, James Bottomley wrote: > On June 26, 2014 11:41:48 AM EDT, "Atchley, Scott" wrote: >> On Jun 26, 2014, at 10:55 AM, James Bottomley >> wrote: >> >>> On Thu, 2014-06-26 at 16:53 +0200, Bart Van Assche wrote: On 06/11/14 11:09, Sagi Grimberg wrote: > + ret

Re: help with IB_WC_MW_BIND_ERR

2014-06-26 Thread Shirley Ma
Hello Eli, Or, Do you know who can help on this? NFSoRDMA hits this error case with Mellanox ConnectX-2 HCAs. Thanks Shirley On 05/20/2014 11:55 AM, Chuck Lever wrote: > Hi- > > What does it mean when a LOCAL_INV work request fails with a > IB_WC_MW_BIND_ERR completion? > > -- > Chuck Lever >

Re: Need help with strange mlx4_core error

2014-06-26 Thread Mark Lehrer
On Feb 28, 2014, Vasiliy Tolstov wrote: > I'm update firmware to 2.7.200 (that is the latest from ftp > supermicro). Now i'm try to test it. Which type of HCA do you have? The firmware I downloaded from ftp.supermicro.com was 2.9.1000, and once I upgraded to this version from 2.7.200 I was able

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-26 Thread James Bottomley
On June 26, 2014 11:41:48 AM EDT, "Atchley, Scott" wrote: >On Jun 26, 2014, at 10:55 AM, James Bottomley > wrote: > >> On Thu, 2014-06-26 at 16:53 +0200, Bart Van Assche wrote: >>> On 06/11/14 11:09, Sagi Grimberg wrote: + return xfer_len + (xfer_len >> ilog2(sector_size)) * 8; >>> >>> So

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-26 Thread Atchley, Scott
On Jun 26, 2014, at 10:55 AM, James Bottomley wrote: > On Thu, 2014-06-26 at 16:53 +0200, Bart Van Assche wrote: >> On 06/11/14 11:09, Sagi Grimberg wrote: >>> + return xfer_len + (xfer_len >> ilog2(sector_size)) * 8; >> >> Sorry that I just noticed this now, but why is a shift-right and ilog

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-26 Thread James Bottomley
On Thu, 2014-06-26 at 16:53 +0200, Bart Van Assche wrote: > On 06/11/14 11:09, Sagi Grimberg wrote: > > + return xfer_len + (xfer_len >> ilog2(sector_size)) * 8; > > Sorry that I just noticed this now, but why is a shift-right and ilog2() > used in the above expression instead of just dividing t

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-26 Thread Bart Van Assche
On 06/11/14 11:09, Sagi Grimberg wrote: > + return xfer_len + (xfer_len >> ilog2(sector_size)) * 8; Sorry that I just noticed this now, but why is a shift-right and ilog2() used in the above expression instead of just dividing the transfer length by the sector size ? Thanks, Bart. -- To uns

RE: [PATCH 0/2] Fixes skb leak and connection clean up on ARP error

2014-06-26 Thread Steve Wise
Hey Roland, These two are also good bug fixes for 3.16-rc3. Thanks, Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH opensm] osm_drop_mgr.c: Add missing CR at end of log message in drop_mgr_check_node

2014-06-26 Thread Hal Rosenstock
From: Vladimir Koushnir Signed-off-by: Vladimir Koushnir Signed-off-by: Hal Rosenstock --- opensm/osm_drop_mgr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/opensm/osm_drop_mgr.c b/opensm/osm_drop_mgr.c index 7eb174c..66c85b9 100644 --- a/opensm/osm_drop_mgr.c +++

[PATCH opensm] osm_state_mgr.c: Improve error flow with wrong LIDs

2014-06-26 Thread Hal Rosenstock
From: Vladimir Koushnir In case of errors, setting NULL in the entry of port_lid_tbl should be done only for LIDs assigned by lid manager in order to avoid unnecessary expansion of port_lid_tbl and further incorrect max_lid calculation that is based on port_lid_tbl vector size. Signed-off-by: Vl

Re: [PATCHv1 2/4] RDMA/mlx5: add missing padding at end of struct mlx5_ib_create_srq

2014-06-26 Thread Eli Cohen
On Thu, Jun 05, 2014 at 09:38:03AM +0200, Yann Droneaud wrote: > Le dimanche 11 mai 2014 à 10:12 +0300, Eli Cohen a écrit : > > Acked by: Eli Cohen > > This Acked-by: tag was not applied on commit 43bc889380c2, > in for-next branch (HEAD at ca846ce98ca3). > > PS: Eli, you've made a typo in your

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2014-06-26 Thread Eli Cohen
On Fri, Jun 20, 2014 at 08:58:32PM +0300, Dan Carpenter wrote: >976 >977err_create: >978if (qp->create_type == MLX5_QP_USER) >979destroy_qp_user(pd, qp); > ^^^ > But we dereference it inside

Re: mlx4 - query regarding PF VF functionality division

2014-06-26 Thread Bob Biloxi
> I see, by the nature of the mlx4 SRIOV architecture under which > there's no dedicated/separated PF vs VF driver, this is indeed a > non-trivial task, need to think how to make it easier for you Thanks for considering. It would be really helpful. I actually appreciate the mlx4 architecture wherei