Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18958
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134780644
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -505,18 +511,12 @@ public void filterNullsInColumn(i
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134780277
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -95,19 +81,32 @@ public void close() {
priv
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134779475
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +306,69 @@ public void update(int ordinal, O
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134399222
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,69 @@ public void update(int ordinal, Objec
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134396135
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,70 @@ public void update(int ordinal, O
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134393145
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,70 @@ public void update(int ordinal, Obje
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134232538
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -970,30 +458,14 @@ public final int appendStruct(bool
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134208734
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -0,0 +1,653 @@
+/*
+ * Licensed to t
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134148287
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -970,30 +458,14 @@ public final int appendStruct(boolean
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134147099
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,70 @@ public void update(int ordinal, O
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134146811
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -970,30 +458,14 @@ public final int appendStruct(bool
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134145753
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,69 @@ public void update(int ordinal, Objec
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134115047
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,69 @@ public void update(int ordinal, O
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114861
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnVector.java
---
@@ -0,0 +1,599 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114822
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,69 @@ public void update(int ordinal, O
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114762
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -1049,43 +511,9 @@ public ColumnVector getDictionaryI
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114641
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -281,62 +255,14 @@ public Object get(int ordinal, Dat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114520
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -172,20 +177,26 @@ public v
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114491
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -433,7 +434,8 @@ private void read
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134114461
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -450,14 +450,13 @@ class CodegenContex
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133626997
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -505,18 +500,12 @@ public void filterNullsInColumn(int
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133622586
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -89,14 +91,23 @@ class VectorizedHashMapG
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133622350
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -89,14 +91,23 @@ class VectorizedHashMapG
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133618935
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -40,8 +39,43 @@
private long lengthData;
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133618947
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -491,6 +525,22 @@ public void loadBytes(ColumnVec
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133617360
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,73 @@ public void update(int ordinal, Obje
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133617361
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnVector.java
---
@@ -0,0 +1,599 @@
+/*
+ * Licensed to the Ap
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133579534
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -505,18 +500,12 @@ public void filterNullsInColumn
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133434818
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnVector.java
---
@@ -0,0 +1,599 @@
+/*
+ * Licensed to th
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133421918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -89,14 +91,23 @@ class VectorizedHash
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133421832
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -89,14 +91,23 @@ class VectorizedHash
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133420801
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -491,6 +525,22 @@ public void loadBytes(Colum
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133420728
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -40,8 +39,43 @@
private long lengthDat
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133419451
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnVector.java
---
@@ -0,0 +1,599 @@
+/*
+ * Licensed to th
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r133418831
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -307,64 +293,73 @@ public void update(int ordinal,
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/18958
[SPARK-21745][SQL] Refactor ColumnVector hierarchy to make ColumnVector
read-only and to introduce MutableColumnVector.
## What changes were proposed in this pull request?
This is a refacto
37 matches
Mail list logo
