re: Using coccinelle for (quick?) syntax fixing

2010-08-11 Thread matthew green
> On Thu, 12 Aug 2010, Bernd Ernesti wrote: > >>if (dev_priv == NULL) { > >>DRM_ERROR("called with no initialization\n"); > >> - DRM_SPINUNLOCK(&dev_priv->cs.cs_mutex); > ... > > Hmm, you didn't mention why you are doing that in your initial mail. > > Use of pointer after

re: Using coccinelle for (quick?) syntax fixing

2010-08-11 Thread matthew green
> On Wed, Aug 11, 2010 at 11:49:10PM +0200, Jean-Yves Migeon wrote: > [..] > > > I will commit the attached patch on Saturday, unless someone objects. > > > [..] > > > Index: external/bsd/drm/dist/shared-core/radeon_cs.c > > === >

Re: Using coccinelle for (quick?) syntax fixing

2010-08-11 Thread Hubert Feyrer
On Thu, 12 Aug 2010, Bernd Ernesti wrote: if (dev_priv == NULL) { DRM_ERROR("called with no initialization\n"); - DRM_SPINUNLOCK(&dev_priv->cs.cs_mutex); ... Hmm, you didn't mention why you are doing that in your initial mail. Use of pointer after determi

audio/video capture timestamping

2010-08-11 Thread Matthew Mondor
Hello, Since I have an old Brooktree878 card which NetBSD supports, which I successfully used in the past with custom software using bktr(4) as part of a security suite, I thought I'd give it a new life and try to convert rare VHS which were rotting in a drawer to a digital format. I tried mencod

Re: Using coccinelle for (quick?) syntax fixing

2010-08-11 Thread Bernd Ernesti
On Wed, Aug 11, 2010 at 11:49:10PM +0200, Jean-Yves Migeon wrote: [..] > I will commit the attached patch on Saturday, unless someone objects. > [..] > Index: external/bsd/drm/dist/shared-core/radeon_cs.c > === > RCS file: /cvsroot/

Re: Using coccinelle for (quick?) syntax fixing

2010-08-11 Thread Jean-Yves Migeon
On 10.08.2010 19:11, Matthias Drochner wrote: > jeanyves.mig...@free.fr said: >> But the NULL deref fixes will go in eventually, and I will probably >> ask for a pull up too ;) > > But then... > > algo = esp_algorithm_lookup(sav->alg_enc); > - if (!algo) { > + if (algo == NULL

Re: Using coccinelle for (quick?) syntax fixing

2010-08-11 Thread Jean-Yves Migeon
On 10.08.2010 19:11, Matthias Drochner wrote: > jeanyves.mig...@free.fr said: >> But the NULL deref fixes will go in eventually, and I will probably >> ask for a pull up too ;) > > But then... > > algo = esp_algorithm_lookup(sav->alg_enc); > - if (!algo) { > + if (algo == NULL