Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

2017-03-27 Thread Andrew Cooper
On 27/03/17 13:31, Jan Beulich wrote: On 27.03.17 at 14:13, wrote: >> On 27/03/17 12:28, Jan Beulich wrote: >> On 27.03.17 at 11:56, wrote: @@ -5183,6 +5184,8 @@ x86_emulate( { unsigned long zero = 0; +vcpu_must_have(clzero); >

Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

2017-03-27 Thread Jan Beulich
>>> On 27.03.17 at 14:13, wrote: > On 27/03/17 12:28, Jan Beulich wrote: > On 27.03.17 at 11:56, wrote: >>> @@ -5183,6 +5184,8 @@ x86_emulate( >>> { >>> unsigned long zero = 0; >>> >>> +vcpu_must_have(clzero); >> Hmm, wait - doesn't this break the test harn

Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

2017-03-27 Thread Andrew Cooper
On 27/03/17 12:28, Jan Beulich wrote: On 27.03.17 at 11:56, wrote: >> @@ -5183,6 +5184,8 @@ x86_emulate( >> { >> unsigned long zero = 0; >> >> +vcpu_must_have(clzero); > Hmm, wait - doesn't this break the test harness? I.e. don't you need > to also adjust e

Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

2017-03-27 Thread Jan Beulich
>>> On 27.03.17 at 11:56, wrote: > @@ -5183,6 +5184,8 @@ x86_emulate( > { > unsigned long zero = 0; > > +vcpu_must_have(clzero); Hmm, wait - doesn't this break the test harness? I.e. don't you need to also adjust emul_test_cpuid()? Jan __

Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

2017-03-27 Thread Jan Beulich
>>> On 27.03.17 at 11:56, wrote: > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

2017-03-27 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/x86_emulate/x86_emulate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index 497cc77..7af8a42 100644 --- a/xen/arch/x86/x86_emulate/x86_emu