Re: [AMaViS-user] Subject line oddities...

2008-01-28 Thread Mark Martinec
Christian,

> If I understand correctly, this code is in the 2.5.3 version already ?

No, it is a freshly reported bug, introduced in 2.4.1.
The fix is not yet in any released version.

The provided patch was for 2.5.3. With some fudge it may apply to
earlier versions as well.  It will be fixed in 2.6.0.  By itself
it is not serious enough to warrant a 2.5.4, so unless something
more sinister pops up, there are currently no plans for 2.5.4.

  Mark

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
AMaViS-user mailing list
AMaViS-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/


Re: [AMaViS-user] Subject line oddities...

2008-01-28 Thread Mark Martinec
Mike,

> > > Have had a few messages getting through lately that should have been
> > > tagged as spam but appear not to have the subject line tagged.
> [...]
> The problem seems to be that for this message (and this particular message
> only) that Amavisd is not adding the spam tag to the existing subject line,
> but rather creating a 2nd subject line with the SPAM tag in it.
>
> I have no clue about the mail headers and how Amavisd parses them, but I'd
> take a wild guess that the two colons at the start of the original subject
> line are somehow confusing Amavisd.

You are quite right, it is an ugly bug, the header field is saved under an
incorrect name and later not found when tag is to be inserted into Subject,
so a new one is entered. Here is a fix (diff against 2.5.3, likely to apply
to earlier versions as well):

--- amavisd~2008-01-28 20:29:31.0 +0100
+++ amavisd 2008-01-28 20:30:13.0 +0100
@@ -10712,5 +10712,5 @@
 if ($ln =~ /^[ \t]/) {  # header field continuation
   $orig_header_fields->{$collecting} .= $ln  if defined $collecting;
-} elsif ($ln =~ /^([^ \t]+)[ \t]*:(.*)\z/xsi &&
+} elsif ($ln =~ /^([^: \t]+)[ \t]*:(.*)\z/xsi &&
 $collectable_header_fields{lc($1)}) {
   $collecting = lc($1);


Mark

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
AMaViS-user mailing list
AMaViS-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/


Re: [AMaViS-user] Subject line oddities...

2008-01-26 Thread mouss
Mike Cisar wrote:
> Have had a few messages getting through lately that should have been tagged
> as spam but appear not to have the subject line tagged.
>
> I check the headers and see (some headers removed)...
>
> X-Spam-Flag: YES
> X-Spam-Score: 9.498
> X-Spam-Level: *
> X-Spam-Status: Yes, score=9.498 tagged_above=2 required=5
> tests=[BAYES_99=3.5,
>   GOOG_PAGES=5, NO_RECEIVED=-0.001, NO_RELAYS=-0.001, URIBL_GREY=1]
> Subject: :: 86% Cheaper than Original Price: aRolex, Cartier, Omega, Chanel,
> Tag Heuer, Breitling & ... qfbvvqgron
> Subject: [SPAM -> 9.498]
>
>   

The message probably has two headers. amavisd-new tags one, but your 
client shows the other. nasty trick...

I personally prefer not to tag the subject. Real(TM) MUAs have no 
problems parsing the X-Spam-Flag header...

PS. I am in favour of rejecting any message with duplicate "unique" 
headers (subject, from, to, cc, message-id, date, ...).



> So when the email is viewed in Outlook (only reader I've tried so far) the
> original subject line is shown without spam tag.
>
> S... what's the trick that's making Amavisd create a new subject line
> instead of adding it to theirs?  Is there a way to fix so the tagging
> happens properly?  Running amavisd-new 2.4.4
>   



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
AMaViS-user mailing list
AMaViS-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/


Re: [AMaViS-user] Subject line oddities...

2008-01-26 Thread Mike Cisar
> > Have had a few messages getting through lately that should have been
> tagged
> > as spam but appear not to have the subject line tagged.
> 
> Is the recipient considered local by amavis?  This is a requirement for
> spam tagging.  See "No spam-related headers inserted?" here :

No, the user isn't considered local.  

> Subject: :: 86% Cheaper than Original Price: aRolex, Cartier, Omega, 
> Chanel, Tag Heuer, Breitling & ... qfbvvqgron
> Subject: [SPAM -> 9.498]

The problem seems to be that for this message (and this particular message
only) that Amavisd is not adding the spam tag to the existing subject line,
but rather creating a 2nd subject line with the SPAM tag in it.

I have no clue about the mail headers and how Amavisd parses them, but I'd
take a wild guess that the two colons at the start of the original subject
line are somehow confusing Amavisd.

Cheers,
> Mike < 


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
AMaViS-user mailing list
AMaViS-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/


Re: [AMaViS-user] Subject line oddities...

2008-01-26 Thread MrC
Mike Cisar wrote:
> Have had a few messages getting through lately that should have been tagged
> as spam but appear not to have the subject line tagged.
> 

Is the recipient considered local by amavis?  This is a requirement for 
spam tagging.  See "No spam-related headers inserted?" here :

   http://www.ijs.si/software/amavisd/#faq-gen

MrC

> I check the headers and see (some headers removed)...
> 
> X-Spam-Flag: YES
> X-Spam-Score: 9.498
> X-Spam-Level: *
> X-Spam-Status: Yes, score=9.498 tagged_above=2 required=5
> tests=[BAYES_99=3.5,
>   GOOG_PAGES=5, NO_RECEIVED=-0.001, NO_RELAYS=-0.001, URIBL_GREY=1]
> Subject: :: 86% Cheaper than Original Price: aRolex, Cartier, Omega, Chanel,
> Tag Heuer, Breitling & ... qfbvvqgron
> Subject: [SPAM -> 9.498]
> 
> So when the email is viewed in Outlook (only reader I've tried so far) the
> original subject line is shown without spam tag.
> 
> S... what's the trick that's making Amavisd create a new subject line
> instead of adding it to theirs?  Is there a way to fix so the tagging
> happens properly?  Running amavisd-new 2.4.4
> 
> Cheers,
>> Mike <

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
AMaViS-user mailing list
AMaViS-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/


[AMaViS-user] Subject line oddities...

2008-01-26 Thread Mike Cisar
Have had a few messages getting through lately that should have been tagged
as spam but appear not to have the subject line tagged.

I check the headers and see (some headers removed)...

X-Spam-Flag: YES
X-Spam-Score: 9.498
X-Spam-Level: *
X-Spam-Status: Yes, score=9.498 tagged_above=2 required=5
tests=[BAYES_99=3.5,
GOOG_PAGES=5, NO_RECEIVED=-0.001, NO_RELAYS=-0.001, URIBL_GREY=1]
Subject: :: 86% Cheaper than Original Price: aRolex, Cartier, Omega, Chanel,
Tag Heuer, Breitling & ... qfbvvqgron
Subject: [SPAM -> 9.498]

So when the email is viewed in Outlook (only reader I've tried so far) the
original subject line is shown without spam tag.

S... what's the trick that's making Amavisd create a new subject line
instead of adding it to theirs?  Is there a way to fix so the tagging
happens properly?  Running amavisd-new 2.4.4

Cheers,
> Mike <


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
AMaViS-user mailing list
AMaViS-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/