Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]
On Fri, 24 May 2024 16:36:32 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.properties: used to regain compatibility from any more >>> restricted configuration than previous versions such as JDK 22 >> >> Updated on 5/16/2024 >> >> Design change: >> The design is changed to include in the JDK two configuration files that are >> the default jaxp.properties and jaxp-strict.properties, instead of three, >> dropping jaxp-compat.properties. >> >> Updated on 5/18/2024 >> >> Withdraw changes to jaxp.properties. The original idea was to match >> jaxp-strict.properties with regard to the properties. However, that change >> impact the configuration process, resulting in tests that verify the process >> to fail. >> >> Updated on 5/23/2024 >> >> Provide a template `jaxp-strict.template` instead of a properties file. This >> template can be used to create custom configuration files. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > rename the template to jaxp-strict.properties.template Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18831#pullrequestreview-2077722644
Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the warning enabled. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17692#pullrequestreview-1866015274
Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment Thank you Joe. All good by me and Congrats on moving this across the goal line - Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16719#pullrequestreview-1740399188
Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v2]
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Hi Joe,
Thank you for all of your hard work and perseverance to drive this project as I
realize it was a lot of work and iterations based on feedback from the team.
Overall looks good. A couple of minor comments below
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java
line 1084:
> 1082: String publicId, String systemId) {
> 1083: InputSource is = resolveWithCatalog(cr, cFile, publicId,
> systemId);
> 1084: //if (is != null && !is.isEmpty()) {
Probably can delete this
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java
line 1101:
> 1099: return cr.resolveEntity(publicId, systemId);
> 1100: } catch (CatalogException e) {
> 1101:
> fErrorReporter.reportError(XMLMessageFormatter.XML_DOMAIN,"CatalogException",
Alignment looks like it needs to be sanity checked here
-
PR Review: https://git.openjdk.org/jdk/pull/16719#pullrequestreview-1739611943
PR Review Comment: https://git.openjdk.org/jdk/pull/16719#discussion_r1399080861
PR Review Comment: https://git.openjdk.org/jdk/pull/16719#discussion_r1399081930
Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Although some of the short names in the COMPAT provider are >> somewhat questionable (less common ones are simply made up from the long >> names by taking the initials), it would not be desirable for them to fall >> back to the GMT format. >> To mitigate the situation, CLDR can use the abbreviated names from the TZ >> database, which contains legacy (major) short names as FORMAT. The CLDR >> provider can use them instead of the GMT offset style. This enhancement is a >> precursor to the future removal of the COMPAT provider. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Delay populating GMT format at runtime. Reflecting review comments. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16206#pullrequestreview-1683251272
Re: RFR: 8306323: Update license files in CLDR v43
On Tue, 18 Apr 2023 18:40:03 GMT, Naoto Sato wrote: > The upgrade to CLDR v43 was missing the license-related file updates. Here > are the supplemental updates. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13517#pullrequestreview-1390742707
Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on the generated HTML pages) can be summarized >> as follows: >> >> >> diff -ur >> build/macosx-aarch64/images/docs-before/api/serialized-form.html >> build/macosx-aarch64/images/docs-after/api/serialized-form.html >> --- build/macosx-aarch64/images/docs-before/api/serialized-form.html >> 2023-03-02 11:47:44 >> +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html >> 2023-03-02 11:48:45 >> @@ -17084,7 +17084,7 @@ >> throws > href="java.base/java/io/IOException.html" title="class in >> java.io">IOException, >> ClassNotFoundException >> readObject is called to restore the >> state of the >> - (@code BasicPermission} from a stream. >> + BasicPermission from a stream. >> >> Parameters: >> s - the ObjectInputStream from which data >> is read >> >> Notes >> - >> >> * I'm not an expert in any of the affected areas, except for jdk.javadoc, >> and I was merely after misused tags. Because of that, I would appreciate >> reviews from experts in other areas. >> * I discovered many more issues than I included in this PR. The excluded >> issues seem to occur in infrequently updated third-party code (e.g. >> javax.xml), which I assume we shouldn't touch unless necessary. >> * I will update copyright years after (and if) the fix had been approved, as >> required. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into 8303480 > - Initial commit Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12826
Re: RFR: 8301119: Support for GB18030-2022 [v4]
On Fri, 24 Feb 2023 17:23:25 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping falls back to the existing mapping based on the 2000 standard, >> otherwise, it defaults to 2022 mapping. Refer to the corresponding CSR for >> more detail. > > Naoto Sato has updated the pull request incrementally with two additional > commits since the last revision: > > - Failed to add the file itself > - Changed GB18030 from extcs template to stdcs source Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12518
Re: RFR: 8303020: Remove carriage return in pandoc version string
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote:
> On windows/cygwin, the PANDOC_VERSION variable includes the carriage return
> ('\r') which makes the version check fail:
>
> checking for pandoc version... 2.19.2
> , not the recommended version 2.19.2n 2.19.2
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12696
Re: RFR: 8297353: Regenerated checked-in html files with new pandoc
On Mon, 21 Nov 2022 16:20:57 GMT, Magnus Ihse Bursie wrote: > Following JDK-8297165, we should regenerate all checked in html files using > pandoc 1.19.2, to avoid spurious changes to the files with future changes to > the markdown source files. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11274
Re: RFR: 8292911: Add a note about jtreg failure handlers in the testing doc [v3]
On Fri, 26 Aug 2022 13:48:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change to the testing documentation which >> adds a note about failure handlers in jtreg? This addresses >> https://bugs.openjdk.org/browse/JDK-8292911. >> >> Recently, there have been users who have been prompted for sudo password >> when running jtreg tests locally and those tests running into failures. This >> is because one of the commands that gets executed by the jtreg failure >> handler uses sudo (the `sudo dmesg` command on macos). >> >> This commit updates the `testing.md` to explain what the failure handler >> does and also mentions the configuration that can be used to disable the >> failure handler. This commit doesn't specify how to configure the `sudoers` >> file if the user still wants to allow the failure handlers to run, because I >> thought that would be outside the scope of this documentation. >> >> I attempted to auto generate the `testing.html` from the changes to >> `testing.md` using the `make update-build-docs` command, but that generated >> a lot of unnecessary diffs not just in `testing.html` but other html files >> in the `doc` directory. So, as suggested in a different PR which involved >> updates to these files, I manually added the section to the `testing.html` >> too. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > fix line length Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10021
