Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]
On Fri, 25 Nov 2022 01:34:26 GMT, Sergey Bylokhov wrote: >> The native method used to access the private method in the `ICC_Profile` >> class is replaced by the accessor. > > Sergey Bylokhov has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8296905 > - Update AWTAccessor.java > - Merge remote-tracking branch 'upstream/master' into JDK-8296905 > - 8296905: Replace the native LCMS#getProfileID() method with the accessor Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.org/jdk/pull/6
Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]
On Fri, 25 Nov 2022 02:21:09 GMT, SWinxy wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into JDK-8296905
>> - Update AWTAccessor.java
>> - Merge remote-tracking branch 'upstream/master' into JDK-8296905
>> - 8296905: Replace the native LCMS#getProfileID() method with the accessor
>
> src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMS.java line 59:
>
>> 57: if (p instanceof LCMSProfile) {
>> 58: return (LCMSProfile)p;
>> 59: }
>
> Would be a good time to
> Suggestion:
>
> if (p instanceof LCMSProfile profile) {
> return profile;
> }
That change is possible but it will be better to do it as a separate cleanup.
-
PR: https://git.openjdk.org/jdk/pull/6
Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]
On Fri, 25 Nov 2022 01:34:26 GMT, Sergey Bylokhov wrote:
>> The native method used to access the private method in the `ICC_Profile`
>> class is replaced by the accessor.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains four additional
> commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8296905
> - Update AWTAccessor.java
> - Merge remote-tracking branch 'upstream/master' into JDK-8296905
> - 8296905: Replace the native LCMS#getProfileID() method with the accessor
src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMS.java line 59:
> 57: if (p instanceof LCMSProfile) {
> 58: return (LCMSProfile)p;
> 59: }
Would be a good time to
Suggestion:
if (p instanceof LCMSProfile profile) {
return profile;
}
-
PR: https://git.openjdk.org/jdk/pull/6
Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v3]
> The native method used to access the private method in the `ICC_Profile` > class is replaced by the accessor. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8296905 - Update AWTAccessor.java - Merge remote-tracking branch 'upstream/master' into JDK-8296905 - 8296905: Replace the native LCMS#getProfileID() method with the accessor - Changes: - all: https://git.openjdk.org/jdk/pull/6/files - new: https://git.openjdk.org/jdk/pull/6/files/f7b74481..9e7819fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=6&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=6&range=01-02 Stats: 26596 lines in 411 files changed: 11421 ins; 4961 del; 10214 mod Patch: https://git.openjdk.org/jdk/pull/6.diff Fetch: git fetch https://git.openjdk.org/jdk pull/6/head:pull/6 PR: https://git.openjdk.org/jdk/pull/6
