[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-494569336 @PaulAngus thanks for info i will discuss this with @pbankonier and come back This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-494568021 @syed can you check this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel opened a new pull request #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel opened a new pull request #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3346 ## Description * remove unused old vars and functions e.g. today, chksum... * rename createtmplt.sh to createtemplt to unify the files in overall context * add function to calculate the virtual size of template for managed storage (netapp solidfire) so that the copy process is working from NFS to iSCSI correctly * refactor cloud-install-sys-tmplt creates all settings of template.properties * refactor createtmplt shall create only the templates e.g. uncompress and install ... ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [X] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? tested manually in our production environment with different files like vhd, qcow2 and ova This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3345: Fix iops values when creating a compute offering
nathanejohnson commented on issue #3345: Fix iops values when creating a compute offering URL: https://github.com/apache/cloudstack/pull/3345#issuecomment-494557717 @svenvogel I will test this locally. thanks for the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494540543 @anuragaw added integration test as you suggested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3343: listVirtualMachines does not show instances belonging to a project
ustcweizhou commented on issue #3343: listVirtualMachines does not show instances belonging to a project URL: https://github.com/apache/cloudstack/issues/3343#issuecomment-494504125 @PaulAngus We have some changes in 4.7.1 to list all project resources in default view. That's the default behavior in our fork. As you can see, it breaks the backwards compatibility. We need to make more changes before creating a pull request to mainstream. I will look into it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494503124 Trillian test result (tid-3565) Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33066 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr-t3565-kvm-centos6.zip Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 67 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_service_offering_cpu_limit_use | `Error` | 1.35 | test_service_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3294: Set default service offering over api and ui
PaulAngus commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-494469362 @svenvogel @pbankonier - I can see that you've put a lot of work into this, but unless I've missed something, couldn't this be done a bit simpler by populating the service_offering_id for all of the default network offerings as: 9 or 10 (shared/local storage offerings for domainrouter). Then the network offering would be linked to an actual service offering rather than the weird global settings business. Migrating from the global settings if people have updated them wouldn't be difficult, the service offerings 9 and 10 would just have to be updated with the values in the global settings. Editing the material properties of a offering has always been a no-no (with very good reasons) but maybe we can make an exception for the system vm offerings to allow change CPU and RAM values. // @ustcweizhou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3343: listVirtualMachines does not show instances belonging to a project
PaulAngus commented on issue #3343: listVirtualMachines does not show instances belonging to a project URL: https://github.com/apache/cloudstack/issues/3343#issuecomment-494456541 @ustcweizhou did you say that you guys are planning on changing this behaviour or just that you would also like to see it changed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier opened a new pull request #3345: Fix iops values when creating a compute offering
pbankonier opened a new pull request #3345: Fix iops values when creating a compute offering URL: https://github.com/apache/cloudstack/pull/3345 ## Description When creating a new compute offering over the ui, the isCustomIops parameter is null. In this case the minIops and maxIops values of the offering gets set to 0 instead of null and when trying to change an instance to this offering an error occurs. This was introduced in this PR https://github.com/apache/cloudstack/pull/3133/files. I already opened an issue regarding this. (https://github.com/apache/cloudstack/issues/3332) ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots:    https://user-images.githubusercontent.com/6997263/58095320-0b55d080-7bd3-11e9-8be1-f110b00222d1.png";> https://user-images.githubusercontent.com/6997263/58095301-042ec280-7bd3-11e9-8033-7696a77a664a.png";> ## How Has This Been Tested? Deployed to local environment and tested functionality. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3344: [WIP] server: return usage description with resource names and UUIDs
blueorangutan commented on issue #3344: [WIP] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-494362674 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494358412 Trillian test result (tid-3564) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 31352 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr-t3564-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Smoke tests completed. 56 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Error` | 16.37 | test_scale_vm.py test_01_ISO_usage | `Error` | 1.06 | test_usage.py test_01_lb_usage | `Error` | 8.28 | test_usage.py test_01_nat_usage | `Error` | 15.43 | test_usage.py test_01_public_ip_usage | `Error` | 1.08 | test_usage.py test_01_snapshot_usage | `Error` | 57.15 | test_usage.py test_01_template_usage | `Error` | 50.26 | test_usage.py test_01_vm_usage | `Error` | 27.69 | test_usage.py test_01_volume_usage | `Error` | 28.00 | test_usage.py test_01_vpn_usage | `Error` | 19.65 | test_usage.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3344: [WIP] server: return usage description with resource names and UUIDs
blueorangutan commented on issue #3344: [WIP] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-494356047 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3344: [WIP] server: return usage description with resource names and UUIDs
rhtyd commented on issue #3344: [WIP] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-494355713 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3344: [WIP] server: return usage description with resource names and UUIDs
rhtyd opened a new pull request #3344: [WIP] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344 The usage record descriptions have CloudStack's internal integer IDs which makes it difficult for users to read their usages. This PRs introduces a new API boolean flag `oldformat` which when set to true would return the older description format, otherwise by default listUsageRecords will process and return description with names and UUIDs of resources. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on a change in pull request #: server: ssh-keygen in PEM
format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r285968792
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
-libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs());
-// check router is up?
-final VirtualRoutingResource virtRouterResource =
libvirtComputingResource.getVirtRouterResource();
+if (libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs())) {
+break;
+}
Review comment:
@ustcweizhou I can reduce that to 3 maybe.
I could consistently reproduce the issue with latest Ubuntu 19.10 with
latest Centos7.6 used as kvm host.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on a change in pull request #: server: ssh-keygen in PEM
format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r285968792
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
-libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs());
-// check router is up?
-final VirtualRoutingResource virtRouterResource =
libvirtComputingResource.getVirtRouterResource();
+if (libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs())) {
+break;
+}
Review comment:
@ustcweizhou I can reduce that to 3 maybe.
I could consistently reproduce the issue with latest Ubuntu 19.04 with
latest Centos7.6 used as kvm host.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
ustcweizhou commented on a change in pull request #: server: ssh-keygen in
PEM format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r285903428
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
-libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs());
-// check router is up?
-final VirtualRoutingResource virtRouterResource =
libvirtComputingResource.getVirtRouterResource();
+if (libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs())) {
+break;
+}
Review comment:
@rhtyd ok, sorry I did not notice this change.
in this case, do we still need to pass cmd line for max 10 times ?
which ssh-keygen version is impacted ? I would like to test it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] NuxRo commented on issue #3343: listVirtualMachines does not show instances belonging to a project
NuxRo commented on issue #3343: listVirtualMachines does not show instances belonging to a project URL: https://github.com/apache/cloudstack/issues/3343#issuecomment-494316301 ping @ustcweizhou @PaulAngus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NuxRo opened a new issue #3343: listVirtualMachines does not show instances belonging to a project
NuxRo opened a new issue #3343: listVirtualMachines does not show instances belonging to a project URL: https://github.com/apache/cloudstack/issues/3343 Relevant email thread https://lists.apache.org/thread.html/6aca3e7b99816eef127ce516e5ef93bddb7a60a53e72762d5af3c050@%3Cdev.cloudstack.apache.org%3E As a user I have created a project and in it I created a few VMs. These VMs will not show up in "listVirtualMachines" unless the project is specified. e.g. (localcloud) 🐱 > list virtualmachines (localcloud) 🐱 > (localcloud) 🐱 > list virtualmachines projectid=b9a75ec4-82fc-4e88-8733-022df7956143 filter=id, count = 2 virtualmachine: id = 7b7259ac-ac89-43e7-9772-5f7866762be3 id = 0a1bb820-2ad6-4a71-bda0-29bb0ead6781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets
ustcweizhou opened a new pull request #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets URL: https://github.com/apache/cloudstack/pull/3342 ## Description If there are multiple IPs in different subnet assigned to a VPC, after restarting VPC with cleanup, the VRs will be FAULT state. Step to reproduce: (1) create vpc, source nat IP is 10.11.118.X (2) assign two public IPs in other subnet to this VPC. 10.11.119.X and 10.11.119.Y (3) deploy two vms in the vpc, and enable static nat 10.11.119.X and 10.11.119.Y to these two vms (4) restart vpc with cleanup. There are more than 1 nic allocated for 10.11.119 to new VRs Logs as below: 2019-05-10 14:12:24,652 DEBUG [o.a.c.e.o.NetworkOrchestrator] (API-Job-Executor-36:ctx-839f6522 job-652 ctx-35fb4667) (logid:1ab7aa37) Allocating nic for vm VM[DomainRouter|r-85-VM] in network Ntwk[200|Public|1] with requested profile NicProfile[0-0-null-10.11.118.157-vlan://untagged 2019-05-10 14:12:24,676 DEBUG [o.a.c.e.o.NetworkOrchestrator] (API-Job-Executor-36:ctx-839f6522 job-652 ctx-35fb4667) (logid:1ab7aa37) Allocating nic for vm VM[DomainRouter|r-85-VM] in network Ntwk[200|Public|1] with requested profile NicProfile[0-0-null-10.11.119.110-vlan://119 2019-05-10 14:12:24,699 DEBUG [o.a.c.e.o.NetworkOrchestrator] (API-Job-Executor-36:ctx-839f6522 job-652 ctx-35fb4667) (logid:1ab7aa37) Allocating nic for vm VM[DomainRouter|r-85-VM] in network Ntwk[200|Public|1] with requested profile NicProfile[0-0-null-10.11.119.110-vlan://119 2019-05-10 14:12:24,723 DEBUG [o.a.c.e.o.NetworkOrchestrator] (API-Job-Executor-36:ctx-839f6522 job-652 ctx-35fb4667) (logid:1ab7aa37) Allocating nic for vm VM[DomainRouter|r-85-VM] in network Ntwk[200|Public|1] with requested profile NicProfile[0-0-null-10.11.119.110-vlan://119 This is a regression issue caused by commit 1d382e0cb48fc428bbe753dcfe4116bc71231206 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? see Description Everything works fine with this patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on a change in pull request #: server: ssh-keygen in PEM
format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r285889257
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -125,9 +125,14 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
-libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs());
-// check router is up?
-final VirtualRoutingResource virtRouterResource =
libvirtComputingResource.getVirtRouterResource();
+if (libvirtComputingResource.passCmdLine(vmName,
vmSpec.getBootArgs())) {
+break;
+}
Review comment:
@ustcweizhou the blind waiting and passing cmdline is not necessary now, in
the new patch.sh script it waits until it's able to communicate with the
qemu-guest-agent running inside the systemvm appliance. See:
https://github.com/apache/cloudstack/blob/master/scripts/vm/hypervisor/kvm/patch.sh#L61
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface
ustcweizhou commented on a change in pull request #3338: ui: fix enable static
nat only towards first nic and not on any other interface
URL: https://github.com/apache/cloudstack/pull/3338#discussion_r285883007
##
File path: ui/scripts/network.js
##
@@ -87,12 +87,21 @@
} else { //non-portable IP which has only one NIC
// Get NIC IPs
+var data = {
+virtualmachineid: instance.id,
+};
+if (args.context.networkid != undefined) {
+$.extend(data, {
+networkid: args.context.networkid
+});
+} else {
+$.extend(data, {
+networkid: network.id
+});
+}
Review comment:
@anuragaw
Changed the code as you suggested, tested ok.
thanks for good suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DennisKonrad commented on issue #3296: [4.13] noVNC console
DennisKonrad commented on issue #3296: [4.13] noVNC console URL: https://github.com/apache/cloudstack/pull/3296#issuecomment-494265390 @ustcweizhou No error, just not loading anything. I will try this again tomorror and report back. I'm not sure anymore if I correctly set the global variable. But the variable is present. If you have any questions I should check on please feel free to ask. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
