Re: [IO] Almost ready for a 1.1 release?

2004-10-25 Thread Henri Yandell
On Mon, 25 Oct 2004 16:33:51 -0700, Martin Cooper <[EMAIL PROTECTED]> wrote:
> On Mon, 25 Oct 2004 18:55:08 -0400, Henri Yandell <[EMAIL PROTECTED]> wrote:
> > I hadn't realised we were this close to a 1.1, but I'm +1 for a release.
> 
> If you don't think we're ready, or there's more that you'd like to do
> / see done prior to a 1.1, then by all means speak up. ;-) I'm not in
> that much of a hurry that we should rush it out.

I'm a little tied up with a newborn at the moment, and IO 1.1 is
behind Lang 2.1 on my target list. Neither are being driven by itches,
apart from a general itch to get the Finder code to more people and to
get new releases with bugfixes out there.

> (My personal itch for this is that FileUpload now has a dependency on
> a recent nightly build of IO, and I'd like to do a 1.1 of FileUpload
> reasonably soon, but I'm not in a big rush. I'd rather do things
> right.)

I'd quite happily do 1.1-alpha releases and things. Much rather
release-early than release-right.

> > I just moved WildcardUtils up a directory as it's used by two
> > different subpackages of IO.
> 
> Saw that.

To answer Gary's suggestion of moving this into FilenameUtils; I'm not
anti that suggestion. Obviously FilenameUtils would have to be closer
to release first.

> > There are a couple of options on the finder code which are not
> > implemented yet (time ones I think).
> 
> I guess it might be better to finish that up than release it not fully
> baked. ;-)

It's a clone as such of the unix command line tool, so a few of the
flags that may be done in unix find are yet to be coded. Not that
necessary for a release-early. Someone did post a different way to do
the flags though; which needs to be looked at. I'm a huge fan of the
find command in Unix, and wanted something to let me write similar
style scripts in Java. It was partly written to be called from Groovy.

> I just noticed a couple of items on the IO wiki page:
> 
> http://wiki.apache.org/jakarta-commons/IO
> 
> Can you (or someone else) elaborate on what it means to get
> FilenameUtils and ClassLoaderObjectInputStream "release ready"? It's a
> bit vague... ;-)

Yep, tis vague. Remember that much of IO is accumulated code, which is
then cleaned up and tests written for it.

FilenameUtils had a lot of issues. We'll need to go back in the list
history to see what they were. Methods need killing, writing, testing
etc.

ClassLoaderOIS needs unit tests written. The effort of figuring out
how to unit test it was always greater than the itch to include it in
an IO release :)

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JELLY-107) util:properties doesn't evaluate expressions

2004-10-25 Thread Hans Gilde (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-107?page=comments#action_54636 ]
 
Hans Gilde commented on JELLY-107:
--

If we're going to allow for plugin expression evaluators in the future, how would that 
fit into a situation like this? Maybe that's just something to deal with later.

> util:properties doesn't evaluate expressions
> 
>
>  Key: JELLY-107
>  URL: http://issues.apache.org/jira/browse/JELLY-107
>  Project: jelly
> Type: Improvement
>   Components: taglib.util
> Reporter: Sean Timm
>  Attachments: PropertiesTagEvaluateExpression.diff
>
> The current implementation of util:properties has an @todo indicating that the 
> property values should be evaluated as expressions.  I've added the code necessary 
> to do so and will attach a patch shortly.  
> Note that I'm very unfamiliar with the Jelly source, so it's entirely possible that 
> I've done something wrong, but it appears to work, and the existing tests still pass 
> successfully.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JELLY-159) share base test classes with tag lib test builds

2004-10-25 Thread Hans Gilde (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-159?page=comments#action_54635 ]
 
Hans Gilde commented on JELLY-159:
--

I agree

> share base test classes with tag lib test builds
> 
>
>  Key: JELLY-159
>  URL: http://issues.apache.org/jira/browse/JELLY-159
>  Project: jelly
> Type: Improvement
>   Components: core / taglib.core
> Versions: 1.0
> Reporter: Hans Gilde
> Priority: Minor

>
> Base test classes like BaseJellyTest aren't shareable, so we have several versions 
> of the same classes. I don't know if these classes should go in core or if the build 
> should be updated to share the core test clases.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30855] - [lang] Additional constructor for EqualsBuilder and isEquals member access.

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30855

[lang] Additional constructor for EqualsBuilder and isEquals member access.





--- Additional Comments From [EMAIL PROTECTED]  2004-10-26 00:15 ---
Ari,

Please start here: http://jakarta.apache.org/commons/patches.html.

Please post messages on commons-dev for further help.

Thanks,
Gary

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30855] - [lang] Additional constructor for EqualsBuilder and isEquals member access.

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30855

[lang] Additional constructor for EqualsBuilder and isEquals member access.





--- Additional Comments From [EMAIL PROTECTED]  2004-10-26 00:08 ---
That's fine.  I don't know the process for submitting code changes, but if 
you'd like me to make the actual modifications, I can do so.  Please send me 
any specifics.

Thanks,
Ari

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [IO] Almost ready for a 1.1 release?

2004-10-25 Thread Gary Gregory
> -Original Message-
> From: Martin Cooper [mailto:[EMAIL PROTECTED]
> Sent: Sunday, October 24, 2004 20:16
> To: Jakarta Commons Developers List
> Subject: [IO] Almost ready for a 1.1 release?
> 
> So what do folks think? I'm willing to act as RM, unless someone else
> feels like rolling the release.

IMO, release early, release often.

Gary


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [IO] Almost ready for a 1.1 release?

2004-10-25 Thread Stephen Colebourne
From: "Martin Cooper" <[EMAIL PROTECTED]>
> On Mon, 25 Oct 2004 18:55:08 -0400, Henri Yandell <[EMAIL PROTECTED]>
wrote:
> > I hadn't realised we were this close to a 1.1, but I'm +1 for a release.

Release early... means we should get a release out.

> > I just moved WildcardUtils up a directory as it's used by two
> > different subpackages of IO.
Should this just be a method on FilenameUtils? Although the class isn't
specific, maybe we should make it specific.

> > There are a couple of options on the finder code which are not
> > implemented yet (time ones I think).
> I guess it might be better to finish that up than release it not fully
> baked. ;-)
I'd rather release without the finder directory at present. I'm not sure
quite how it fits with the rest of [io] yet.

> > Is there any reason for the IOTestSuite class? It doesn't seem
> > necessary with Maven and seems unlikely to be needed by the generated
> > Maven build.xml (which we need to make sure we redo).
> Hmm, probably not. I'll make sure first, and then take it out assuming
> all is OK.
I've just fixed it, renamed it and added the other missing test suite
classes. They are used by IDE developers who don't want to run ant (and are
in fact faster if you do run ant)

> > > So what do folks think? I'm willing to act as RM, unless someone else
> > > feels like rolling the release.
+1

I currently have two errors, though:
There were 2 errors:
1)
testIsFileNewer(org.apache.commons.io.FileUtilsFileNewerTestCase)java.lang.I
llegalStateException: The temporary file hasn't the right last modification
date
 at
org.apache.commons.io.FileUtilsFileNewerTestCase.testIsFileNewer(FileUtilsFi
leNewerTestCase.java:122)
 at
org.apache.commons.io.FileUtilsFileNewerTestCase.testIsFileNewer(FileUtilsFi
leNewerTestCase.java:72)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
 at org.apache.commons.io.AllIOTestSuite.main(AllIOTestSuite.java:30)
2)
testIsFileNewerImaginaryFile(org.apache.commons.io.FileUtilsFileNewerTestCas
e)java.lang.IllegalStateException: The temporary file hasn't the right last
modification date
 at
org.apache.commons.io.FileUtilsFileNewerTestCase.testIsFileNewer(FileUtilsFi
leNewerTestCase.java:122)
 at
org.apache.commons.io.FileUtilsFileNewerTestCase.testIsFileNewerImaginaryFil
e(FileUtilsFileNewerTestCase.java:89)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
 at org.apache.commons.io.AllIOTestSuite.main(AllIOTestSuite.java:30)

and its too late to look at them. I'm Win98 in case anyone has a chance to
look.

For the release we must ensure that we run jdiff and clirr to check what has
changed and avoid all backwards binary/source incompatability.

Stephen



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-commons/io/src/java/org/apache/commons/io FilenameUtils.java

2004-10-25 Thread Stephen Colebourne
I reckoned removePath() was the same, as the comment referred to basepath.
Stephen

- Original Message -
From: "Martin Cooper" <[EMAIL PROTECTED]>
> I was looking at that method yesterday and wondering why it was
> deprecated. Anyone know?
>
> --
> Martin Cooper
>
>
> On 25 Oct 2004 23:27:42 -, [EMAIL PROTECTED]
> <[EMAIL PROTECTED]> wrote:
> > scolebourne2004/10/25 16:27:41
> >
> >  Modified:io/src/java/org/apache/commons/io FilenameUtils.java
> >  Log:
> >  Remove deprecated method for first release
> >
> >  Revision  ChangesPath
> >  1.14  +2 -28
jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java
> >
> >  Index: FilenameUtils.java
> >  ===
> >  RCS file:
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.ja
va,v
> >  retrieving revision 1.13
> >  retrieving revision 1.14
> >  diff -u -r1.13 -r1.14
> >  --- FilenameUtils.java24 Oct 2004 18:34:23 -  1.13
> >  +++ FilenameUtils.java25 Oct 2004 23:27:41 -  1.14
> >  @@ -56,6 +56,7 @@
> >* @author Martin Cooper
> >* @author mailto:[EMAIL PROTECTED]">Jeremias Maerki
> >* @version $Id$
> >  + * @since Commons IO 1.1
> >*/
> >   public class FilenameUtils {
> >
> >  @@ -462,33 +463,6 @@
> >   path = path.replace(INTERNAL_SEPARATOR_CHAR,
File.separatorChar);
> >   }
> >   return path;
> >  -}
> >  -
> >  -// DEPRECATED. Though no replacement exists.
> >  -
> >  -/**
> >  - * Returns the filename portion of a file specification string.
> >  - * Matches the equally named unix command.
> >  - * @param filename filename to inspect
> >  - * @param suffix additional remaining portion of name that if
matches will
> >  - * be removed
> >  - * @return The filename string without the suffix.
> >  - * @deprecated This method will be deleted.
> >  - */
> >  -public static String basename(String filename, String suffix) {
> >  -int i = filename.lastIndexOf(File.separator) + 1;
> >  -int lastDot =
> >  -((suffix != null) && (suffix.length() > 0))
> >  -? filename.lastIndexOf(suffix)
> >  -: -1;
> >  -
> >  -if (lastDot >= 0) {
> >  -return filename.substring(i, lastDot);
> >  -} else if (i > 0) {
> >  -return filename.substring(i);
> >  -} else {
> >  -return filename; // else returns all (no path and no
extension)
> >  -}
> >   }
> >
> >   }
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-commons/io/src/java/org/apache/commons/io FilenameUtils.java

2004-10-25 Thread Martin Cooper
I was looking at that method yesterday and wondering why it was
deprecated. Anyone know?

--
Martin Cooper


On 25 Oct 2004 23:27:42 -, [EMAIL PROTECTED]
<[EMAIL PROTECTED]> wrote:
> scolebourne2004/10/25 16:27:41
> 
>  Modified:io/src/java/org/apache/commons/io FilenameUtils.java
>  Log:
>  Remove deprecated method for first release
> 
>  Revision  ChangesPath
>  1.14  +2 -28 
> jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java
> 
>  Index: FilenameUtils.java
>  ===
>  RCS file: 
> /home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java,v
>  retrieving revision 1.13
>  retrieving revision 1.14
>  diff -u -r1.13 -r1.14
>  --- FilenameUtils.java24 Oct 2004 18:34:23 -  1.13
>  +++ FilenameUtils.java25 Oct 2004 23:27:41 -  1.14
>  @@ -56,6 +56,7 @@
>* @author Martin Cooper
>* @author mailto:[EMAIL PROTECTED]">Jeremias Maerki
>* @version $Id$
>  + * @since Commons IO 1.1
>*/
>   public class FilenameUtils {
> 
>  @@ -462,33 +463,6 @@
>   path = path.replace(INTERNAL_SEPARATOR_CHAR, File.separatorChar);
>   }
>   return path;
>  -}
>  -
>  -// DEPRECATED. Though no replacement exists.
>  -
>  -/**
>  - * Returns the filename portion of a file specification string.
>  - * Matches the equally named unix command.
>  - * @param filename filename to inspect
>  - * @param suffix additional remaining portion of name that if matches will
>  - * be removed
>  - * @return The filename string without the suffix.
>  - * @deprecated This method will be deleted.
>  - */
>  -public static String basename(String filename, String suffix) {
>  -int i = filename.lastIndexOf(File.separator) + 1;
>  -int lastDot =
>  -((suffix != null) && (suffix.length() > 0))
>  -? filename.lastIndexOf(suffix)
>  -: -1;
>  -
>  -if (lastDot >= 0) {
>  -return filename.substring(i, lastDot);
>  -} else if (i > 0) {
>  -return filename.substring(i);
>  -} else {
>  -return filename; // else returns all (no path and no extension)
>  -}
>   }
> 
>   }
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/io/src/test/org/apache/commons/io/output PackageTestSuite.java

2004-10-25 Thread scolebourne
scolebourne2004/10/25 16:43:32

  Added:   io/src/test/org/apache/commons/io/input
PackageTestSuite.java
   io/src/test/org/apache/commons/io/filefilter
PackageTestSuite.java
   io/src/test/org/apache/commons/io/output
PackageTestSuite.java
  Log:
  Add package test suites
  
  Revision  ChangesPath
  1.1  
jakarta-commons/io/src/test/org/apache/commons/io/input/PackageTestSuite.java
  
  Index: PackageTestSuite.java
  ===
  /*
   * Copyright 2004 The Apache Software Foundation.
   * 
   * Licensed under the Apache License, Version 2.0 (the "License");
   * you may not use this file except in compliance with the License.
   * You may obtain a copy of the License at
   * 
   *  http://www.apache.org/licenses/LICENSE-2.0
   * 
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  
  package org.apache.commons.io.input;
  
  import junit.framework.Test;
  import junit.framework.TestSuite;
  import junit.textui.TestRunner;
  
  /**
   * A basic test suite that tests all the IO input package.
   * 
   * @author Stephen Colebourne
   */
  public class PackageTestSuite {
  
  public static void main(String[] args) {
  TestRunner.run(suite());
  }
  
  public static Test suite() {
  TestSuite suite = new TestSuite("IO Utilities - input");
  suite.addTest(new TestSuite(CountingInputStreamTest.class));
  suite.addTest(new TestSuite(SwappedDataInputStreamTest.class));
  return suite;
  }
  }
  
  
  
  1.1  
jakarta-commons/io/src/test/org/apache/commons/io/filefilter/PackageTestSuite.java
  
  Index: PackageTestSuite.java
  ===
  /*
   * Copyright 2004 The Apache Software Foundation.
   * 
   * Licensed under the Apache License, Version 2.0 (the "License");
   * you may not use this file except in compliance with the License.
   * You may obtain a copy of the License at
   * 
   *  http://www.apache.org/licenses/LICENSE-2.0
   * 
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  
  package org.apache.commons.io.filefilter;
  
  import junit.framework.Test;
  import junit.framework.TestSuite;
  import junit.textui.TestRunner;
  
  /**
   * A basic test suite that tests all the IO filefilter package.
   * 
   * @author Stephen Colebourne
   */
  public class PackageTestSuite {
  
  public static void main(String[] args) {
  TestRunner.run(suite());
  }
  
  public static Test suite() {
  TestSuite suite = new TestSuite("IO Utilities - file filters");
  suite.addTest(new TestSuite(AndFileFilterTestCase.class));
  suite.addTest(new TestSuite(FileFilterTestCase.class));
  suite.addTest(new TestSuite(OrFileFilterTestCase.class));
  return suite;
  }
  }
  
  
  
  1.1  
jakarta-commons/io/src/test/org/apache/commons/io/output/PackageTestSuite.java
  
  Index: PackageTestSuite.java
  ===
  /*
   * Copyright 2004 The Apache Software Foundation.
   * 
   * Licensed under the Apache License, Version 2.0 (the "License");
   * you may not use this file except in compliance with the License.
   * You may obtain a copy of the License at
   * 
   *  http://www.apache.org/licenses/LICENSE-2.0
   * 
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  
  package org.apache.commons.io.output;
  
  import junit.framework.Test;
  import junit.framework.TestSuite;
  import junit.textui.TestRunner;
  
  /**
   * A basic test suite that tests all the IO output package.
   * 
   * @author Stephen Colebourne
   */
  public class PackageTestSuite {
  
  public static void main(String[] args) {
  TestRunner.run(suite());
  }
  
  public static Test suite() {
  TestSuite suite = new TestSuite("IO Utilities - output");
  suite.addTest(new TestSuite(ByteArrayOutputStreamTestCase.class));

cvs commit: jakarta-commons/io/src/test/org/apache/commons/io PackageTestSuite.java IOTestSuite.java

2004-10-25 Thread scolebourne
scolebourne2004/10/25 16:35:48

  Modified:io   build.xml project.xml
  Added:   io/src/test/org/apache/commons/io PackageTestSuite.java
  Removed: io/src/test/org/apache/commons/io IOTestSuite.java
  Log:
  Rename IOTestSuite to PackageTestSuite, include all tests
  
  Revision  ChangesPath
  1.20  +2 -0  jakarta-commons/io/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-commons/io/build.xml,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- build.xml 24 Oct 2004 21:58:44 -  1.19
  +++ build.xml 25 Oct 2004 23:35:48 -  1.20
  @@ -108,6 +108,8 @@
 
 
 
  +  
  +  
 
 
   
  
  
  
  1.34  +1 -0  jakarta-commons/io/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-commons/io/project.xml,v
  retrieving revision 1.33
  retrieving revision 1.34
  diff -u -r1.33 -r1.34
  --- project.xml   24 Oct 2004 21:58:44 -  1.33
  +++ project.xml   25 Oct 2004 23:35:48 -  1.34
  @@ -184,6 +184,7 @@
 
 
   **/*AbstractTestCase*
  +**/PackageTestSuite*
   **/testtools/**
 
   
  
  
  
  1.1  
jakarta-commons/io/src/test/org/apache/commons/io/PackageTestSuite.java
  
  Index: PackageTestSuite.java
  ===
  /*
   * Copyright 2003-2004 The Apache Software Foundation.
   * 
   * Licensed under the Apache License, Version 2.0 (the "License");
   * you may not use this file except in compliance with the License.
   * You may obtain a copy of the License at
   * 
   *  http://www.apache.org/licenses/LICENSE-2.0
   * 
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  
  package org.apache.commons.io;
  
  import org.apache.commons.io.filefilter.FileFilterTestCase;
  
  import junit.framework.Test;
  import junit.framework.TestSuite;
  import junit.textui.TestRunner;
  
  /**
   * A basic test suite that tests all the IO package.
   * 
   * @author Matthew Hawthorne
   * @author Stephen Colebourne
   * @see org.apache.commons.io
   */
  public class PackageTestSuite {
  
  public static void main(String[] args) {
  TestRunner.run(suite());
  }
  
  public static Test suite() {
  TestSuite suite = new TestSuite("IO Utilities");
  suite.addTest(new TestSuite(CopyUtilsTest.class));
  suite.addTest(new TestSuite(DemuxTestCase.class));
  suite.addTest(new TestSuite(EndianUtilsTest.class));
  suite.addTest(new TestSuite(FilenameUtilsTestCase.class));
  suite.addTest(new TestSuite(FileUtilsFileNewerTestCase.class));
  suite.addTest(new TestSuite(FileUtilsListFilesTestCase.class));
  suite.addTest(new TestSuite(FileUtilsTestCase.class));
  suite.addTest(new TestSuite(FileFilterTestCase.class));
  suite.addTest(new TestSuite(HexDumpTest.class));
  suite.addTest(new TestSuite(IOUtilsCopyTestCase.class));
  suite.addTest(new TestSuite(IOUtilsTestCase.class));
  suite.addTest(new TestSuite(IOUtilsWriteTestCase.class));
  suite.addTest(new TestSuite(WildcardUtilsTest.class));
  return suite;
  }
  }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/io/src/test/org/apache/commons/io WildcardUtilsTest.java

2004-10-25 Thread scolebourne
scolebourne2004/10/25 16:34:24

  Modified:io/src/test/org/apache/commons/io WildcardUtilsTest.java
  Log:
  Organize imports
  
  Revision  ChangesPath
  1.2   +0 -3  
jakarta-commons/io/src/test/org/apache/commons/io/WildcardUtilsTest.java
  
  Index: WildcardUtilsTest.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/test/org/apache/commons/io/WildcardUtilsTest.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- WildcardUtilsTest.java25 Oct 2004 22:55:28 -  1.1
  +++ WildcardUtilsTest.java25 Oct 2004 23:34:24 -  1.2
  @@ -15,10 +15,7 @@
*/
   package org.apache.commons.io;
   
  -import junit.framework.Test;
   import junit.framework.TestCase;
  -import junit.framework.TestSuite;
  -import junit.textui.TestRunner;
   
   public class WildcardUtilsTest extends TestCase {
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [IO] Almost ready for a 1.1 release?

2004-10-25 Thread Martin Cooper
On Mon, 25 Oct 2004 18:55:08 -0400, Henri Yandell <[EMAIL PROTECTED]> wrote:
> I hadn't realised we were this close to a 1.1, but I'm +1 for a release.

If you don't think we're ready, or there's more that you'd like to do
/ see done prior to a 1.1, then by all means speak up. ;-) I'm not in
that much of a hurry that we should rush it out.

(My personal itch for this is that FileUpload now has a dependency on
a recent nightly build of IO, and I'd like to do a 1.1 of FileUpload
reasonably soon, but I'm not in a big rush. I'd rather do things
right.)

> I just moved WildcardUtils up a directory as it's used by two
> different subpackages of IO.

Saw that.

> There are a couple of options on the finder code which are not
> implemented yet (time ones I think).

I guess it might be better to finish that up than release it not fully
baked. ;-)

> Is there any reason for the IOTestSuite class? It doesn't seem
> necessary with Maven and seems unlikely to be needed by the generated
> Maven build.xml (which we need to make sure we redo).

Hmm, probably not. I'll make sure first, and then take it out assuming
all is OK.

I've been regenerating the Ant build file as I've been making changes
to the Maven one, so we're actually in good shape on that at the
moment.

I just noticed a couple of items on the IO wiki page:

http://wiki.apache.org/jakarta-commons/IO

Can you (or someone else) elaborate on what it means to get
FilenameUtils and ClassLoaderObjectInputStream "release ready"? It's a
bit vague... ;-)

--
Martin Cooper


> Hen
> 
> 
> 
> On Sun, 24 Oct 2004 20:15:41 -0700, Martin Cooper <[EMAIL PROTECTED]> wrote:
> > There have been a lot of changes since IO 1.0 was released, and I'm
> > thinking we're in pretty good shape for a 1.1 release in the near
> > future.
> >
> > I've worked through the bug reports, and got us down to four
> > outstanding change requests, as follows:
> >
> > Bugs:
> > #29140 - NPE in FileUtils.listFiles(dir, extensions, recursive)
> > #30974 - problem with copyFileToDirectory(File, File)
> >
> > Enhancements:
> > #28977 - [io] ProxyOutputStream: no need to define proxy
> > #30667 - [io] new throttled input and output stream classes
> >
> > With respect to the bugs, I have been unable to reproduce #29140 and
> > have requested a test case to nail it down. I suspect #30974 is the
> > infamous timing issue that I'm not clear that there's a good solution
> > for, unfortunately.
> >
> > With respect to the enhancements, they're not my particular itches,
> > and I'd be more comfortable with someone else reviewing them (or
> > flagging them for later). However, I'm willing to apply the changes
> > for #30667 if I get a green light from another IO committer who's
> > reviewed them.
> >
> > So what do folks think? I'm willing to act as RM, unless someone else
> > feels like rolling the release.
> >
> > --
> > Martin Cooper
> > 
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/io/src/java/org/apache/commons/io WildcardUtils.java

2004-10-25 Thread scolebourne
scolebourne2004/10/25 16:28:30

  Modified:io/src/java/org/apache/commons/io/filefilter
ConditionalFileFilter.java WildcardFilter.java
AndFileFilter.java OrFileFilter.java
   io/src/java/org/apache/commons/io WildcardUtils.java
  Log:
  Add since tags
  
  Revision  ChangesPath
  1.3   +6 -2  
jakarta-commons/io/src/java/org/apache/commons/io/filefilter/ConditionalFileFilter.java
  
  Index: ConditionalFileFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/filefilter/ConditionalFileFilter.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ConditionalFileFilter.java25 Oct 2004 22:53:26 -  1.2
  +++ ConditionalFileFilter.java25 Oct 2004 23:28:29 -  1.3
  @@ -20,7 +20,7 @@
   /**
* Defines operations for conditional file filters.
*
  - * @since Commons IO 1.0
  + * @since Commons IO 1.1
* @version $Revision$ $Date$
*
* @author Steven Caswell
  @@ -32,6 +32,7 @@
* the list.
*
* @param ioFileFilter the filter to be added
  + * @since Commons IO 1.1
*/
   public void addFileFilter(IOFileFilter ioFileFilter);
   
  @@ -39,6 +40,7 @@
* Returns this conditional file filter's list of file filters.
*
* @return the file filter list
  + * @since Commons IO 1.1
*/
   public List getFileFilters();
   
  @@ -48,6 +50,7 @@
* @param ioFileFilter filter to be removed
* @return true if the filter was found in the list,
* false otherwise
  + * @since Commons IO 1.1
*/
   public boolean removeFileFilter(IOFileFilter ioFileFilter);
   
  @@ -56,6 +59,7 @@
* file filters on this filter.
*
* @param fileFilters the list of filters
  + * @since Commons IO 1.1
*/
   public void setFileFilters(List fileFilters);
   
  
  
  
  1.4   +2 -0  
jakarta-commons/io/src/java/org/apache/commons/io/filefilter/WildcardFilter.java
  
  Index: WildcardFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/filefilter/WildcardFilter.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- WildcardFilter.java   25 Oct 2004 22:55:28 -  1.3
  +++ WildcardFilter.java   25 Oct 2004 23:28:29 -  1.4
  @@ -22,6 +22,8 @@
* 
*
* @author Jason Anderson
  + * @version $Revision$ $Date$
  + * @since Commons IO 1.1
*/
   public class WildcardFilter extends AbstractFileFilter {
   
  
  
  
  1.11  +3 -1  
jakarta-commons/io/src/java/org/apache/commons/io/filefilter/AndFileFilter.java
  
  Index: AndFileFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/filefilter/AndFileFilter.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- AndFileFilter.java25 Oct 2004 22:53:26 -  1.10
  +++ AndFileFilter.java25 Oct 2004 23:28:29 -  1.11
  @@ -42,6 +42,7 @@
   
   /**
* Constructs a new instance of AndFileFilter.
  + * @since Commons IO 1.1
*/
   public AndFileFilter() {
   this.fileFilters = new ArrayList();
  @@ -50,6 +51,7 @@
   /**
* Constructs a new instance of AndFileFilter
* with the specified list of filters.
  + * @since Commons IO 1.1
*/
   public AndFileFilter(final List fileFilters) {
   this.fileFilters = new ArrayList(fileFilters);
  
  
  
  1.11  +3 -1  
jakarta-commons/io/src/java/org/apache/commons/io/filefilter/OrFileFilter.java
  
  Index: OrFileFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/filefilter/OrFileFilter.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- OrFileFilter.java 25 Oct 2004 22:53:26 -  1.10
  +++ OrFileFilter.java 25 Oct 2004 23:28:30 -  1.11
  @@ -42,6 +42,7 @@
   
   /**
* Constructs a new instance of OrFileFilter.
  + * @since Commons IO 1.1
*/
   public OrFileFilter() {
   this.fileFilters = new ArrayList();
  @@ -52,6 +53,7 @@
* with the specified filters.
*
* @param fileFileter the file filters for this filter
  + * @since Commons IO 1.1
*/
   public OrFileFilter(final List fileFilters) {
   this.fileFilters = new ArrayList(fileFilters);
  
  
  
  1.2   +4 -0  
jakarta-commons/io/src/java/org/apache/commons/io/WildcardUtils.java
  
  Index: WildcardUtils.java
  ===

cvs commit: jakarta-commons/io/src/java/org/apache/commons/io FilenameUtils.java

2004-10-25 Thread scolebourne
scolebourne2004/10/25 16:27:41

  Modified:io/src/java/org/apache/commons/io FilenameUtils.java
  Log:
  Remove deprecated method for first release
  
  Revision  ChangesPath
  1.14  +2 -28 
jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java
  
  Index: FilenameUtils.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- FilenameUtils.java24 Oct 2004 18:34:23 -  1.13
  +++ FilenameUtils.java25 Oct 2004 23:27:41 -  1.14
  @@ -56,6 +56,7 @@
* @author Martin Cooper
* @author mailto:[EMAIL PROTECTED]">Jeremias Maerki
* @version $Id$
  + * @since Commons IO 1.1
*/
   public class FilenameUtils {
   
  @@ -462,33 +463,6 @@
   path = path.replace(INTERNAL_SEPARATOR_CHAR, File.separatorChar);
   }
   return path;
  -}
  -
  -// DEPRECATED. Though no replacement exists.
  -
  -/**
  - * Returns the filename portion of a file specification string.
  - * Matches the equally named unix command.
  - * @param filename filename to inspect
  - * @param suffix additional remaining portion of name that if matches will
  - * be removed
  - * @return The filename string without the suffix.
  - * @deprecated This method will be deleted.
  - */
  -public static String basename(String filename, String suffix) {
  -int i = filename.lastIndexOf(File.separator) + 1;
  -int lastDot =
  -((suffix != null) && (suffix.length() > 0))
  -? filename.lastIndexOf(suffix)
  -: -1;
  -
  -if (lastDot >= 0) {
  -return filename.substring(i, lastDot);
  -} else if (i > 0) {
  -return filename.substring(i);
  -} else {
  -return filename; // else returns all (no path and no extension)
  -}
   }
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/io/src/test/org/apache/commons/io/find WildcardUtilsTest.java

2004-10-25 Thread bayard
bayard  2004/10/25 15:55:28

  Modified:io/src/java/org/apache/commons/io/filefilter
WildcardFilter.java
   io/src/java/org/apache/commons/io/find FindingFilter.java
  Added:   io/src/java/org/apache/commons/io WildcardUtils.java
   io/src/test/org/apache/commons/io WildcardUtilsTest.java
  Removed: io/src/java/org/apache/commons/io/find WildcardUtils.java
   io/src/test/org/apache/commons/io/find
WildcardUtilsTest.java
  Log:
  moved WildcardUtils up a directory as it is used in two sub-packages of IO
  
  Revision  ChangesPath
  1.1  
jakarta-commons/io/src/java/org/apache/commons/io/WildcardUtils.java
  
  Index: WildcardUtils.java
  ===
  /*
   * Copyright 2001-2004 The Apache Software Foundation.
   * 
   * Licensed under the Apache License, Version 2.0 (the "License");
   * you may not use this file except in compliance with the License.
   * You may obtain a copy of the License at
   * 
   *  http://www.apache.org/licenses/LICENSE-2.0
   * 
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  package org.apache.commons.io;
  
  import java.util.ArrayList;
  
  /**
   * An implementation of Wildcard logic, as seen on command lines 
   * on UNIX and DOS.
   */
  public class WildcardUtils {
  
  /**
   * See if a particular piece of text, often a filename, 
   * matches to a specified wildcard. 
   */
  public static boolean match(String text, String wildcard) {
  String[] wcs = splitOnTokens(wildcard);

  int textIdx = 0;
  int wcsIdx = 0;
  boolean anyChars = false;

  // loop whilst tokens and text left to process
  while (wcsIdx < wcs.length && textIdx < text.length()) {

  // ? so move to next text char
  if (wcs[wcsIdx].equals("?")) {
  textIdx++;
  } else
  if (!wcs[wcsIdx].equals("*")) {
  // matching text token
  if (anyChars) {
  // any chars then try to locate text token
  textIdx = text.indexOf(wcs[wcsIdx], textIdx);

  if (textIdx == -1) {
  // token not found
  return false;
  }
  } else {
  // matching from current position
  if (!text.startsWith(wcs[wcsIdx], textIdx)) {
  // couldnt match token
  return false;
  }
  }

  // matched text token, move text index to end of matched token
  textIdx += wcs[wcsIdx].length();
  }

  // set any chars status
  anyChars = wcs[wcsIdx].equals("*");

  wcsIdx++;
  }
  
  // didnt match all wildcards
  if (wcsIdx < wcs.length) {
  // ok if one remaining and wildcard or empty
  if (wcsIdx + 1 != wcs.length || !(wcs[wcsIdx].equals("*") || 
wcs[wcsIdx].equals("")) ) {
  return false;
  }
  }

  // ran out of text chars
  if (textIdx > text.length()) {
 return false;
  }

  // didnt match all text chars, only ok if any chars set
  if (textIdx < text.length() && !anyChars) {
  return false;
  }

  return true;
  }
  
  // package level so a unit test may run on this
  static String[] splitOnTokens(String text) {
  char[] array = text.toCharArray();
  if(text.indexOf("?") == -1 && text.indexOf("*") == -1) {
  return new String[] { text };
  }
  
  ArrayList list = new ArrayList();
  StringBuffer buffer = new StringBuffer();
  for(int i=0; ihttp://www.apache.org/licenses/LICENSE-2.0
   * 
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  package org.apache.commons.io;
  
  import junit.framework.Test;
  import junit.framework.TestCase;
  import junit.framework.TestSuite;
  import junit.textui.TestRunner;
  
  public class WildcardUtilsTest extends TestCase {
  
  public WildcardUtilsTest(String name) {
  super(name);
  }

Re: [IO] Almost ready for a 1.1 release?

2004-10-25 Thread Henri Yandell
I hadn't realised we were this close to a 1.1, but I'm +1 for a release. 

I just moved WildcardUtils up a directory as it's used by two
different subpackages of IO.

There are a couple of options on the finder code which are not
implemented yet (time ones I think).

Is there any reason for the IOTestSuite class? It doesn't seem
necessary with Maven and seems unlikely to be needed by the generated
Maven build.xml (which we need to make sure we redo).

Hen

On Sun, 24 Oct 2004 20:15:41 -0700, Martin Cooper <[EMAIL PROTECTED]> wrote:
> There have been a lot of changes since IO 1.0 was released, and I'm
> thinking we're in pretty good shape for a 1.1 release in the near
> future.
> 
> I've worked through the bug reports, and got us down to four
> outstanding change requests, as follows:
> 
> Bugs:
> #29140 - NPE in FileUtils.listFiles(dir, extensions, recursive)
> #30974 - problem with copyFileToDirectory(File, File)
> 
> Enhancements:
> #28977 - [io] ProxyOutputStream: no need to define proxy
> #30667 - [io] new throttled input and output stream classes
> 
> With respect to the bugs, I have been unable to reproduce #29140 and
> have requested a test case to nail it down. I suspect #30974 is the
> infamous timing issue that I'm not clear that there's a good solution
> for, unfortunately.
> 
> With respect to the enhancements, they're not my particular itches,
> and I'd be more comfortable with someone else reviewing them (or
> flagging them for later). However, I'm willing to apply the changes
> for #30667 if I get a green light from another IO committer who's
> reviewed them.
> 
> So what do folks think? I'm willing to act as RM, unless someone else
> feels like rolling the release.
> 
> --
> Martin Cooper
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/io/src/java/org/apache/commons/io/filefilter ConditionalFileFilter.java WildcardFilter.java AndFileFilter.java OrFileFilter.java

2004-10-25 Thread scolebourne
scolebourne2004/10/25 15:53:27

  Modified:io/src/java/org/apache/commons/io/filefilter
ConditionalFileFilter.java WildcardFilter.java
AndFileFilter.java OrFileFilter.java
  Log:
  Fix formatting to four spaces
  
  Revision  ChangesPath
  1.2   +34 -34
jakarta-commons/io/src/java/org/apache/commons/io/filefilter/ConditionalFileFilter.java
  
  Index: ConditionalFileFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/filefilter/ConditionalFileFilter.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ConditionalFileFilter.java24 Oct 2004 21:58:44 -  1.1
  +++ ConditionalFileFilter.java25 Oct 2004 22:53:26 -  1.2
  @@ -23,40 +23,40 @@
* @since Commons IO 1.0
* @version $Revision$ $Date$
*
  - * @author  Steven Caswell
  + * @author Steven Caswell
*/
  -public interface ConditionalFileFilter
  -{
  -  /**
  -   * Adds the specified file filter to the list of file filters at the end of
  -   * the list.
  -   *
  -   * @param ioFileFilter the filter to be added
  -   */
  -  public void addFileFilter(IOFileFilter ioFileFilter);
  +public interface ConditionalFileFilter {
   
  -  /**
  -   * Returns this conditional file filter's list of file filters.
  -   *
  -   * @return the file filter list
  -   */
  -  public List getFileFilters();
  -  
  -  /**
  -   * Removes the specified file filter.
  -   *
  -   * @param ioFileFilter filter to be removed
  -   * @return true if the filter was found in the list,
  -   * false otherwise
  -   */
  -  public boolean removeFileFilter(IOFileFilter ioFileFilter);
  +/**
  + * Adds the specified file filter to the list of file filters at the end of
  + * the list.
  + *
  + * @param ioFileFilter the filter to be added
  + */
  +public void addFileFilter(IOFileFilter ioFileFilter);
  +
  +/**
  + * Returns this conditional file filter's list of file filters.
  + *
  + * @return the file filter list
  + */
  +public List getFileFilters();
  +
  +/**
  + * Removes the specified file filter.
  + *
  + * @param ioFileFilter filter to be removed
  + * @return true if the filter was found in the list,
  + * false otherwise
  + */
  +public boolean removeFileFilter(IOFileFilter ioFileFilter);
  +
  +/**
  + * Sets the list of file filters, replacing any previously configured
  + * file filters on this filter.
  + *
  + * @param fileFilters the list of filters
  + */
  +public void setFileFilters(List fileFilters);
   
  -  /**
  -   * Sets the list of file filters, replacing any previously configured
  -   * file filters on this filter.
  -   *
  -   * @param fileFilters the list of filters
  -   */
  -  public void setFileFilters(List fileFilters);
  -  
   }
  
  
  
  1.2   +84 -88
jakarta-commons/io/src/java/org/apache/commons/io/filefilter/WildcardFilter.java
  
  Index: WildcardFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/filefilter/WildcardFilter.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- WildcardFilter.java   22 Sep 2004 02:04:21 -  1.1
  +++ WildcardFilter.java   25 Oct 2004 22:53:26 -  1.2
  @@ -4,7 +4,6 @@
   import java.util.List;
   import org.apache.commons.io.find.WildcardUtils;
   
  -
   /**
* Filters files using supplied wildcard(s).
* 
  @@ -25,95 +24,92 @@
* @author Jason Anderson
*/
   public class WildcardFilter extends AbstractFileFilter {
  -  /** The wildcards that will be used to match filenames */
  -  private String[] wildcards = null;
  -
  -  /**
  -   * Construct a new wildcard filter for a single wildcard
  -   *
  -   * @param wildcard wildcard to match
  -   * @throws IllegalArgumentException if the pattern is null
  -   */
  -  public WildcardFilter(String wildcard) {
  -if (wildcard == null) {
  -  throw new java.lang.IllegalArgumentException();
  -}
   
  -wildcards = new String[] { wildcard };
  -  }
  +/** The wildcards that will be used to match filenames */
  +private String[] wildcards = null;
   
  -
  -  /**
  -   * Construct a new wildcard filter for an array of wildcards
  -   *
  -   * @param wildcards wildcards to match
  -   * @throws IllegalArgumentException if the pattern array is null
  -   */
  -  public WildcardFilter(String[] wildcards) {
  -if (wildcards == null) {
  -  throw new java.lang.IllegalArgumentException();
  +/**
  + * Construct a new wildcard filter for a single wildcard
  + *
  + * @param wildcard wildcard to match
  + * @throws IllegalArgumentException if the pattern is null
  + */
  +public 

Re: [vote] Oliver Heger as Committer

2004-10-25 Thread robert burrell donkin
On 25 Oct 2004, at 11:10, Eric Pugh wrote:

[X] Yes, bring him in!
[ ] Don't care
[ ] No
- robert
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: [email] Dumbster failing

2004-10-25 Thread Eric Pugh
Not a problem.  I appreciate your working with me on this.   I am looking
forward to getting [email] whipped into shape!

ERi

> -Original Message-
> From: Corey Scott [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 25, 2004 7:21 PM
> To: [EMAIL PROTECTED]
> Cc: Jakarta Commons Developers List
> Subject: Re: [email] Dumbster failing
>
>
> Ok, I have the tests all up and running with Maven.
>
> I have also made some minor mods, based on the tests or improving the
> input checking (this is why some of the tests are failing, there where
> against my changes not the HEAD version sorry)
>
> So once we get this formatting issue sorted, I will submit to you the
> new patch.  This should raise the test coverage to 90+% for all
> (non-deprecated) classes.
>
> Thanks,
> Corey


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JELLY-107) util:properties doesn't evaluate expressions

2004-10-25 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-107?page=comments#action_54630 ]
 
dion gillard commented on JELLY-107:


Some code currently relies on the properties not being evaluated.

We really need this to be controlled via a flag.

> util:properties doesn't evaluate expressions
> 
>
>  Key: JELLY-107
>  URL: http://issues.apache.org/jira/browse/JELLY-107
>  Project: jelly
> Type: Improvement
>   Components: taglib.util
> Reporter: Sean Timm
>  Attachments: PropertiesTagEvaluateExpression.diff
>
> The current implementation of util:properties has an @todo indicating that the 
> property values should be evaluated as expressions.  I've added the code necessary 
> to do so and will attach a patch shortly.  
> Note that I'm very unfamiliar with the Jelly source, so it's entirely possible that 
> I've done something wrong, but it appears to work, and the existing tests still pass 
> successfully.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JELLY-159) share base test classes with tag lib test builds

2004-10-25 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-159?page=comments#action_54629 ]
 
dion gillard commented on JELLY-159:


Maybe we will eventually need a jelly-test.jar which is shared across projects.

But for the time being I'm in favour of moving it into the core.

> share base test classes with tag lib test builds
> 
>
>  Key: JELLY-159
>  URL: http://issues.apache.org/jira/browse/JELLY-159
>  Project: jelly
> Type: Improvement
>   Components: core / taglib.core
> Versions: 1.0
> Reporter: Hans Gilde
> Priority: Minor

>
> Base test classes like BaseJellyTest aren't shareable, so we have several versions 
> of the same classes. I don't know if these classes should go in core or if the build 
> should be updated to share the core test clases.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JELLY-151) Refactor TagSupport.trimBody() to Script.trimWhitespace()

2004-10-25 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-151?page=history ]
 
dion gillard resolved JELLY-151:


 Resolution: Fixed
Fix Version: 1.0

Committed fix

> Refactor TagSupport.trimBody() to Script.trimWhitespace()
> -
>
>  Key: JELLY-151
>  URL: http://issues.apache.org/jira/browse/JELLY-151
>  Project: jelly
> Type: Improvement
>   Components: core / taglib.core
> Versions: 1.1-beta-1
> Reporter: Hans Gilde
>  Fix For: 1.0

>
> See comments in TagSupport.trimBody().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/jelly/src/java/org/apache/commons/jelly TagSupport.java

2004-10-25 Thread dion
dion2004/10/25 12:33:12

  Modified:jelly/src/java/org/apache/commons/jelly/impl
ScriptBlock.java CompositeTextScriptBlock.java
   jelly/src/java/org/apache/commons/jelly TagSupport.java
  Log:
  Fix for Jelly-151.
  
  Revision  ChangesPath
  1.16  +29 -1 
jakarta-commons/jelly/src/java/org/apache/commons/jelly/impl/ScriptBlock.java
  
  Index: ScriptBlock.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/jelly/src/java/org/apache/commons/jelly/impl/ScriptBlock.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- ScriptBlock.java  9 Sep 2004 12:26:22 -   1.15
  +++ ScriptBlock.java  25 Oct 2004 19:33:12 -  1.16
  @@ -35,9 +35,15 @@
   /** The list of scripts */
   private List list = new ArrayList();
   
  +/**
  + * Create a new instance.
  + */
   public ScriptBlock() {
   }
   
  +/**
  + * @see Object#toString()
  + */
   public String toString() {
   return super.toString() + "[scripts=" + list + "]";
   }
  @@ -87,6 +93,28 @@
   for (Iterator iter = list.iterator(); iter.hasNext(); ) {
   Script script = (Script) iter.next();
   script.run(context, output);
  +}
  +}
  +
  +/**
  + * Trim the body of the script.
  + * In this case, trim all elements, removing any that are empty text.
  + */
  +public void trimWhitespace() {
  +List list = getScriptList();
  +for ( int i = list.size() - 1; i >= 0; i-- ) {
  +Script script = (Script) list.get(i);
  +if ( script instanceof TextScript ) {
  +TextScript textScript = (TextScript) script;
  +String text = textScript.getText();
  +text = text.trim();
  +if ( text.length() == 0 ) {
  +list.remove(i);
  +}
  +else {
  +textScript.setText(text);
  +}
  +}
   }
   }
   }
  
  
  
  1.7   +34 -0 
jakarta-commons/jelly/src/java/org/apache/commons/jelly/impl/CompositeTextScriptBlock.java
  
  Index: CompositeTextScriptBlock.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/jelly/src/java/org/apache/commons/jelly/impl/CompositeTextScriptBlock.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- CompositeTextScriptBlock.java 9 Sep 2004 12:26:22 -   1.6
  +++ CompositeTextScriptBlock.java 25 Oct 2004 19:33:12 -  1.7
  @@ -15,6 +15,10 @@
*/
   package org.apache.commons.jelly.impl;
   
  +import java.util.List;
  +
  +import org.apache.commons.jelly.Script;
  +
   
   /**
* CompositeTextScriptBlock represents a text body of a
  @@ -26,6 +30,36 @@
*/
   public class CompositeTextScriptBlock extends ScriptBlock {
   
  +/**
  + * Create an instance.
  + */
   public CompositeTextScriptBlock() {
   }
  +
  +
  +/**
  + * Trim the body of the script.
  + * In this case, trim the whitespace from the start of the first element
  + * and from the end of the last element.
  + */
  +public void trimWhitespace() {
  +List list = getScriptList();
  +int size = list.size();
  +if ( size > 0 ) {
  +Script script = (Script) list.get(0);
  +if ( script instanceof TextScript ) {
  +TextScript textScript = (TextScript) script;
  +textScript.trimStartWhitespace();
  +}
  +if ( size > 1 ) {
  +script = (Script) list.get(size - 1);
  +if ( script instanceof TextScript ) {
  +TextScript textScript = (TextScript) script;
  +textScript.trimEndWhitespace();
  +}
  +}
  +}
  +}
  +
  +
   }
  
  
  
  1.34  +3 -36 
jakarta-commons/jelly/src/java/org/apache/commons/jelly/TagSupport.java
  
  Index: TagSupport.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/jelly/src/java/org/apache/commons/jelly/TagSupport.java,v
  retrieving revision 1.33
  retrieving revision 1.34
  diff -u -r1.33 -r1.34
  --- TagSupport.java   9 Sep 2004 12:25:40 -   1.33
  +++ TagSupport.java   25 Oct 2004 19:33:12 -  1.34
  @@ -19,7 +19,6 @@
   import java.util.Arrays;
   import java.util.Collection;
   import java.util.Iterator;
  -import java.util.List;
   
   import org.apache.commons.jelly.impl.CompositeTextScriptBlock;
   import org.apache.commons.jelly.impl.ScriptBlock;
  @@ -245,46 +244,14 @@
*/
   protected void trimBody() {
   synchronized(body) {
  -//  should refactor this code

DO NOT REPLY [Bug 31884] New: - FileUtils.toFile() drops drive letter on windows

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31884

FileUtils.toFile() drops drive letter on windows

   Summary: FileUtils.toFile() drops drive letter on windows
   Product: Commons
   Version: 1.0 Alpha
  Platform: Macintosh
OS/Version: Windows NT/2K
Status: NEW
  Severity: Major
  Priority: Other
 Component: IO
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Using 1.0 release, downloaded from ibiblio

This test will fail for me:

public void testCommonsIOBug() throws Exception {
final File fileBefore = new File("Z:\\test");
System.out.println("Before: " + fileBefore);
final URL fileURL = new URL("file://" + fileBefore.getAbsolutePath());
System.out.println("In URL: " + fileURL);
final File fileAfter = FileUtils.toFile(fileURL);
System.out.println("After: " + fileAfter);
assertEquals(fileBefore.getAbsolutePath(), fileAfter.getAbsolutePath());
}

The output for me is:

Before: Z:\test
In URL: file://Z:/test
After: \test

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@brutus]: Project commons-primitives (in module jakarta-commons) success

2004-10-25 Thread Gump
To whom it may satisfy...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-primitives *no longer* has an issue.
The current state of this project is 'Success'.

Full details are available at:
http://brutus.apache.org/gump/public/jakarta-commons/commons-primitives/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were provided:
 -DEBUG- Sole output [commons-primitives-1.1-dev.jar] identifier set to project name
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/build.properties
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/project.properties
 -INFO- No license on redistributable project with outputs.



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-commons/commons-primitives/gump_work/build_jakarta-commons_commons-primitives.html
Work Name: build_jakarta-commons_commons-primitives (Type: Build)
Work ended in a state of : Success
Elapsed: 13 secs
Command Line: maven --offline jar 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons/primitives]
CLASSPATH : 
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/primitives/target/classes:/usr/local/gump/public/workspace/jakarta-commons/primitives/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-testframework-25102004.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
 __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0

Plugin 'maven-deploy-plugin' in project 'Commons Primitives' is not available
build:start:

java:prepare-filesystem:
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/classes

java:compile:
[echo] Compiling to 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/classes
[javac] Compiling 270 source files to 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/classes

java:jar-resources:

test:prepare-filesystem:
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/test-classes
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/test-reports

test:test-resources:

test:compile:
[javac] Compiling 187 source files to 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/test-classes

test:test:
[junit] Running org.apache.commons.collections.primitives.AllTestSuite
[junit] Tests run: 4433, Failures: 0, Errors: 0, Time elapsed: 3.576 sec

jar:jar:
[jar] Building jar: 
/usr/local/gump/public/workspace/jakarta-commons/primitives/target/commons-primitives-1.1-dev.jar
BUILD SUCCESSFUL
Total time: 13 seconds
Finished at: Mon Oct 25 10:39:23 PDT 2004

-

To subscribe to this information via syndicated feeds:
- RSS: http://brutus.apache.org/gump/public/jakarta-commons/commons-primitives/rss.xml
- Atom: 
http://brutus.apache.org/gump/public/jakarta-commons/commons-primitives/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.1.0-alpha-0003.
Gump Run 14000925102004, brutus:brutus-public:14000925102004
Gump E-mail Identifier (unique within run) #3.

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (JELLY-138) character data flushed XMLOuput while XML data doesn't

2004-10-25 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-138?page=history ]

dion gillard updated JELLY-138:
---

Attachment: jelly-138-tests.txt

Tests from the original problem file, updated to fit in Jelly source hierarchy

> character data flushed XMLOuput while XML data doesn't
> --
>
>  Key: JELLY-138
>  URL: http://issues.apache.org/jira/browse/JELLY-138
>  Project: jelly
> Type: Bug
>   Components: core / taglib.core
> Versions: 1.0-beta-5
> Reporter: Hans Gilde
>  Attachments: jelly-138-tests.txt, jelly-138.txt, xml-output-problem.zip
>
> An XML tag that isn't mapped via a tag library is output to the XMLOutput. 
> Similarly, non XML text is output to the XMLOutput.
> It seems that the XMLOutput will be auto-flushed after the character data but not 
> after the XML data.
> The question is, should they both auto-flush or neither?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30855] - [lang] Additional constructor for EqualsBuilder and isEquals member access.

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30855

[lang] Additional constructor for EqualsBuilder and isEquals member access.





--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 17:25 ---
Ari, 

Eventhough we both agree, the best to push this forward in (maybe) 2.1 or 2.2
would be for you to provide a patch for the class and the unit test. 

Thanks. Gary.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@brutus]: Project commons-jux (in module jakarta-commons-sandbox) success

2004-10-25 Thread commons-jux development team
To whom it may satisfy...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jux *no longer* has an issue.
The current state of this project is 'Success'.

Full details are available at:
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-jux/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were provided:
 -DEBUG- Sole output [commons-jux-1.0-dev.jar] identifier set to project name
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes]
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/test-classes]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/build.properties
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/project.properties
 -INFO- No license on redistributable project with outputs.



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-jux/gump_work/build_jakarta-commons-sandbox_commons-jux.html
Work Name: build_jakarta-commons-sandbox_commons-jux (Type: Build)
Work ended in a state of : Success
Elapsed: 6 secs
Command Line: maven --offline jar 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons-sandbox/jux]
CLASSPATH : 
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes:/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
 __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0

Plugin 'maven-deploy-plugin' in project 'commons-jux' is not available
build:start:

java:prepare-filesystem:

java:compile:
[echo] Compiling to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes
[javac] Compiling 1 source file to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes

java:jar-resources:
Copying 3 files to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes
Copying 1 file to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes/META-INF

test:prepare-filesystem:
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/test-reports

test:test-resources:

test:compile:
[javac] Compiling 3 source files to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/test-classes
[copy] Copying 1 file to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/classes

test:test:
[junit] Running org.apache.commons.jux.TestAll
[junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.414 sec

jar:jar:
[jar] Building jar: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/jux/target/commons-jux-1.0-dev.jar
BUILD SUCCESSFUL
Total time: 5 seconds
Finished at: Mon Oct 25 10:20:02 PDT 2004

-

To subscribe to this information via syndicated feeds:
- RSS: http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-jux/rss.xml
- Atom: 
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-jux/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.1.0-alpha-0003.
Gump Run 14000925102004, brutus:brutus-public:14000925102004
Gump E-mail Identifier (unique within run) #2.

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [email] Dumbster failing

2004-10-25 Thread Corey Scott
Ok, I have the tests all up and running with Maven.

I have also made some minor mods, based on the tests or improving the
input checking (this is why some of the tests are failing, there where
against my changes not the HEAD version sorry)

So once we get this formatting issue sorted, I will submit to you the
new patch.  This should raise the test coverage to 90+% for all
(non-deprecated) classes.

Thanks,
Corey

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[Jakarta Commons Wiki] Updated: Lang

2004-10-25 Thread commons-dev
   Date: 2004-10-25T10:19:04
   Editor: GaryGregory <[EMAIL PROTECTED]>
   Wiki: Jakarta Commons Wiki
   Page: Lang
   URL: http://wiki.apache.org/jakarta-commons/Lang

   no comment

Change Log:

--
@@ -15,7 +15,6 @@
  Development plan for 2.1 
 
  1. [http://issues.apache.org/bugzilla/show_bug.cgi?id=30855 30855] Extra 
constructor for EqualsBuilder.
- 1. [http://issues.apache.org/bugzilla/show_bug.cgi?id=30929 30929] Bug in 
Nestable.indexOfThrowable? - '''Should we do? - switch from equals() to 
isAssignableFrom()'''
 
  Seeking opinions 
 
@@ -50,6 +49,7 @@
 
 === Resolved list ===
 
+ 1. [http://issues.apache.org/bugzilla/show_bug.cgi?id=30929 30929] [lang] 
Nestable.indexOfThrowable(Class)uses Class.equals() to match - '''DONE'''
  1. [http://issues.apache.org/bugzilla/show_bug.cgi?id=27592 27592][lang] 
WordUtils capitalize improvement - '''DONE'''
  1. [http://issues.apache.org/bugzilla/show_bug.cgi?id=23557 23557]
WordUtils.capitalizeFully(String str) should take a delimiter - '''DONE'''
  1. [http://issues.apache.org/bugzilla/show_bug.cgi?id=27778 27778][lang] add 
remove methods to ArrayUtils - '''DONE'''

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30929] - [lang] Nestable.indexOfThrowable(Class) uses Class.equals() to match

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30929

[lang] Nestable.indexOfThrowable(Class) uses Class.equals() to match

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|[lang]  |[lang]
   |Nestable.indexOfThrowable(Cl|Nestable.indexOfThrowable(Cl
   |ass)  uses Class.equals() to|ass) uses Class.equals() to
   |match   |match

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31881] - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes





--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 17:18 ---
I checkout against the HEAD and then applied the changes.

I didnt use the Sun style, I used the Turbine style as stated in the previous 
message.  I also have attached to this bug a style document for checkstyle for 
the Turbine standard.  There should only be about 20 odd violations, I am 
happy to change these as well but some changes will amount to 'refactoring' 
small chunks of code.  
There is one that concerns the amount of params to a method (max 7 says the 
checker), I am not sure what to do about this.
There is another that is a line longer than 80 chars, this one I cant find 
anyway to reformat as its a CVS header (i think)

Please let me know what more you would like to do to get us to where we need 
to be.  Thanks

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (JELLY-138) character data flushed XMLOuput while XML data doesn't

2004-10-25 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-138?page=history ]

dion gillard updated JELLY-138:
---

Attachment: jelly-138.txt

Patch for TagScript to fix the issue if we decide to go ahead with it.

> character data flushed XMLOuput while XML data doesn't
> --
>
>  Key: JELLY-138
>  URL: http://issues.apache.org/jira/browse/JELLY-138
>  Project: jelly
> Type: Bug
>   Components: core / taglib.core
> Versions: 1.0-beta-5
> Reporter: Hans Gilde
>  Attachments: jelly-138.txt, xml-output-problem.zip
>
> An XML tag that isn't mapped via a tag library is output to the XMLOutput. 
> Similarly, non XML text is output to the XMLOutput.
> It seems that the XMLOutput will be auto-flushed after the character data but not 
> after the XML data.
> The question is, should they both auto-flush or neither?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [vote] Oliver Heger as Committer

2004-10-25 Thread Dirk Verbeeck
+1
Eric Pugh wrote:
Hi all,
I would like to nominate Oliver Heger as a committer to Jakarta Commons.
Oliver has been very active in the [configuration] project[1], and I feel
gets the "Jakarta way".  He has partipated in doing a lot of the icky bug
finding and fixing in [configuration] and will be an asset in designing the
next version of [configuration].
A bit about him:
I was born in 1973 in Germany. I have a diploma in computer science. From
1999 to 2003 I worked as a developer for a small software company. My main
area of work were internet applications based on the J2EE platform. Since
December 2004 I work for the University of Marburg, Germany in the Institute
of Medical Informatics and for the university hospital.
[ ] Yes, bring him in!
[ ] Don't care
[ ] No
Eric
[1]
http://nagoya.apache.org/eyebrowse/SearchList?listId=&listName=commons-dev%4
0jakarta.apache.org&searchText=oliver+heger&defaultField=sender&Search=Searc
h
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


[GUMP@brutus]: Project commons-functor (in module jakarta-commons-sandbox) success

2004-10-25 Thread commons-functor development team
To whom it may satisfy...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-functor *no longer* has an issue.
The current state of this project is 'Success'.

Full details are available at:

http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-functor/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were provided:
 -DEBUG- Sole output [commons-functor-1.0-dev.jar] identifier set to project name
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/classes]
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/test-classes]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/build.properties
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/project.properties
 -INFO- No license on redistributable project with outputs.



The following work was performed:
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-functor/gump_work/build_jakarta-commons-sandbox_commons-functor.html
Work Name: build_jakarta-commons-sandbox_commons-functor (Type: Build)
Work ended in a state of : Success
Elapsed: 37 secs
Command Line: maven --offline jar 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons-sandbox/functor]
CLASSPATH : 
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/classes:/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/test-classes:/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/src/test:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
 __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0

Plugin 'maven-deploy-plugin' in project 'Commons Functor' is not available
build:start:

java:prepare-filesystem:

java:compile:
[echo] Compiling to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/classes
[javac] Compiling 115 source files to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/classes

java:jar-resources:
Copying 4 files to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/classes
Copying 1 file to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/classes/META-INF

test:prepare-filesystem:
[mkdir] Created dir: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/test-reports

test:test-resources:
Copying 156 files to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/test-classes

test:compile:
[javac] Compiling 154 source files to 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/test-classes
Note: Some input files use or override a deprecated API.
Note: Recompile with -deprecation for details.

test:test:
[junit] Running org.apache.commons.functor.TestAll
[junit] Tests run: 792, Failures: 0, Errors: 0, Time elapsed: 3.201 sec

jar:jar:
[jar] Building jar: 
/usr/local/gump/public/workspace/jakarta-commons-sandbox/functor/target/commons-functor-1.0-dev.jar
BUILD SUCCESSFUL
Total time: 36 seconds
Finished at: Mon Oct 25 09:56:24 PDT 2004

-

To subscribe to this information via syndicated feeds:
- RSS: 
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-functor/rss.xml
- Atom: 
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-functor/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.1.0-alpha-0003.
Gump Run 14000925102004, brutus:brutus-public:14000925102004
Gump E-mail Identifier (unique within run) #1.

--
Apache Gump
http://gump.apache.org/ [Instance: brutus]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [configuration] Any reason why JNDIConfiguration is readonly?

2004-10-25 Thread Emmanuel Bourg
Eric Pugh wrote:
Well..  I started on the bind/rebind stuff.  and am having a really hard
time of it...
I can bind a property like this "newprop" just fine..  However, a property
like "my.newprop" fails..  I think I need to crawl the tree and find the
correct context and then set that...  argh..
That's most likely the solution, and using Context.createSubcontext() if 
necessary.

I don't just want to save in a temporary storage because I want to be able
to persist via JNDI configuration changes.
I agree, a full JNDI implementation would be better.
Good luck :)
Emmanuel Bourg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


[Jakarta Commons Wiki] Updated: AutoDiscoveryHallOfShame

2004-10-25 Thread commons-dev
   Date: 2004-10-25T09:34:59
   Editor: BradNeuberg <[EMAIL PROTECTED]>
   Wiki: Jakarta Commons Wiki
   Page: AutoDiscoveryHallOfShame
   URL: http://wiki.apache.org/jakarta-commons/AutoDiscoveryHallOfShame

   Updated TypePad and MoveableType RSS Formats and Autodiscovery Support

Change Log:

--
@@ -11,12 +11,12 @@
 ||iBlog||YES||'''NO'''||RSS 0.92||rss.xml||10-22-04||
 ||LiveJournal||YES||'''NO'''||Atom 0.3, RSS 2.0||data/atom, data/rss||10-22-04||
 ||Manila||YES||'''NO'''||RSS 2.0||xml/rss.xml, rss.xml||10-22-04||
-||MovableType||YES||YES||RSS 1.0||index.rdf||10-22-04||
+||MovableType||YES||YES||RSS 1.0, RSS 2.0, Atom 0.3||index.rdf||10-25-04||
 ||PMachine||YES||'''NO'''||RSS 0.91||index.xml||10-22-04||
 ||RadioUserland||YES||'''NO'''||RSS 2.0||rss.xml||10-22-04||
 ||TextAmerica||YES||'''KIND OF'''[[FootNote(They have autodiscover links in their 
template, but they point to the wrong location!)]]||RSS 2.0||rss.aspx||10-22-04||
 ||TextPattern||YES||'''NO'''||Atom 0.3, RSS 0.92||?atom=1, ?rss=1||10-22-04||
-||TypePad||YES||'''NO'''||Atom 0.3, RSS 1.0||atom.xml, index.rdf||10-22-04||
+||TypePad||YES||YES||Atom 0.3, RSS 1.0||atom.xml, index.rdf||10-25-04||
 ||WordPress||YES||YES||Atom 0.3, RSS 0.92, RSS 2.0||wp-atom.php, wp-rss2.php, 
wp-rss.php||10-22-04||
 ||Xanga||YES||'''NO'''||RSS 0.91||Complicated[[FootNote(Xanga builds its link to an 
RSS feed from the user's ID.  For example, if you are at 
http://www.xanga.com/home.aspx?user=wdfphillz, where the user is wdfphillz, then the 
RSS feed would be at http://www.xanga.com/rss.aspx?user=wdfphillz)]]||10-22-04||
 ||Yahoo Groups||YES||'''NO'''||RSS 2.0||rss||10-22-04||

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31881] - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes





--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 16:34 ---
Okay, I committed what applied.   From 800 and some odd errors to 300 and some odd!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [configuration] Any reason why JNDIConfiguration is readonly?

2004-10-25 Thread Eric Pugh
Well..  I started on the bind/rebind stuff.  and am having a really hard
time of it...

I can bind a property like this "newprop" just fine..  However, a property
like "my.newprop" fails..  I think I need to crawl the tree and find the
correct context and then set that...  argh..

I don't just want to save in a temporary storage because I want to be able
to persist via JNDI configuration changes.

Eric

> -Original Message-
> From: Emmanuel Bourg [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 25, 2004 5:54 PM
> To: Jakarta Commons Developers List
> Subject: Re: [configuration] Any reason why JNDIConfiguration is
> readonly?
>
>
> Eric Pugh wrote:
> > Anyone have a good reason whe JNDIConfiguration doesn't support setting
> > properties?  I was thinking of going for just a simple string storing of
> > properties, not binding in Datasources or anything funky like that...
> >
> > Eric
>
> How to you plan to implement this ? By playing with the
> bind/rebind/unbind functions of the Context interface, or by storing the
> new properties into a Map ?
>
> Emmanuel Bourg
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 31881] - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes





--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 16:24 ---
also, not sure you did it quite against CVS HEAD.  Most applies, but not all!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31881] - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 16:22 ---
I just want to reconfirm that this is the standard "sun" format?  And, have you
tried to run the checkstyle report?  I just reactivated it..  It should report
no results too...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/email project.xml

2004-10-25 Thread epugh
epugh   2004/10/25 09:19:02

  Modified:emailproject.xml
  Log:
  add checkstyle back in.
  
  Revision  ChangesPath
  1.18  +1 -1  jakarta-commons-sandbox/email/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-commons-sandbox/email/project.xml,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- project.xml   24 Oct 2004 18:02:00 -  1.17
  +++ project.xml   25 Oct 2004 16:19:01 -  1.18
  @@ -125,7 +125,7 @@
 
maven-changelog-plugin
maven-changes-plugin
  - 
  + maven-checkstyle-plugin

maven-developer-activity-plugin
maven-file-activity-plugin
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [configuration] Any reason why JNDIConfiguration is readonly?

2004-10-25 Thread Emmanuel Bourg
Eric Pugh wrote:
Anyone have a good reason whe JNDIConfiguration doesn't support setting
properties?  I was thinking of going for just a simple string storing of
properties, not binding in Datasources or anything funky like that...
Eric
How to you plan to implement this ? By playing with the 
bind/rebind/unbind functions of the Context interface, or by storing the 
new properties into a Map ?

Emmanuel Bourg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Henning P. Schmiedehausen
"Eric Pugh" <[EMAIL PROTECTED]> writes:

>I'd actually like to keep them off of the classpath (src/test/resouces)
>because many of the file don't go in the classpath, they are meant to be
>read off the filesystem.  I think it is simpler to either just copy the ones
>to the classpath that need it, or take the approach that if they are
>supposed to be in the classpath, then put them in /src/test to begin with!

That is not what I meant. What I would like to see is that "all unit
testing code is under src/test". We had our share of clutter in
turbine with src/rttest src/test-cactus and in some other projects it
is even worse.

I simply see no reason why we should get another directory with
src/test-resources. And having a single directory that can be used for
both things (load from classpath and load from file system) is even
better, because we neither have to add another dir to the classpath
nor do we need two directories.

Regards
Henning


>Eric

>> -Original Message-
>> From: Henning P. Schmiedehausen [mailto:[EMAIL PROTECTED]
>> Sent: Monday, October 25, 2004 4:29 PM
>> To: [EMAIL PROTECTED]
>> Subject: Re: [configuration] Moving test resources to
>> /src/test-resources
>>
>>
>> "Eric Pugh" <[EMAIL PROTECTED]> writes:
>>
>> >By making this change we explicity list our test resources, they are in
>> >/src/test-resources.
>>
>> BTW: I would very much prefer "src/test/resources" or
>> "src/test/conf". With "src/test" being on the classpath anyway,
>> the latter might even work without any changes.
>>
>>  Regards
>>  Henning
>>
>> --
>> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen  INTERMETA GmbH
>> [EMAIL PROTECTED]+49 9131 50 654 0   http://www.intermeta.de/
>>
>> RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
>>Linux, Java, perl, Solaris -- Consulting, Training, Development
>>
>> "Fighting for one's political stand is an honorable action, but re-
>>  fusing to acknowledge that there might be weaknesses in one's
>>  position - in order to identify them so that they can be remedied -
>>  is a large enough problem with the Open Source movement that it
>>  deserves to be on this list of the top five problems."
>>-- Michelle Levesque, "Fundamental Issues with
>> Open Source Software Development"
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]


>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen  INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
   -- Michelle Levesque, "Fundamental Issues with
Open Source Software Development"

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [vote] Oliver Heger as Committer

2004-10-25 Thread Noel J. Bergman
+1

--- Noel

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Eric Pugh
I'd actually like to keep them off of the classpath (src/test/resouces)
because many of the file don't go in the classpath, they are meant to be
read off the filesystem.  I think it is simpler to either just copy the ones
to the classpath that need it, or take the approach that if they are
supposed to be in the classpath, then put them in /src/test to begin with!

Eric

> -Original Message-
> From: Henning P. Schmiedehausen [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 25, 2004 4:29 PM
> To: [EMAIL PROTECTED]
> Subject: Re: [configuration] Moving test resources to
> /src/test-resources
>
>
> "Eric Pugh" <[EMAIL PROTECTED]> writes:
>
> >By making this change we explicity list our test resources, they are in
> >/src/test-resources.
>
> BTW: I would very much prefer "src/test/resources" or
> "src/test/conf". With "src/test" being on the classpath anyway,
> the latter might even work without any changes.
>
>   Regards
>   Henning
>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen  INTERMETA GmbH
> [EMAIL PROTECTED]+49 9131 50 654 0   http://www.intermeta.de/
>
> RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
>Linux, Java, perl, Solaris -- Consulting, Training, Development
>
> "Fighting for one's political stand is an honorable action, but re-
>  fusing to acknowledge that there might be weaknesses in one's
>  position - in order to identify them so that they can be remedied -
>  is a large enough problem with the Open Source movement that it
>  deserves to be on this list of the top five problems."
>-- Michelle Levesque, "Fundamental Issues with
> Open Source Software Development"
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[configuration] Any reason why JNDIConfiguration is readonly?

2004-10-25 Thread Eric Pugh
Anyone have a good reason whe JNDIConfiguration doesn't support setting
properties?  I was thinking of going for just a simple string storing of
properties, not binding in Datasources or anything funky like that...

Eric


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31881] - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes





--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 15:21 ---
Created an attachment (id=13215)
Incase anyone else uses eclipse and wants the style file (and doesnt already have one, 
here it is)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31881] - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes





--- Additional Comments From [EMAIL PROTECTED]  2004-10-25 15:19 ---
Created an attachment (id=13214)
style only changes (deprecated class have been ignored)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31881] New: - [email] Style only changes

2004-10-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31881

[email] Style only changes

   Summary: [email] Style only changes
   Product: Commons
   Version: 1.0 Alpha
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Sandbox
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


There were inconsistencies in the style (a lot caused by my unit 
tests...sorry).  All changes provided are style only no functionality changes.

The style applied is Turbine (as much as possible)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Henning P. Schmiedehausen
"Eric Pugh" <[EMAIL PROTECTED]> writes:

>By making this change we explicity list our test resources, they are in
>/src/test-resources.

BTW: I would very much prefer "src/test/resources" or
"src/test/conf". With "src/test" being on the classpath anyway,
the latter might even work without any changes.

Regards
Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen  INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
   -- Michelle Levesque, "Fundamental Issues with
Open Source Software Development"

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Emmanuel Bourg
Eric Pugh wrote:
That is one reason..   The problem became apparent when putting some new
features into the Eclipse plugin for Maven. [1]  We'll be making it
backwards compatilbe in order not to break a project like [configuration].
but more to the point, the /conf directory has become huge, with a mix, well
okay, mostly, test resources, plus a config file or two.
By making this change we explicity list our test resources, they are in
/src/test-resources.
At this point, I have everything working, so I just am trying to build
consensus that this is good.  I personally think that it sorts things out
better.
I'm ok for the move, that will make the source tree a bit cleaner. This 
shoud leave only checkstyle.xml and HEADER.txt in /conf.

Emmanuel Bourg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-commons/configuration/xdocs overview.xml

2004-10-25 Thread ebourg
ebourg  2004/10/25 07:12:02

  Modified:configuration/xdocs overview.xml
  Log:
  documentation update:
  - removed the references to the unit tests, this is discouraging for new users
  - more examples
  - replaced "digester file" by "configuration descriptor" since digester is just an 
implementation detail
  
  Revision  ChangesPath
  1.7   +70 -54jakarta-commons/configuration/xdocs/overview.xml
  
  Index: overview.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/overview.xml,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- overview.xml  22 Oct 2004 01:40:48 -  1.6
  +++ overview.xml  25 Oct 2004 14:12:02 -  1.7
  @@ -1,25 +1,25 @@
   
   
   
  -
  - 
  -  Configuration Overview
  -  Eric Pugh
  - 
  -
  -
  +  
  +Configuration Overview
  +Eric Pugh
  +Emmanuel Bourg
  +  
  +  
   
   
 
  -The best way to learn how to use Configuration is to look at the various 
testcases
  -that it comes with.  This will demonstrate how a Configuration object is 
populated
  -from multiple different sources.
  +One of the strength of Commons Configuration is its ability to mix 
configurations
  +from heterogeneous sources, this section will introduce you to the 
different configurations
  +available and will show you how to combine them.
 
  +
 
 
  -Currently there are quite a number of different sources of Configuration 
objects.  But,
  +Currently there are quite a number of different sources of Configuration 
objects. But,
   by just using a Configuration object versus a specific type like 
XMLConfiguration or
  -JNDIConfiguration, you are sheltered from the mechanics of actually 
retrieving the 
  +JNDIConfiguration, you are sheltered from the mechanics of actually 
retrieving the
   configuration values. These various sources include:
   
 
  @@ -39,61 +39,74 @@
 Using a key in the JNDI tree, can retrieve values as configuration 
properties.
 
 
  +  SystemConfiguration
  +  A configuration using the system properties
  +  
  +  
 ConfigurationConverter
 Takes a java.util.Properties or an 
o.a.c.collections.ExtendedProperties
 and converts it to a Configuration object.
 
  
  -
  +
 
 
  +
 
 
  -Often you want to provide a base set of configuration values, but allow the 
user to easily 
  +Often you want to provide a base set of configuration values, but allow the 
user to easily
   override them for their specific environment.  Well one way is to hard code 
the default
   values into your code, and have then provide a property file that overrides 
this.  However,
  -this is a very rigid way of doing things.  Instead, with the 
CompositeConfiguration you can
  -provide many different ways of setting up a configuration.  You can either 
do it manually (see
  -JUnit testcase "TestCompositeConfiguration.java", or via the 
ConfigurationFactory class.
  +this is a very rigid way of doing things. Instead, with the 
CompositeConfiguration
  +you can provide many different ways of setting up a configuration. You can 
either do it
  +manually:
 
  +
  +
  +CompositeConfiguration config = new CompositeConfiguration();
  +config.addConfiguration(new SystemConfiguration());
  +config.addConfiguration(new PropertiesConfiguration("application.properties"));
  +
  +
  +  or via the ConfigurationFactory class:
  +
  +
  +ConfigurationFactory factory = new ConfigurationFactory("config.xml");
  +Configuration config = factory.getConfiguration();
  +
  +
 
  -Using the ConfigurationFactory, (see the Junit testcase 
"TestConfigurationFactory.java") you load
  -up a digester xml file that specifies how to load up all the Configuration 
objects.  Here is 
  -a sample one using the default digesterRules.xml file:
  +The config.xml file used in the example above is a 
configuration descriptor,
  +it specifies the Configuration objects to load. Here is an example of 
descriptor:
 
   
  -  
   
 
  -What this says is that we are loading up all JNDI values under 
java:comp/env key, as well 
  -as a properties file in conf/test.properties as well as a XML file in 
conf/test.xml.
  -Please inspect the test cases and the files in the conf/ directory for more 
information on how
  -to structure your configuration xml file..
  -  
  -  
  -The order of precedence is first to last.  So in the above example, if 
there was a JNDI key

RE: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Eric Pugh
That is one reason..   The problem became apparent when putting some new
features into the Eclipse plugin for Maven. [1]  We'll be making it
backwards compatilbe in order not to break a project like [configuration].
but more to the point, the /conf directory has become huge, with a mix, well
okay, mostly, test resources, plus a config file or two.

By making this change we explicity list our test resources, they are in
/src/test-resources.

At this point, I have everything working, so I just am trying to build
consensus that this is good.  I personally think that it sorts things out
better.

Eric




[1]
http://nagoya.apache.org/eyebrowse/[EMAIL PROTECTED]&
by=thread&from=913802

> -Original Message-
> From: Emmanuel Bourg [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 25, 2004 3:31 PM
> To: Jakarta Commons Developers List
> Subject: Re: [configuration] Moving test resources to
> /src/test-resources
>
>
> I'm not sure to understand the issue, why do you need to import /conf in
> your classpath ? That's for running the unit tests directly from Eclipse ?
>
> Emmanuel Bourg
>
>
> Eric Pugh wrote:
> > Hi all,
> >
> > I am using the updated Maven Eclipse plugin, and one of the difficulties
> > that arises is that Eclipse (and therefore Maven) want each
> directory, if
> > included as resources on Eclipse's classpath, to be different.
> Right now,
> > in configuration we include the /conf directory a ton of times.
> >
> > What I want to do is bring [configuration] into line with other
> mavenenized
> > projects where test resources are all in /src/test-resources.
> And the jar
> > resources would remain in /conf.  Basically just digesterRules.xml.
> >
> > However, when I started this, I ran into a couple unit test failures.
> > Should I do this, and then fix the errors?  I have a bunch of questions
> > about some of the new tests that would be better answered if I
> could commit
> > the changes...
> >
> > Eric
> >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/configuration/xdocs navigation.xml

2004-10-25 Thread ebourg
ebourg  2004/10/25 06:57:29

  Modified:configuration/xdocs navigation.xml
  Log:
  menu update:
  - renamed "Overview" into "Using Configuration"
  - renamed "Simple Howto" into "Properties Howto"
  - added a download link
  - added a CVS link
  
  Revision  ChangesPath
  1.11  +4 -2  jakarta-commons/configuration/xdocs/navigation.xml
  
  Index: navigation.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/navigation.xml,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- navigation.xml22 Sep 2004 11:57:28 -  1.10
  +++ navigation.xml25 Oct 2004 13:57:29 -  1.11
  @@ -14,14 +14,16 @@
   

   
  -  
  -  
  +  http://jakarta.apache.org/site/sourceindex.cgi#commons-configuration"/>  
  +  
  +  
   
 
 
 
 
 
  +  http://cvs.apache.org/viewcvs/jakarta-commons/configuration/"/>
   
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/configuration/xdocs howto_properties.xml

2004-10-25 Thread ebourg
ebourg  2004/10/25 06:55:45

  Modified:configuration/xdocs howto_properties.xml
  Log:
  properties howto revamp
  
  Revision  ChangesPath
  1.3   +168 -39   jakarta-commons/configuration/xdocs/howto_properties.xml
  
  Index: howto_properties.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/howto_properties.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- howto_properties.xml  22 Oct 2004 01:40:48 -  1.2
  +++ howto_properties.xml  25 Oct 2004 13:55:45 -  1.3
  @@ -1,45 +1,174 @@
   
   
   
  +  
  +Properties files
  +Emmanuel Bourg
  +Oliver Heger
  +  
   
  - 
  -  Configuration Examples
  -  Oliver Heger
  - 
  -
  -
  -
  -
  - 
  - This section contains some very simple examples of configuration
  - files and demonstrates how the properties defined there can be
  - read from Java code.
  - 
  - 
  - 
  - At first lets consider that the whole configuration data of an
  - application consists of a single properties file named 
  - usergui.properties with the following content:
  - 
  - 
  +
  +
  +  To load this file, you'll write:
  +
  +
  +Configuration config = new PropertiesConfiguration("usergui.properties");
  +
  +
  +  If you do not specify an absolute path, the file will be searched 
automatically
  +  in the following locations:
  +  
  +in the current directory
  +in the user home directory
  +in the classpath
  +  
  +
  +  
  +
  +  
  +
  +  If a property is named "include" and the value of that 
property is the
  +  name of a file on the disk, that file will be included into the 
configuration. Here is
  +  an example:
  +
  +
  +# usergui.properties
  +
  +include = colors.properties
  +include = sizes.properties
  +
  +
  +
  +# colors.properties
  +
  +colors.background = #FF
  +
  +
  +  
  +
  +  
  +
  +  A common issue with properties file is to handle the reloading of the 
file when it
  +  changes. Typically you would use a thread monitoring the date of the file 
and reloading
  +  the Properties when a more recent date is detected. Commons 
Configuration
  +  integrates this mechanism out of the box, to enable it, just specify a 
reloading strategy
  +  on your configuration:
  +
  +
  +PropertiesConfiguration config = new PropertiesConfiguration("usergui.properties");
  +config.setReloadingStrategy(new FileChangedReloadingStrategy());
  +
  +
  +  Now everytime you edit manually the usergui.properties file, 
the
  +  configuration is automatically refreshed and the modified values are 
immediately
  +  available to your application.
  +
  +
  +  
  +
  +  
  +
  +  To save your configuration, just call the save() method:
  +
  +
  +PropertiesConfiguration config = new PropertiesConfiguration("usergui.properties");
  +config.setProperty("colors.background", "#00);
  +config.save();
  +
  +
  +  You can also save a copy of the configuration to another file:
  +
  +
  +PropertiesConfiguration config = new PropertiesConfiguration("usergui.properties");
  +config.setProperty("colors.background", "#00);
  +config.save("usergui.backup.properties);
  +
  +
  +  And if you don't want to bother saving your configuration everytime it 
changes,
  +  you can enable the automatic saving mode:
  +
  +
  +PropertiesConfiguration config = new PropertiesConfiguration("usergui.properties");
  +config.setAutoSave(true);
  +config.setProperty("colors.background", "#00); // the configuration is saved 
after this call
  +
  +
  +  
  +
  +  
  +
  +  Commons Configuration has the ability to return easily a list of values,
  +  for example if your file contains a list of comma separated values:
  +
  +
  +# chart colors
  +colors.pie = #FF, #00FF00, #FF
  +
  +
  +  You don't have to split the value manually, you can retrieve an array 
directly with:
  +
  +
  +String[] colors = config.getStringArray("colors.pie");
  +
  +
  +  Alternatively, you can specify a list of values in your properties file 
by using
  +  the same key on several lines:
  +
  +
  +# chart colors
  +colors.pie = #FF;
  +colors.pie = #00FF00;
  +colors.pie = #FF;
  +
  +  
  +
  +  
  +
  +  If you are familiar with Ant or Maven, you have most certainly already 
encountered
  +  the variables (like ${to

cvs commit: jakarta-commons/configuration/xdocs index.xml

2004-10-25 Thread ebourg
ebourg  2004/10/25 06:54:08

  Modified:configuration/xdocs index.xml
  Log:
  front page update:
  - modified code example
  - AbstractFileConfiguration mentioned
  - bug section copied from commons collections
  - javadoc link to the full API instead of the Configuration interface
  
  Revision  ChangesPath
  1.8   +33 -28jakarta-commons/configuration/xdocs/index.xml
  
  Index: index.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/index.xml,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- index.xml 18 Oct 2004 12:50:41 -  1.7
  +++ index.xml 25 Oct 2004 13:54:08 -  1.8
  @@ -13,19 +13,19 @@
 
   
 
  - Commons Configuration provides a generic configuration
  - interface which enables an application to read configuration
  - data from a variety of sources.  Commons Configuration
  - provides typed access to single, and multi-valued
  - configuration parameters as demonstrated by the following
  - code:
  + Commons Configuration provides a generic configuration interface which 
enables
  +an application to read configuration data from a variety of sources. 
Commons Configuration
  + provides typed access to single, and multi-valued configuration 
parameters as demonstrated
  +by the following code:
   
  -
  +
   
 
 
  - Configuration parameters may be loaded from the following
  - sources:
  + Configuration parameters may be loaded from the following sources:
   
   
 Properties files
  @@ -37,15 +37,13 @@
 Servlet parameters
   
   
  -Different configuration sources can be mixed using a
  - ConfigurationFactory and
  - CompositeConfiguration.  Additional sources of
  - configuration parameters can be created by using custom
  - configuration objects.  This customization can be achieved by
  - extending AbstractConfiguration.
  +Different configuration sources can be mixed using a 
ConfigurationFactory and
  + a CompositeConfiguration. Additional sources of 
configuration parameters can
  +be created by using custom configuration objects. This customization can be 
achieved by
  + extending AbstractConfiguration or 
AbstractFileConfiguration.
 
  
  - The full Configuration API is available here.
  + The full Javadoc API documentation is available here.
  
  
   
  @@ -53,25 +51,32 @@
 
   The latest release of Apache Jakarta Commons Configuration is available 
from here. 
   It is also available from http://www.ibiblio.org/maven/commons-configuration/jars";>IBiblio.
  -The Changes Report 
  -explains all of the changes and bug fixes that have been made.  
  +The Changes Report explains all of the 
changes and bug fixes that have been made.
 
   
   
   
 
  -Commons Configuration started as code in Apache JServ.  The
  -JServ code was subsequently added to http://jakarta.apache.org/turbine";>Jakarta Turbine.
  -After Jakarta Turbine, this configuration interface moved to
  -http://jakarta.apache.org/velocity";>Jakarta
  -Velocity and underwent various improvements.  After
  -Velocity, this code was introduced to the http://jakarta.apache.org/commons";>Jakarta Commons
  -as ExtendedProperties.  Configuration began life
  -in the Commons as a Sandbox component, and was promoted to the
  +Commons Configuration started as code in Apache JServ.  The JServ code was 
subsequently
  +added to http://jakarta.apache.org/turbine";>Jakarta Turbine. 
After Jakarta
  +Turbine, this configuration interface moved to http://jakarta.apache.org/velocity";>Jakarta Velocity
  +and underwent various improvements.  After Velocity, this code was 
introduced to the
  +http://jakarta.apache.org/commons";>Jakarta Commons as 
ExtendedProperties.
  +Configuration began life in the Commons as a Sandbox component, and was 
promoted to the
   Commons Proper in late 2003.
 
   
  +
  +
  +  Bugs may be reported via the Bugzilla Management system. The following 
links may prove useful:
  +
  +  
  +http://issues.apache.org/bugzilla/createaccount.cgi";>Create a 
Bugzilla account
  +http://issues.apache.org/bugzilla/enter_bug.cgi?product=Commons&component=Configuration";>Submit
 a bug report
  +http://issues.apache.org/bugzilla/buglist.cgi?product=Commons&component=Configuration&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED";>All
 open Configurat

Re: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Emmanuel Bourg
I'm not sure to understand the issue, why do you need to import /conf in 
your classpath ? That's for running the unit tests directly from Eclipse ?

Emmanuel Bourg
Eric Pugh wrote:
Hi all,
I am using the updated Maven Eclipse plugin, and one of the difficulties
that arises is that Eclipse (and therefore Maven) want each directory, if
included as resources on Eclipse's classpath, to be different.  Right now,
in configuration we include the /conf directory a ton of times.
What I want to do is bring [configuration] into line with other mavenenized
projects where test resources are all in /src/test-resources.  And the jar
resources would remain in /conf.  Basically just digesterRules.xml.
However, when I started this, I ran into a couple unit test failures.
Should I do this, and then fix the errors?  I have a bunch of questions
about some of the new tests that would be better answered if I could commit
the changes...
Eric
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [vote] Oliver Heger as Committer

2004-10-25 Thread Henning P. Schmiedehausen
"Eric Pugh" <[EMAIL PROTECTED]> writes:

>[X] Yes, bring him in!
>[ ] Don't care
>[ ] No

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen  INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
   -- Michelle Levesque, "Fundamental Issues with
Open Source Software Development"

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [vote] Oliver Heger as Committer

2004-10-25 Thread Emmanuel Bourg
[X] Yes, bring him in!
[ ] Don't care
[ ] No
Emmanuel Bourg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: [vote] Oliver Heger as Committer

2004-10-25 Thread Shapira, Yoav

Hi,

>[ X ] Yes, bring him in!
>[ ] Don't care
>[ ] No

+1.

Also an enthusiastic thumbs up for a very well-crafted vote message.

Yoav



This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Henning P. Schmiedehausen
"Eric Pugh" <[EMAIL PROTECTED]> writes:

>I dug in a bit more, and actually, only one unit test fails,
>TestPropertiesConfiguration.testLoadViaPropertyWithBasePath2.

>When I change the basepath's to use "src/test-resources":

>private String testBasePath2 = new
>File("src/test-resources").getAbsoluteFile().getParentFile().getAbsolutePath
>();

>the resulting file is c:\java\cvs\jakarta-commons\configuration\src.  I
>think this is wrong, becase I don't see how the unit test later would work..
>I get a NPE, and it seem reasonable..

>So, if no one has an object, I'd like to apply this change.  All the unit
>tests (99.76%) pass.

The parent directory of "foo/bar" should be the directory in which
"foo" resides. However the

File("src/test-resources").getAbsoluteFile().getParentFile().getAbsolutePath()

expression first concatenates "src/test-resources" with its parent and
then finds the parent of "test-resources". Which is what you see: The
parent of "test-resources", not "src/test-resources".

The test does not expect new File("foo") to contain "dir/foo". So the
behaviour is as expected but different.

Regards
Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen  INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
   -- Michelle Levesque, "Fundamental Issues with
Open Source Software Development"

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [GUMP@brutus]: Project commons-resources (in module jakarta-commons-sandbox) failed

2004-10-25 Thread James Mitchell
Ok, it's been an entire month now.  This was once working fine and I have no
idea what changed and why it can't find those jars.

Any help is appreciated.



--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx

- Original Message -
From: "Stefan Bodewig" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Saturday, October 23, 2004 5:28 AM
Subject: [EMAIL PROTECTED]: Project commons-resources (in module
jakarta-commons-sandbox) failed


> To whom it may engage...
>
> This is an automated request, but not an unsolicited one. For
> more information please visit http://gump.apache.org/nagged.html,
> and/or contact the folk at [EMAIL PROTECTED]
>
> Project commons-resources has an issue affecting its community
integration.
> This issue affects 1 projects,
>  and has been outstanding for 31 runs.
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
> - commons-resources :  Commons resources
>
>
> Full details are available at:
>
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-resourc
es/index.html
>
> That said, some information snippets are provided here.
>
> The following annotations (debug/informational/warning/error messages)
were provided:
>  -DEBUG- Sole output [commons-resources-23102004.jar] identifier set to
project name
>  -INFO- Failed with reason build failed
>  -INFO- Failed to extract fallback artifacts from Gump Repository
>
>
>
> The following work was performed:
>
http://brutus.apache.org/gump/public/jakarta-commons-sandbox/commons-resourc
es/gump_work/build_jakarta-commons-sandbox_commons-resources.html
> Work Name: build_jakarta-commons-sandbox_commons-resources (Type: Build)
> Work ended in a state of : Failed
> Elapsed: 2 secs
> Command Line:
java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/lo
cal/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/g
ump/public/workspace/xml-xerces2/java/build/xml-apis.jar:/usr/local/gump/pub
lic/workspace/xml-xalan/java/build/serializer.jar:/usr/local/gump/public/wor
kspace/xml-xalan/java/build/xalan-unbundled.jar:/usr/local/gump/public/works
pace/xml-commons/java/external/build/xml-apis.jar
org.apache.tools.ant.Main -Dgump.merge=/usr/local/gump/public/gump/work/merg
e.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-resources-23102004 dist
> [Working Directory:
/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources]
> CLASSPATH :
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons-s
andbox/resources/target/classes:/usr/local/gump/public/workspace/jakarta-com
mons-sandbox/resources/target/test-classes:/usr/local/gump/public/workspace/
ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib
/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/us
r/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/publ
ic/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant
/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant
-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local
/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core
.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/comm
ons-collections-23102004.jar:/usr/local/gump/public/workspace/jakarta-common
s/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakart
a-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/worksp
ace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/
workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gu
mp/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/pub
lic/workspace/dist/junit/junit.jar:/usr/local/gump/packages/iBATIS_DBL-2.0.5
.399/ibatis-dao-2.jar:/usr/local/gump/packages/iBATIS_DBL-2.0.5.399/ibatis-c
ommon-2.jar:/usr/local/gump/packages/iBATIS_DBL-2.0.5.399/ibatis-sqlmap-2.ja
r
> -
> Buildfile: build.xml
>
> init:
> [mkdir] Created dir:
/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/target/li
b
>
> get-deps:
>
> compile:
> [mkdir] Created dir:
/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/target/cl
asses
> [javac] Compiling 28 source files to
/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/target/cl
asses
> [javac]
/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/
org/apache/commons/resources/impl/IBatisResources.java:38: package
com.ibatis.db.sqlmap does not exist
> [javac] import com.ibatis.db.sqlmap.SqlMap;
> [javac] ^
> [javac]
/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/
org/apache/commons/resources/impl/IBatisResources.java:39: package
com.ibat

RE: [configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Eric Pugh
I dug in a bit more, and actually, only one unit test fails,
TestPropertiesConfiguration.testLoadViaPropertyWithBasePath2.

When I change the basepath's to use "src/test-resources":

private String testBasePath2 = new
File("src/test-resources").getAbsoluteFile().getParentFile().getAbsolutePath
();

the resulting file is c:\java\cvs\jakarta-commons\configuration\src.  I
think this is wrong, becase I don't see how the unit test later would work..
I get a NPE, and it seem reasonable..

So, if no one has an object, I'd like to apply this change.  All the unit
tests (99.76%) pass.

ERic



> -Original Message-
> From: Eric Pugh [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 25, 2004 12:10 PM
> To: Commons-Dev
> Subject: [configuration] Moving test resources to /src/test-resources
>
>
> Hi all,
>
> I am using the updated Maven Eclipse plugin, and one of the difficulties
> that arises is that Eclipse (and therefore Maven) want each directory, if
> included as resources on Eclipse's classpath, to be different.  Right now,
> in configuration we include the /conf directory a ton of times.
>
> What I want to do is bring [configuration] into line with other
> mavenenized
> projects where test resources are all in /src/test-resources.  And the jar
> resources would remain in /conf.  Basically just digesterRules.xml.
>
> However, when I started this, I ran into a couple unit test failures.
> Should I do this, and then fix the errors?  I have a bunch of questions
> about some of the new tests that would be better answered if I
> could commit
> the changes...
>
> Eric
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [vote] Oliver Heger as Committer

2004-10-25 Thread Eric Pugh

> [X] Yes, bring him in!
> [ ] Don't care
> [ ] No


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[configuration] Moving test resources to /src/test-resources

2004-10-25 Thread Eric Pugh
Hi all,

I am using the updated Maven Eclipse plugin, and one of the difficulties
that arises is that Eclipse (and therefore Maven) want each directory, if
included as resources on Eclipse's classpath, to be different.  Right now,
in configuration we include the /conf directory a ton of times.

What I want to do is bring [configuration] into line with other mavenenized
projects where test resources are all in /src/test-resources.  And the jar
resources would remain in /conf.  Basically just digesterRules.xml.

However, when I started this, I ran into a couple unit test failures.
Should I do this, and then fix the errors?  I have a bunch of questions
about some of the new tests that would be better answered if I could commit
the changes...

Eric


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[vote] Oliver Heger as Committer

2004-10-25 Thread Eric Pugh
Hi all,

I would like to nominate Oliver Heger as a committer to Jakarta Commons.
Oliver has been very active in the [configuration] project[1], and I feel
gets the "Jakarta way".  He has partipated in doing a lot of the icky bug
finding and fixing in [configuration] and will be an asset in designing the
next version of [configuration].

A bit about him:
I was born in 1973 in Germany. I have a diploma in computer science. From
1999 to 2003 I worked as a developer for a small software company. My main
area of work were internet applications based on the J2EE platform. Since
December 2004 I work for the University of Marburg, Germany in the Institute
of Medical Informatics and for the university hospital.

[ ] Yes, bring him in!
[ ] Don't care
[ ] No


Eric


[1]
http://nagoya.apache.org/eyebrowse/SearchList?listId=&listName=commons-dev%4
0jakarta.apache.org&searchText=oliver+heger&defaultField=sender&Search=Searc
h


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [email] Dumbster failing

2004-10-25 Thread Eric Pugh
Go ahead and before doing any coding, send me a single patch with all the
formatting chanes.  No code changes!  Then in the comments for the commit I
can specify "Code formatting cleanup, no changes".

Just to confirm, your checkstyle plugin is using the standard jakarta
formatting?  Which, since I can't find anything to the contrary, is the Sun
format.  I think since email came from the Turbine project, it was formatted
with the turbine format.

Here are some links on the correct format to use:
http://jakarta.apache.org/commons/patches.html
http://jakarta.apache.org/site/library.html

Thanks!  We'll get there!  It's nice to see new life in [email].

Eric

> -Original Message-
> From: Corey Scott [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 25, 2004 5:11 AM
> To: Jakarta Commons Developers List
> Subject: Re: [email] Dumbster failing
>
>
> Ok, I will switch my build to maven from Ant (although Maven seemed
> not to like dumbster too much last time I tried it).  I will get the
> get the tests going and resubmit.
>
> I think I'm going to have to start again from the cvs, cause my code
> tree is becoming too different from the committed one.  I do have one
> request though, can we please fix the formatting!! :-) My
> checkstyle plugin goes bonkers when i update from the cvs.  I realise
> this is partly my fault (the first set of tests had the wrong style).
> How do you suggest we deal with this?
>
> Corey
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [math] R-based tests

2004-10-25 Thread Al Chou
--- Phil Steitz <[EMAIL PROTECTED]> wrote:
> I have used R to compute target values for statistics (and other things) 
> in test cases where certified data tests are not available. To make these 
> tests repeatable, I have been saving "scripts" that can be executed in R 
> using the source() function. I would like to add these scripts to CVS 
> somewhere.  Any ideas as to where they should go?  These are not really 
> executable and don't need to be accessible to the build or JUnit tests.

My first instinct is to place them just as you would if they were JUnit
classes, just so they're easy to find by what they're related to.

Al

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]