[jira] Commented: (POOL-75) [pool] GenericObjectPool not FIFO with respect to borrowing threads
[ http://issues.apache.org/jira/browse/POOL-75?page=comments#action_12415087 ] Sandy McArthur commented on POOL-75: While the implementation in the patch (in bugzilla) looks straight forward, I think it has some problems. 1: I think with the _borrowerQueue.add(Thread.currentThread()); out side the sync block you have race that could lead to: 1.a: a pool configured to use WHEN_EXHAUSTED_FAIL to throw a NoSuchElementException when it shouldn't. 1.b: a pool configured to use WHEN_EXHAUSTED_GROW to create a new poolable objects when there are idle objects available. 2. Since if this were to be included in Pool it would mostly likely be included in Pool 2.0 it should pass those unit tests. (To test with these extend TestObjectPool or subclass and implement the makeEmptyPool methods and the suit method.) Currently it fails the TestObjectPool.testPOFBorrowObjectUsages() test as it calls activateObject for an object that was just made via makeObject. This fix is as simple as adding return pair.value; right after the newlyCreated = true; line. 3. How is this supposed to work with the evictor? Is the evictor allowed to preempt the other threads? I think that is what would happen now. > [pool] GenericObjectPool not FIFO with respect to borrowing threads > --- > > Key: POOL-75 > URL: http://issues.apache.org/jira/browse/POOL-75 > Project: Commons Pool > Type: Improvement > Versions: Nightly Builds > Environment: Operating System: All > Platform: All > Reporter: Gordon Mohr > Assignee: Sandy McArthur > Priority: Minor > > GenericObjectPool has recently been made FIFO with respect to the managed pool > objects -- however, it is still not FIFO with respect to threads requesting > those objects. Specifically, because standard non-fair Java synchronization > monitors are used, later threads may barge ahead of earlier threads that are > already waiting for a pool object to become available. At its extreme, some > threads can cycle objects through the pool many times while others wait > interminable. > Not every application needs FIFO fairness with respect to threads, and such > fairness implies an overhead, so it need not be the default behavior, but it > would be a valuable option where many threads are sharing a smaller number of > pool objects. > I can submit a FairGenericObjectPool which achieves thread-fairness; it only > requires small changes to GenericObjectPool which allow some subclass > overriding. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Reopened: (POOL-75) [pool] GenericObjectPool not FIFO with respect to borrowing threads
[ http://issues.apache.org/jira/browse/POOL-75?page=all ] Sandy McArthur reopened POOL-75: Assign To: Sandy McArthur > [pool] GenericObjectPool not FIFO with respect to borrowing threads > --- > > Key: POOL-75 > URL: http://issues.apache.org/jira/browse/POOL-75 > Project: Commons Pool > Type: Improvement > Versions: Nightly Builds > Environment: Operating System: All > Platform: All > Reporter: Gordon Mohr > Assignee: Sandy McArthur > Priority: Minor > > GenericObjectPool has recently been made FIFO with respect to the managed pool > objects -- however, it is still not FIFO with respect to threads requesting > those objects. Specifically, because standard non-fair Java synchronization > monitors are used, later threads may barge ahead of earlier threads that are > already waiting for a pool object to become available. At its extreme, some > threads can cycle objects through the pool many times while others wait > interminable. > Not every application needs FIFO fairness with respect to threads, and such > fairness implies an overhead, so it need not be the default behavior, but it > would be a valuable option where many threads are sharing a smaller number of > pool objects. > I can submit a FairGenericObjectPool which achieves thread-fairness; it only > requires small changes to GenericObjectPool which allow some subclass > overriding. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Commons-collections & events
> I'm in the process of stealing (possibly forking) the dormant project > commons-events. > I'd really rather keep it separate and refer to it by a dependency. Why fork? ...why not re-surrecting it in commons? ...just currious. cheers -- Torsten - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (POOL-75) [pool] GenericObjectPool not FIFO with respect to borrowing threads
[ http://issues.apache.org/jira/browse/POOL-75?page=comments#action_12415081 ] Gordon Mohr commented on POOL-75: - You didn't like my patch? (See bugzilla; it doesn't depend on util.concurrent.) Even if the subclass itself isn't to be integrated -- it is a little awkward -- if the GenericObjectPool class were a bit more friendly to subclassing (fewer private fields) anyone could drop in the Fair subclass without having to patch GenericObjectPool itself. > [pool] GenericObjectPool not FIFO with respect to borrowing threads > --- > > Key: POOL-75 > URL: http://issues.apache.org/jira/browse/POOL-75 > Project: Commons Pool > Type: Improvement > Versions: Nightly Builds > Environment: Operating System: All > Platform: All > Reporter: Gordon Mohr > Priority: Minor > > GenericObjectPool has recently been made FIFO with respect to the managed pool > objects -- however, it is still not FIFO with respect to threads requesting > those objects. Specifically, because standard non-fair Java synchronization > monitors are used, later threads may barge ahead of earlier threads that are > already waiting for a pool object to become available. At its extreme, some > threads can cycle objects through the pool many times while others wait > interminable. > Not every application needs FIFO fairness with respect to threads, and such > fairness implies an overhead, so it need not be the default behavior, but it > would be a valuable option where many threads are sharing a smaller number of > pool objects. > I can submit a FairGenericObjectPool which achieves thread-fairness; it only > requires small changes to GenericObjectPool which allow some subclass > overriding. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (POOL-75) [pool] GenericObjectPool not FIFO with respect to borrowing threads
[ http://issues.apache.org/jira/browse/POOL-75?page=all ] Sandy McArthur closed POOL-75: -- Resolution: Later Untill Pool can use the util.concurrent package this will have to wait. > [pool] GenericObjectPool not FIFO with respect to borrowing threads > --- > > Key: POOL-75 > URL: http://issues.apache.org/jira/browse/POOL-75 > Project: Commons Pool > Type: Improvement > Versions: Nightly Builds > Environment: Operating System: All > Platform: All > Reporter: Gordon Mohr > Priority: Minor > > GenericObjectPool has recently been made FIFO with respect to the managed pool > objects -- however, it is still not FIFO with respect to threads requesting > those objects. Specifically, because standard non-fair Java synchronization > monitors are used, later threads may barge ahead of earlier threads that are > already waiting for a pool object to become available. At its extreme, some > threads can cycle objects through the pool many times while others wait > interminable. > Not every application needs FIFO fairness with respect to threads, and such > fairness implies an overhead, so it need not be the default behavior, but it > would be a valuable option where many threads are sharing a smaller number of > pool objects. > I can submit a FairGenericObjectPool which achieves thread-fairness; it only > requires small changes to GenericObjectPool which allow some subclass > overriding. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Commons-collections & events
Bryce L Nordgren wrote: > I'm in the process of stealing (possibly forking) the dormant project > commons-events. > I'd really rather keep it separate and refer to it by a dependency. > Would there be any interest in reviving this project Yes. > I hope to sweet talk someone here into taking commons-events back > when I'm done with it. Perhaps you and a few of your closest friends would like to contribute on an on-going basis? > is there any reason not to absorb commons-events back > into commons-collections? Arguments for? Against? --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Commons-collections & events
Dear Jakarta Commons developers I'm in the process of stealing (possibly forking) the dormant project commons-events. While I am highly motivated to adopt it as a baseline, I'd be integrating it into a Geospatial library (GeoTools; http://docs.codehaus.org/display/GEOTOOLS/). I'd really rather keep it separate and refer to it by a dependency. Would there be any interest in reviving this project if I handed it back to Apache with tests, a maven 2 POM, and whatever fixins might be required to make it function? Conversely, would anyone have advice on the current state of the code (what to watch out for, etc.) for a person primarily interested in the ObservableSet/Map/List/Collections? As I am lazy and refactoring is work, I hope to sweet talk someone here into taking commons-events back when I'm done with it. Maybe even release it. :) Progress may be observed at: http://svn.geotools.org/geotools/branches/jts-wrapper/module/events/ Out of curiousity, is there any reason not to absorb commons-events back into commons-collections? Thanks, Bryce PS: I'd like to update my maven dependency for commons-collections to 3.2, but it's not on ibiblio yet (released May16th). When might this arrival be celebrated? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MATH-151) MathUtils.round incorrect result
[ http://issues.apache.org/jira/browse/MATH-151?page=comments#action_12415048 ] Luc Maisonobe commented on MATH-151: I think this behaviour is normal. Despite 39.245 has a finite representation in decimal, this is not true in base 2, it has a infinite number of digits. For the sake of simplicity, here is the representation in base 16 (much more readable than base 2) : 0x27.3EB851EB851EB851EB851... Note that the pattern EB851 repeats itself ad infinitum, in base 2 it is a 20 bits pattern. If this number could be represented in a virtual infinite register, multiplying it by 100.0 (base 10) would be multiplying it by 0x64 (base 16) and the result would be 0xF54.8 which is 3924.5 as could be rounded as expected. However, primitive doubles are represented in Java using the IEEE754 norm, where the mantissa is 53 bits long, counting an implicit first bit. This implies that in the previous infinite number only the following is represented in IEE754: 0x27.3EB851EB851 hence, when this number is multiplied by 100, we get the result: 0xF54.7A4 or 3924.499477040546480566263198... So the error is exactly 0x0.05C or 92/16^11 which is approximately 5.229e-12. The problem comes from the fact the original number cannot be represented exactly (it is not what is sometimes called a "floating-point number" or "normal number"), and in this case the first neglected hexadecimal digit is large (E) which explains the large error (7 wrong bits after the multiplication). I would say this is not an issue with commons-math but with IEE754, we cannot do anything about it. Note that the same would occur if we could add one pattern by adding 20 bits. In this case, the final number would be 3924.450126700065666 and the error appoximately 4.987e-18 (92/16^16), but still lesser than 3924.5 > MathUtils.round incorrect result > > > Key: MATH-151 > URL: http://issues.apache.org/jira/browse/MATH-151 > Project: Commons Math > Type: Bug > Versions: 1.1 Final > Environment: Win2K, Sun JDK1.5.0_05 b05 > Reporter: Buza Zoltán > > MathUtils.round(39.245, 2) results 39.24, however it should be 39.25, with > default rounding mode BigDecimal.ROUND_HALF_UP. > I found that internally MathUtils.round multiplies the given number by > 10^scale. > 39.245 * 100.0 results 3924.4...5 , and after this the calculation is > not correct any more. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (CLI-32) [cli] ant test needs resources copied.
[ http://issues.apache.org/jira/browse/CLI-32?page=all ] Henri Yandell resolved CLI-32: -- Fix Version: 2.0 Final Resolution: Fixed Thanks Andrew, patch applied. svn ci -m "Fixing ant test so it doesn't fall over on ResourceHelperTest - CLI-32" build.xml Sendingbuild.xml Transmitting file data . Committed revision 412203. > [cli] ant test needs resources copied. > -- > > Key: CLI-32 > URL: http://issues.apache.org/jira/browse/CLI-32 > Project: Commons CLI > Type: Bug > Environment: Operating System: other > Platform: Other > Reporter: Andrew Shirley > Fix For: 2.0 Final > Attachments: fixbuild.patch > > When running "ant test" org.apache.commons.cli2.resource.ResourceHelperTest > was > failing as it needs a .properties file copying from src/test to > target/test-classes/ > I have created a patch to build.xml (attached) which has a which copies > .properties files for tests in much the same way as the existing one for > src/java -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412203 - /jakarta/commons/proper/cli/trunk/build.xml
Author: bayard Date: Tue Jun 6 13:00:13 2006 New Revision: 412203 URL: http://svn.apache.org/viewvc?rev=412203&view=rev Log: Fixing ant test so it doesn't fall over on ResourceHelperTest - CLI-32 Modified: jakarta/commons/proper/cli/trunk/build.xml Modified: jakarta/commons/proper/cli/trunk/build.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/build.xml?rev=412203&r1=412202&r2=412203&view=diff == --- jakarta/commons/proper/cli/trunk/build.xml (original) +++ jakarta/commons/proper/cli/trunk/build.xml Tue Jun 6 13:00:13 2006 @@ -160,6 +160,12 @@ + + + + + + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (CLI-96) [cli][PATCH] HelpWriter.printWrapped() should have public access
[ http://issues.apache.org/jira/browse/CLI-96?page=all ] Henri Yandell resolved CLI-96: -- Fix Version: 2.0 Final Resolution: Fixed Seems good. svn ci -m "Applying patch from CLI-96 to make printWrapped public" src/java/org/apache/commons/cli2/util/ HelpFormatter.java Sendingsrc/java/org/apache/commons/cli2/util/HelpFormatter.java Transmitting file data . Committed revision 412201. > [cli][PATCH] HelpWriter.printWrapped() should have public access > > > Key: CLI-96 > URL: http://issues.apache.org/jira/browse/CLI-96 > Project: Commons CLI > Type: Improvement > Environment: Operating System: All > Platform: All > Reporter: James Ring > Priority: Minor > Fix For: 2.0 Final > Attachments: help-formatter-printWrapped-public-access.patch > > Hi there, > I think HelpWriter.printWrapped() is a neat utility function for outputting > any > wrapped text. Adding a flush() statement makes it a tidy general purpose > utility. > Patch attached. I found it useful anyway! > Thanks! > Regards, > James -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412201 - /jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/util/HelpFormatter.java
Author: bayard
Date: Tue Jun 6 12:51:08 2006
New Revision: 412201
URL: http://svn.apache.org/viewvc?rev=412201&view=rev
Log:
Applying patch from CLI-96 to make printWrapped public
Modified:
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/util/HelpFormatter.java
Modified:
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/util/HelpFormatter.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/util/HelpFormatter.java?rev=412201&r1=412200&r2=412201&view=diff
==
---
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/util/HelpFormatter.java
(original)
+++
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/util/HelpFormatter.java
Tue Jun 6 12:51:08 2006
@@ -279,13 +279,15 @@
* Prints a string wrapped if necessary
* @param text the string to wrap
*/
-protected void printWrapped(final String text) {
+public void printWrapped(final String text) {
for (final Iterator i = wrap(text, pageWidth).iterator();
i.hasNext();) {
printGutterLeft();
pad((String) i.next(), pageWidth, out);
printGutterRight();
out.println();
}
+
+out.flush();
}
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[lang] Pushing Enums back to 2.3?
Any thoughts on having a 2.3 release that focuses on the 5 enum issues? * BugLANG-262Use of enum prevents a classloader from being garbage collected resuling in out of memory exceptions. * Bug LANG-153[lang] Can't XMLDecode an Enum * Bug LANG-76 [lang] EnumUtils.getEnum() doesn't work well in 1.5 * Improvement LANG-258Enum JavaDoc: 1) outline 5.0 native Enum migration 2) warn not to use the switch() , 3) point out approaches for persistence and gui * Bug LANG-259ValuedEnum.compareTo(Object other) not typesafe - it easily could be... So they would be pushed back to 2.3, leaving us with 8 issues in 2.2. Of those 8, LANG-180 and LANG-197 should be pushed back to 3.0. Features that require discussion I think. * Improvement LANG-180[lang] adding a StringUtils.replace method that takes an array or List of replacement strings * Improvement LANG-197[lang] Extending VariableFormatter to use FormatPatterns That leaves us with 6. Bug LANG-66 [lang] StringEscaper.escapeXml() escapes characters > 0x7f Bug LANG-100[lang] RandomStringUtils.random() family of methods create invalid unicode sequences Bug LANG-59 [lang] DateUtils.truncate method is buggy when dealing with DST switching hours Bug LANG-69 [lang] ToStringBuilder throws StackOverflowError when an Object cycle exists Bug LANG-140[lang] DurationFormatUtils.formatPeriod() returns the wrong result Improvement LANG-226[lang] Using ReflectionToStringBuilder and excluding secure fields LANG-66 is easy enough to change assuming no one is against the idea. Gary's reading of the XML spec suggested that we shouldn't be escaping such characters but just letting them sit in the XML. LANG-100 is confusing. I think it's solveable, but not sure any of us know much about this part of unicode. LANG-59 - I have no idea on fixing this. Needs code of some kind in DateUtils.modify. If it's all that's left at the end, I'll be recommending we push it to 3.0. LANG-69 needs to be reworked - there's too much there and it breaks another test. LANG-140 needs some hacking to get a fix that isn't too ugly. LANG-226 just needs a bit of cleanup. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (LANG-263) [lang] Add StringUtils.containsIgnoreCase(...)
[ http://issues.apache.org/jira/browse/LANG-263?page=all ] Henri Yandell resolved LANG-263: Fix Version: 2.2 (was: 3.0) Resolution: Fixed Thanks for the patch. Committed and will appear in Lang 2.2 (and nightly builds tonight). svn ci -m "Added containsIgnoreCase method - LANG-263" src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java src/java/org/apache/commons/lang/StringUtils.java Sendingsrc/java/org/apache/commons/lang/StringUtils.java Sending src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java Transmitting file data .. Committed revision 412200. > [lang] Add StringUtils.containsIgnoreCase(...) > -- > > Key: LANG-263 > URL: http://issues.apache.org/jira/browse/LANG-263 > Project: Commons Lang > Type: New Feature > Reporter: analogue > Priority: Minor > Fix For: 2.2 > > To complement StringUtils.equalsIgnoreCase(...), > StringUtils.containsIgnoreCase(...) would be quite useful. A simple > implementation would uppercase both strings and delegate to > StringUtils.contains(...). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412200 - in /jakarta/commons/proper/lang/trunk/src: java/org/apache/commons/lang/StringUtils.java test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java
Author: bayard
Date: Tue Jun 6 12:35:14 2006
New Revision: 412200
URL: http://svn.apache.org/viewvc?rev=412200&view=rev
Log:
Added containsIgnoreCase method - LANG-263
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java?rev=412200&r1=412199&r2=412200&view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
Tue Jun 6 12:35:14 2006
@@ -1034,6 +1034,36 @@
return str.indexOf(searchStr) >= 0;
}
+ /**
+ * Checks if String contains a search String irrespective of case,
+ * handling null. This method uses
+ * [EMAIL PROTECTED] #contains(String, String)}.
+ *
+ * A null String will return false.
+ *
+ *
+ * StringUtils.contains(null, *) = false
+ * StringUtils.contains(*, null) = false
+ * StringUtils.contains("", "") = true
+ * StringUtils.contains("abc", "") = true
+ * StringUtils.contains("abc", "a") = true
+ * StringUtils.contains("abc", "z") = false
+ * StringUtils.contains("abc", "A") = true
+ * StringUtils.contains("abc", "Z") = false
+ *
+ *
+ * @param str the String to check, may be null
+ * @param searchStr the String to find, may be null
+ * @return true if the String contains the search String irrespective of
+ * case or false if not or null string input
+ */
+public static boolean containsIgnoreCase(String str, String searchStr) {
+if (str == null || searchStr == null) {
+return false;
+}
+return contains(str.toUpperCase(), searchStr.toUpperCase());
+}
+
// IndexOfAny chars
//---
/**
Modified:
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java?rev=412200&r1=412199&r2=412200&view=diff
==
---
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsEqualsIndexOfTest.java
Tue Jun 6 12:35:14 2006
@@ -274,6 +274,40 @@
assertEquals(false, StringUtils.contains("abc", "z"));
}
+public void testContainsIgnoreCase_StringString() {
+assertFalse(StringUtils.containsIgnoreCase(null, null));
+
+// Null tests
+assertFalse(StringUtils.containsIgnoreCase(null, ""));
+assertFalse(StringUtils.containsIgnoreCase(null, "a"));
+assertFalse(StringUtils.containsIgnoreCase(null, "abc"));
+
+assertFalse(StringUtils.containsIgnoreCase("", null));
+assertFalse(StringUtils.containsIgnoreCase("a", null));
+assertFalse(StringUtils.containsIgnoreCase("abc", null));
+
+// Match len = 0
+assertTrue(StringUtils.containsIgnoreCase("", ""));
+assertTrue(StringUtils.containsIgnoreCase("a", ""));
+assertTrue(StringUtils.containsIgnoreCase("abc", ""));
+
+// Match len = 1
+assertFalse(StringUtils.containsIgnoreCase("", "a"));
+assertTrue(StringUtils.containsIgnoreCase("a", "a"));
+assertTrue(StringUtils.containsIgnoreCase("abc", "a"));
+assertFalse(StringUtils.containsIgnoreCase("", "A"));
+assertTrue(StringUtils.containsIgnoreCase("a", "A"));
+assertTrue(StringUtils.containsIgnoreCase("abc", "A"));
+
+// Match len > 1
+assertFalse(StringUtils.containsIgnoreCase("", "abc"));
+assertFalse(StringUtils.containsIgnoreCase("a", "abc"));
+assertTrue(StringUtils.containsIgnoreCase("xabcz", "abc"));
+assertFalse(StringUtils.containsIgnoreCase("", "ABC"));
+assertFalse(StringUtils.containsIgnoreCase("a", "ABC"));
+assertTrue(StringUtils.containsIgnoreCase("xabcz", "ABC"));
+}
+
//---
public void testIndexOfAny_StringStringarray() {
assertEquals(-1, StringUtils.indexOfAny(null, (String[]) null));
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Modeler] Resync and Release for commons-modeler
Dims, Sorry for the late response. This is a very busy week for me, so I don't have much time. I can definitely handle syncing Tomcat to the latest stable modeler release, once such a release is available. It'd be nice if someone else can commit the modeler patch and cut that modeler release... Yoav On 6/3/06, Davanum Srinivas <[EMAIL PROTECTED]> wrote: Bill, Yoav, Dennis, Could you please help with [1] and the resync with Tomcat's version of modeler? Once that is done, rbb and/or i can start a VOTE thread for a release that we need for Geronimo. Thanks, dims [1] http://issues.apache.org/jira/browse/MODELER-3 -- Davanum Srinivas : http://wso2.com/blogs/ -- Yoav Shapira Nimalex LLC 1 Mifflin Place, Suite 310 Cambridge, MA, USA [EMAIL PROTECTED] / www.yoavshapira.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JXPATH-68) StackOverflow error on a call to 'JXPathContext.createPath()'
StackOverflow error on a call to 'JXPathContext.createPath()'
-
Key: JXPATH-68
URL: http://issues.apache.org/jira/browse/JXPATH-68
Project: Commons JXPath
Type: Bug
Versions: 1.2 Final, Nightly Builds
Environment: Windows XP Professional, Sun JDK 1.4.2
Run with JXPath v1.2 and v20060530
Reporter: Joseph Campolongo
I'm running into a StackOverflow error on a call to
'JXPathContext.createPath()' whenever I have a path that looks like
'a/b[1]/c'. I took a quick look at the code and it appears JXPath, when
trying to create its parent pointer, simply recreates an equivalent
pointer(???).
Here is code to reproduce the problem.
Map map = new HashMap();
map.put("a", null);
JXPathContext pathContext = JXPathContext.newContext(map);
pathContext.setFactory(new AbstractFactory() {
public boolean createObject(
JXPathContext context, Pointer pointer, Object parent, String
name, int index) {
Map parentMap = (Map)parent;
System.out.println(parent + ":" + name + ":" + index);
if (index > -1) {
List list = (List)parentMap.get(name);
if (list == null) {
list = new ArrayList();
}
int size = list.size();
for (int i = size; i <= index; i++) {
list.add(i, null);
}
parentMap.put(name, list);
} else {
parentMap.put(name, new HashMap());
}
return true;
}
});
pathContext.createPath("a/b[1]/c");
***
I have continued looking into this, and found that the problem is that, if
the List is created with a 'null' element, JXPath gets stuck in infinite
recursion.
To discover this, I changed my Factory to implement the following method:
public boolean createObject(
JXPathContext context, Pointer pointer, Object parent,
String name, int index) {
if (pointer instanceof NodePointer) {
index = ((NodePointer)pointer).getIndex();
}
System.out.println(parent + ":" + name + ":" + index);
Map parentMap = (Map)parent;
if (index > -1) {
List list = (List)parentMap.get(name);
if (list == null) {
list = new ArrayList();
}
int size = list.size();
for (int i = size; i <= index; i++) {
list.add(i, new HashMap()); // !! Don't set to 'null'
}
parentMap.put(name, list);
} else {
parentMap.put(name, new HashMap());
}
return true;
}
Then I ran the following code:
pathContext.createPath("a/b[1]/c");
pathContext.createPath("a/b[2]/c"); // STACK OVERFLOW HERE
Here is the stack trace at the beginning, where
'ValueUtils.expandCollection()' is called. It puts 'null' into the list,
thus causing the stack overflow as we cycle between createPath() &
createChild().
Thread [main] (Suspended (breakpoint at line 227 in DynamicPropertyPointer))
DynamicPropertyPointer.createPath(JXPathContext) line: 227
DynamicPropertyPointer(PropertyPointer).createChild(JXPathContext,
QName, int) line: 188
NullElementPointer.createPath(JXPathContext) line: 82
NullPointer.createPath(JXPathContext) line: 86
NullPropertyPointer.createPath(JXPathContext) line: 103
NullPointer.createPath(JXPathContext) line: 86
NullPropertyPointer.createPath(JXPathContext) line: 103
JXPathContextReferenceImpl.createPath(String, Expression) line: 447
JXPathContextReferenceImpl.createPath(String) line: 427
Test.test4() line: 75
Test.main(String[]) line: 38
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[chain] Version 1.1 release candidate 2
Following an issue in RC1 found by Dennis Lundberg I have prepared release candidate 2 for Chain 1,1 for review: http://people.apache.org/~niallp/commons-chain/ Release notes for version 1.1 are here: http://people.apache.org/~niallp/commons-chain/site/changes-report.html New version of the chain site: http://people.apache.org/~niallp/commons-chain/site/ All feedback on this release candidate build is welcome. Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] Version 1.1 release candidate 1
On 6/6/06, Dennis Lundberg <[EMAIL PROTECTED]> wrote: Niall Pemberton wrote: > Release candidate 1 for Chain 1,1 is available for review: > http://people.apache.org/~niallp/commons-chain/ > > Release notes for version 1.1 are here: > http://people.apache.org/~niallp/commons-chain/site/changes-report.html > > New version of the chain site: > http://people.apache.org/~niallp/commons-chain/site/ > > All feedback on this release candidate build is welcome. Niall, three things: Firstly we might have to revert the groupId change in the project.xml file. I've done some testing and I'm waiting for some guidance from Brett on how to proceed. OK, thanks for the heads up - I'll wait to see what happens, but if we get to a point of wanting to vote on a release before theres an answer I'll revert it for Chain. Secondly, I've tried to build the RC from source using Maven and I get a test failure in TestContextTestCase. The build still succeeds though. I'm using Sun JDK 1.4.2_11 on Windows XP Pro, if it is of importance. Here are the details in the test-report: Hmm weird. I built with JDK 1.4.2_10 on W2K and it passed fine - I downloaded the latest 1.4 version (JDK 1.4.2_12) and tried it and got the same result as you. Anyway appears to be caused by the static property "placeholder" object its using not being serializable - I've just committed a fix for this, thanks for spotting it. I think this warrants a new RC - I'll post RC2 shortly. Testsuite: org.apache.commons.chain.impl.TestContextTestCase Tests run: 10, Failures: 0, Errors: 1, Time elapsed: 0,625 sec Testcase: testSeriaization(org.apache.commons.chain.impl.TestContextTestCase): Caused an ERROR org.apache.commons.chain.impl.ContextBase$1 java.io.NotSerializableException: org.apache.commons.chain.impl.ContextBase$1 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1054) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278) at java.util.HashMap.writeObject(HashMap.java:986) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:809) at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1296) at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1247) at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1052) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278) at org.apache.commons.chain.impl.ContextBaseTestCase.testSeriaization(ContextBaseTestCase.java:367) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) Finally, I am not getting the same changelog-report as you do. Are you using a local project.properties file for this? If so, and that is the way it should be, then a note about it in xdocs/building.xml would be nice. I use a local build.properties to specify the date of the last release and a custom version of the changelog plugin which overcomes the subversion issue wrt to imports to subversion screwing up the index. I've updated the building.xml with details as you suggested. Thanks for taking the time to check out the RC - I appreciate the feedback (especially catching the serialization bug :-). Niall Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412169 - in /jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2: ./ project.xml xdocs/changes.xml
Author: niallp Date: Tue Jun 6 09:46:40 2006 New Revision: 412169 URL: http://svn.apache.org/viewvc?rev=412169&view=rev Log: Tag Chain 1.1 RC2 Added: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/ - copied from r412167, jakarta/commons/proper/chain/trunk/ Modified: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/project.xml jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/xdocs/changes.xml Modified: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/project.xml?rev=412169&r1=412167&r2=412169&view=diff == --- jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/project.xml (original) +++ jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/project.xml Tue Jun 6 09:46:40 2006 @@ -22,7 +22,7 @@ /images/chain-logo-white.png - 1.1-SNAPSHOT + 1.1-RC2 2003 Commons Chain An implmentation of the GoF Chain of Responsibility pattern Modified: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/xdocs/changes.xml?rev=412169&r1=412167&r2=412169&view=diff == --- jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/xdocs/changes.xml (original) +++ jakarta/commons/proper/chain/tags/CHAIN_1_1_RC2/xdocs/changes.xml Tue Jun 6 09:46:40 2006 @@ -38,7 +38,7 @@ - + http://svn.apache.org/viewvc?view=rev&revision=411948";>r 411948 Provide a Map of Cookies in the WebContext. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (CHAIN-12) [chain] ContextBase throws NotSerializable exception for PropertyDescriptor
[ http://issues.apache.org/jira/browse/CHAIN-12?page=comments#action_12414989 ] Niall Pemberton commented on CHAIN-12: -- Dennis Lundberg found that TestContextTestCase failed the serialization test with JDK 1.4.2_11 when checking out Chain 1.1 release candidate 1. This test passed with JDK 1.4.2_10 but fails with the later JDK and also JDK 1.3.1_04. Changing the static "placeholder" object for properties to be Seralizable appears to have fixed this: http://svn.apache.org/viewvc?view=rev&revision=412150 > [chain] ContextBase throws NotSerializable exception for PropertyDescriptor > --- > > Key: CHAIN-12 > URL: http://issues.apache.org/jira/browse/CHAIN-12 > Project: Commons Chain > Type: Bug > Versions: 1.0 Release > Environment: Operating System: other > Platform: Other > Reporter: Jeff Ramsdale > > It seems ContextBase is intended to be serializable ( > http://jakarta.apache.org/commons/chain/apidocs/serialized-form.html & > http://marc.10east.com/?l=jakarta-commons-user&m=111323289317819&w=2 ), but an > attempt to serialize a simple subclass throws the following: > java.io.NotSerializableException: java.beans.PropertyDescriptor > at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1054) > at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278) > at java.util.HashMap.writeObject(HashMap.java:978) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:324) > at > java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:809) > at > java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1296) > at > java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1247) > at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1052) > at > java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1332) > at > java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1304) > at > java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1247) > at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1052) > at > java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1332) > at > java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1304) > at > java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1247) > at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1052) > at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278) > at > net.sourceforge.cruisecontrol.ProjectTest.testDeserialization(ProjectTest.java:371) > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (CLI-13) [cli] CommandLine.getOptionValue() behaves contrary to docs
[ http://issues.apache.org/jira/browse/CLI-13?page=comments#action_12414988
]
Andrew Shirley commented on CLI-13:
---
moving this forward to cli2, you can use CommandLine#getValue(String) with "-d"
or "--debug" so this is fixed in cli2. I havn't looked at this problem in cli1
> [cli] CommandLine.getOptionValue() behaves contrary to docs
> ---
>
> Key: CLI-13
> URL: http://issues.apache.org/jira/browse/CLI-13
> Project: Commons CLI
> Type: Bug
> Versions: 1.0 Final
> Environment: Operating System: Linux
> Platform: PC
> Reporter: C Rose
>
> Hi
> If I have:
> final String debugOpt = "debug";
> Option debug = OptionBuilder
> .withArgName(debugOpt)
> .withDescription("turn on debugging")
> .withLongOpt(debugOpt)
> .create('d');
> and then later I do:
> String dbg = commandLine.getOptionValue(debugOpt);
> then dbg will be null. Instead, I have to use getOptionValue('d'). This seems
> contrary to the docs (see bottom of
> http://jakarta.apache.org/commons/cli/usage.html), which implies that I should
> be able to query the commandLine object using a full string, rather than just
> the string's first character.
> Can I suggest that the API of OptionBuilder be made clearer so that it is
> obvious that you can have long and short option names---perhaps make the
> create() method take no arguments (thus forcing long and short arg names to be
> set explicitly). (Also, there seems to be some confusion between the terms
> 'argument' and 'option' in the API, but perhaps that is just me).
> Also, I would hop to be able to query commandLine by either a single char or
> an
> entire string, as suggested by the docs.
> Thanks,
> Chris
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412167 - in /jakarta/commons/proper/chain/trunk: project.properties project.xml xdocs/building.xml xdocs/changes.xml
Author: niallp Date: Tue Jun 6 09:36:10 2006 New Revision: 412167 URL: http://svn.apache.org/viewvc?rev=412167&view=rev Log: Various minor changes for docs/build: - Add build instructions for JDK 1.3 and Changelog configuration - Make default changelog configuration show changes in the last year (Chain doesn't change much) - Update release notes to add missing revisions - Add commented out dependency for JDK 1.3 Modified: jakarta/commons/proper/chain/trunk/project.properties jakarta/commons/proper/chain/trunk/project.xml jakarta/commons/proper/chain/trunk/xdocs/building.xml jakarta/commons/proper/chain/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/chain/trunk/project.properties URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/project.properties?rev=412167&r1=412166&r2=412167&view=diff == --- jakarta/commons/proper/chain/trunk/project.properties (original) +++ jakarta/commons/proper/chain/trunk/project.properties Tue Jun 6 09:36:10 2006 @@ -19,6 +19,7 @@ #maven.repo.remote=http://www.ibiblio.org,http://maven-plugins.sf.net/maven maven.changelog.factory=org.apache.maven.svnlib.SvnChangeLogFactory maven.changes.issue.template=%URL%/browse/%ISSUE% +maven.changelog.range=365 maven.compile.source=1.3 maven.compile.target=1.3 Modified: jakarta/commons/proper/chain/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/project.xml?rev=412167&r1=412166&r2=412167&view=diff == --- jakarta/commons/proper/chain/trunk/project.xml (original) +++ jakarta/commons/proper/chain/trunk/project.xml Tue Jun 6 09:36:10 2006 @@ -132,6 +132,14 @@ junit 3.8.1 + commons-beanutils commons-beanutils Modified: jakarta/commons/proper/chain/trunk/xdocs/building.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/xdocs/building.xml?rev=412167&r1=412166&r2=412167&view=diff == --- jakarta/commons/proper/chain/trunk/xdocs/building.xml (original) +++ jakarta/commons/proper/chain/trunk/xdocs/building.xml Tue Jun 6 09:36:10 2006 @@ -46,6 +46,40 @@ Further details can be found in the http://jakarta.apache.org/commons/building.html";>commons build instructions. + + + The default configuration for the + http://maven.apache.org/maven-1.x/plugins/changelog/";>Changelog Report + is to show changes within the last year. If however you wish to see changes since a + specified date you can override the configuration by adding a build.properties + file to the Commons Chain directory. For example to show all the changes since the + Chain 1.0 release, you would have the following in the build.properties: + + + + Unfortunately, an issue with Subversion imports means that this report will only pick + up changes since the last import - which in the case of the ASF repository was December 2005. + If you require the changelog report to show changes prior to December 2005 for Commons Chain + then you can use the workaround described + http://www.niallp.pwp.blueyonder.co.uk/ChangelogSubversionIssue.html";>here. + + + + + Commons Chain can be built using JDK 1.3 - however you will need to modify the + project.xml to add an additional dependency for xml apis: + + + Modified: jakarta/commons/proper/chain/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/xdocs/changes.xml?rev=412167&r1=412166&r2=412167&view=diff == --- jakarta/commons/proper/chain/trunk/xdocs/changes.xml (original) +++ jakarta/commons/proper/chain/trunk/xdocs/changes.xml Tue Jun 6 09:36:10 2006 @@ -40,9 +40,11 @@ + http://svn.apache.org/viewvc?view=rev&revision=411948";>r 411948 Provide a Map of Cookies in the WebContext. + http://svn.apache.org/viewvc?view=rev&revision=411893";>r 411893 Remove Static Log instances - see http://wiki.apache.org/jakarta-commons/Logging/StaticLog";>here. @@ -78,7 +80,8 @@ - http://svn.apache.org/viewvc?view=rev&revision=161600";>r 161600 + http://svn.apache.org/viewvc?view=rev&revision=161600";>r 161600 and + http://svn.apache.org/viewvc?view=rev&revision=412150";>r 412150 Make ContextBase live up to the Serializable contract that it inherits by virtue of extending HashMap. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412150 - in /jakarta/commons/proper/chain/trunk: src/java/org/apache/commons/chain/impl/ContextBase.java xdocs/changes.xml
Author: niallp
Date: Tue Jun 6 08:31:50 2006
New Revision: 412150
URL: http://svn.apache.org/viewvc?rev=412150&view=rev
Log:
Further fix for CHAIN-12 - Using JDK 1.4.2_10 ContextBase can be serialized,
but JDK 1.4.2_11 (and 1.3.1_04) fail trying to serialize - thanks to Dennis
Lundberg for spotting this.
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/impl/ContextBase.java
jakarta/commons/proper/chain/trunk/xdocs/changes.xml
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/impl/ContextBase.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/impl/ContextBase.java?rev=412150&r1=412149&r2=412150&view=diff
==
---
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/impl/ContextBase.java
(original)
+++
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/impl/ContextBase.java
Tue Jun 6 08:31:50 2006
@@ -27,6 +27,7 @@
import java.util.Iterator;
import java.util.Map;
import java.util.Set;
+import java.io.Serializable;
import org.apache.commons.chain.Context;
@@ -120,7 +121,7 @@
static {
-singleton = new Object() {
+singleton = new Serializable() {
public boolean equals(Object object) {
return (false);
}
Modified: jakarta/commons/proper/chain/trunk/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/xdocs/changes.xml?rev=412150&r1=412149&r2=412150&view=diff
==
--- jakarta/commons/proper/chain/trunk/xdocs/changes.xml (original)
+++ jakarta/commons/proper/chain/trunk/xdocs/changes.xml Tue Jun 6 08:31:50
2006
@@ -75,7 +75,9 @@
http://svn.apache.org/viewvc?view=rev&revision=178563";>r
178563
Decouple CatalogFactory lookup from LookupAction.
-
+
+
+
http://svn.apache.org/viewvc?view=rev&revision=161600";>r
161600
Make ContextBase live up to the Serializable contract that it
inherits by virtue of extending HashMap.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-263) [lang] Add StringUtils.containsIgnoreCase(...)
[
http://issues.apache.org/jira/browse/LANG-263?page=comments#action_12414966 ]
analogue commented on LANG-263:
---
/**
* Checks if String contains a search String irrespective of case,
* handling null. This method uses
* [EMAIL PROTECTED] #contains(String, String)}.
*
* A null String will return false.
*
*
* StringUtils.contains(null, *) = false
* StringUtils.contains(*, null) = false
* StringUtils.contains("", "") = true
* StringUtils.contains("abc", "") = true
* StringUtils.contains("abc", "a") = true
* StringUtils.contains("abc", "z") = false
* StringUtils.contains("abc", "A") = true
* StringUtils.contains("abc", "Z") = false
*
*
* @param str the String to check, may be null
* @param searchStr the String to find, may be null
* @return true if the String contains the search String irrespective of
* case or false if not or null string input
*/
public static boolean containsIgnoreCase(String str, String searchStr) {
if (str == null || searchStr == null) {
return false;
}
return contains(str.toUpperCase(), searchStr.toUpperCase());
}
public void testContainsIgnoreCase_StringString() {
assertFalse(StringUtils.containsIgnoreCase(null, null));
// Null tests
assertFalse(StringUtils.containsIgnoreCase(null, ""));
assertFalse(StringUtils.containsIgnoreCase(null, "a"));
assertFalse(StringUtils.containsIgnoreCase(null, "abc"));
assertFalse(StringUtils.containsIgnoreCase("", null));
assertFalse(StringUtils.containsIgnoreCase("a", null));
assertFalse(StringUtils.containsIgnoreCase("abc", null));
// Match len = 0
assertTrue(StringUtils.containsIgnoreCase("", ""));
assertTrue(StringUtils.containsIgnoreCase("a", ""));
assertTrue(StringUtils.containsIgnoreCase("abc", ""));
// Match len = 1
assertFalse(StringUtils.containsIgnoreCase("", "a"));
assertTrue(StringUtils.containsIgnoreCase("a", "a"));
assertTrue(StringUtils.containsIgnoreCase("abc", "a"));
assertFalse(StringUtils.containsIgnoreCase("", "A"));
assertTrue(StringUtils.containsIgnoreCase("a", "A"));
assertTrue(StringUtils.containsIgnoreCase("abc", "A"));
// Match len > 1
assertFalse(StringUtils.containsIgnoreCase("", "abc"));
assertFalse(StringUtils.containsIgnoreCase("a", "abc"));
assertTrue(StringUtils.containsIgnoreCase("xabcz", "abc"));
assertFalse(StringUtils.containsIgnoreCase("", "ABC"));
assertFalse(StringUtils.containsIgnoreCase("a", "ABC"));
assertTrue(StringUtils.containsIgnoreCase("xabcz", "ABC"));
}
> [lang] Add StringUtils.containsIgnoreCase(...)
> --
>
> Key: LANG-263
> URL: http://issues.apache.org/jira/browse/LANG-263
> Project: Commons Lang
> Type: New Feature
> Reporter: analogue
> Priority: Minor
> Fix For: 3.0
>
> To complement StringUtils.equalsIgnoreCase(...),
> StringUtils.containsIgnoreCase(...) would be quite useful. A simple
> implementation would uppercase both strings and delegate to
> StringUtils.contains(...).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (CLI-18) [cli] HelpFormatter.printHelp(String cmdLineSyntax, String header, Options options, String footer) throws exception if footer contains CR LF
[ http://issues.apache.org/jira/browse/CLI-18?page=all ] Andrew Shirley updated CLI-18: -- Attachment: BugCLI18Test.java passing junit test for cli2 > [cli] HelpFormatter.printHelp(String cmdLineSyntax, String header, Options > options, String footer) throws exception if footer contains CR LF > > > Key: CLI-18 > URL: http://issues.apache.org/jira/browse/CLI-18 > Project: Commons CLI > Type: Bug > Versions: 1.0 Final > Environment: Operating System: All > Platform: PC > Reporter: Neboja > Attachments: BugCLI18Test.java, BugCLI18Test.java > > If String footer contains windows new line, printHelp throws exception. > If it contains only LF line endings, it works fine on Linux and Windows > platforms. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] Version 1.1 release candidate 1
Secondly, I've tried to build the RC from source using Maven and I get a test failure in TestContextTestCase. The build still succeeds though. I'm using Sun JDK 1.4.2_11 on Windows XP Pro, if it is of importance. Here are the details in the test-report: Testsuite: org.apache.commons.chain.impl.TestContextTestCase Tests run: 10, Failures: 0, Errors: 1, Time elapsed: 0,625 sec running "maven dist" from SVN head: [junit] Running org.apache.commons.chain.impl.TestContextTestCase [junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 3.196 sec (3.196 sec! Time to get the company to upgrade my hardware!) Finally, I am not getting the same changelog-report as you do. Are you using a local project.properties file for this? If so, and that is the way it should be, then a note about it in xdocs/building.xml would be nice. hm. I seem to get the same, except for some reason the alternating row background colors start on opposite colors on my local build and in Niall's! That and I have a few places where there's a stray space character in the middle of a commit message -- but maybe that's a network issue or something? just another report... Joe -- Joe Germuska [EMAIL PROTECTED] * http://blog.germuska.com "You really can't burn anything out by trying something new, and even if you can burn it out, it can be fixed. Try something new." -- Robert Moog - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MATH-151) MathUtils.round incorrect result
[ http://issues.apache.org/jira/browse/MATH-151?page=comments#action_12414956 ] Phil Steitz commented on MATH-151: -- Thanks for reporting this bug. Could be we want to reconsider the changes applied to address http://issues.apache.org/jira/browse/MATH-32. Patches welcome! > MathUtils.round incorrect result > > > Key: MATH-151 > URL: http://issues.apache.org/jira/browse/MATH-151 > Project: Commons Math > Type: Bug > Versions: 1.1 Final > Environment: Win2K, Sun JDK1.5.0_05 b05 > Reporter: Buza Zoltán > > MathUtils.round(39.245, 2) results 39.24, however it should be 39.25, with > default rounding mode BigDecimal.ROUND_HALF_UP. > I found that internally MathUtils.round multiplies the given number by > 10^scale. > 39.245 * 100.0 results 3924.4...5 , and after this the calculation is > not correct any more. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (CLI-18) [cli] HelpFormatter.printHelp(String cmdLineSyntax, String header, Options options, String footer) throws exception if footer contains CR LF
[ http://issues.apache.org/jira/browse/CLI-18?page=all ] Andrew Shirley updated CLI-18: -- Attachment: BugCLI18Test.java passing junit test for cli > [cli] HelpFormatter.printHelp(String cmdLineSyntax, String header, Options > options, String footer) throws exception if footer contains CR LF > > > Key: CLI-18 > URL: http://issues.apache.org/jira/browse/CLI-18 > Project: Commons CLI > Type: Bug > Versions: 1.0 Final > Environment: Operating System: All > Platform: PC > Reporter: Neboja > Attachments: BugCLI18Test.java > > If String footer contains windows new line, printHelp throws exception. > If it contains only LF line endings, it works fine on Linux and Windows > platforms. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (CLI-18) [cli] HelpFormatter.printHelp(String cmdLineSyntax, String header, Options options, String footer) throws exception if footer contains CR LF
[ http://issues.apache.org/jira/browse/CLI-18?page=comments#action_12414954 ] Andrew Shirley commented on CLI-18: --- I tried to write a JUnit test case for this and couldn't reproduce it for either cli or cli2. I was working on the latest svn on a linux desktop. I will attach my unittests for others to try in other environments. > [cli] HelpFormatter.printHelp(String cmdLineSyntax, String header, Options > options, String footer) throws exception if footer contains CR LF > > > Key: CLI-18 > URL: http://issues.apache.org/jira/browse/CLI-18 > Project: Commons CLI > Type: Bug > Versions: 1.0 Final > Environment: Operating System: All > Platform: PC > Reporter: Neboja > > If String footer contains windows new line, printHelp throws exception. > If it contains only LF line endings, it works fine on Linux and Windows > platforms. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] Version 1.1 release candidate 1
Niall Pemberton wrote: Release candidate 1 for Chain 1,1 is available for review: http://people.apache.org/~niallp/commons-chain/ Release notes for version 1.1 are here: http://people.apache.org/~niallp/commons-chain/site/changes-report.html New version of the chain site: http://people.apache.org/~niallp/commons-chain/site/ All feedback on this release candidate build is welcome. Niall, three things: Firstly we might have to revert the groupId change in the project.xml file. I've done some testing and I'm waiting for some guidance from Brett on how to proceed. Secondly, I've tried to build the RC from source using Maven and I get a test failure in TestContextTestCase. The build still succeeds though. I'm using Sun JDK 1.4.2_11 on Windows XP Pro, if it is of importance. Here are the details in the test-report: Testsuite: org.apache.commons.chain.impl.TestContextTestCase Tests run: 10, Failures: 0, Errors: 1, Time elapsed: 0,625 sec Testcase: testSeriaization(org.apache.commons.chain.impl.TestContextTestCase): Caused an ERROR org.apache.commons.chain.impl.ContextBase$1 java.io.NotSerializableException: org.apache.commons.chain.impl.ContextBase$1 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1054) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278) at java.util.HashMap.writeObject(HashMap.java:986) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:809) at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1296) at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1247) at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1052) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278) at org.apache.commons.chain.impl.ContextBaseTestCase.testSeriaization(ContextBaseTestCase.java:367) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) Finally, I am not getting the same changelog-report as you do. Are you using a local project.properties file for this? If so, and that is the way it should be, then a note about it in xdocs/building.xml would be nice. -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412107 - in /jakarta/commons/proper/jelly/trunk: jelly-tags/tag-project.xml parent-project.xml xdocs/changes.xml
Author: polx
Date: Tue Jun 6 05:39:23 2006
New Revision: 412107
URL: http://svn.apache.org/viewvc?rev=412107&view=rev
Log:
Moving to dom4j 1.6.1 and jaxen 1.1-beta-8.
paul
Modified:
jakarta/commons/proper/jelly/trunk/jelly-tags/tag-project.xml
jakarta/commons/proper/jelly/trunk/parent-project.xml
jakarta/commons/proper/jelly/trunk/xdocs/changes.xml
Modified: jakarta/commons/proper/jelly/trunk/jelly-tags/tag-project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/jelly-tags/tag-project.xml?rev=412107&r1=412106&r2=412107&view=diff
==
--- jakarta/commons/proper/jelly/trunk/jelly-tags/tag-project.xml (original)
+++ jakarta/commons/proper/jelly/trunk/jelly-tags/tag-project.xml Tue Jun 6
05:39:23 2006
@@ -36,7 +36,7 @@
Commons Jelly Tag Library
http://jakarta.apache.org/commons/jelly/libs/${pom.id.substring(33)}/index.html
-
http://issues.apache.org/jira/secure/BrowseProject.jspa?id=10012
+
http://issues.apache.org/jira/browse/JELLY
cvs.apache.org
/www/jakarta.apache.org/commons/jelly/libs/${pom.id.substring(33)}/
@@ -286,7 +286,7 @@
dom4j
dom4j
- 1.5
+ 1.6.1
Modified: jakarta/commons/proper/jelly/trunk/parent-project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/parent-project.xml?rev=412107&r1=412106&r2=412107&view=diff
==
--- jakarta/commons/proper/jelly/trunk/parent-project.xml (original)
+++ jakarta/commons/proper/jelly/trunk/parent-project.xml Tue Jun 6 05:39:23
2006
@@ -69,7 +69,7 @@
dom4j
dom4j
- 1.5.2
+ 1.6.1
Modified: jakarta/commons/proper/jelly/trunk/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/xdocs/changes.xml?rev=412107&r1=412106&r2=412107&view=diff
==
--- jakarta/commons/proper/jelly/trunk/xdocs/changes.xml (original)
+++ jakarta/commons/proper/jelly/trunk/xdocs/changes.xml Tue Jun 6 05:39:23
2006
@@ -26,6 +26,7 @@
Restored JellyContext.isCacheTags and
its behavior for backwards compatibility
+ Moved to dom4j 1.6.1 and jaxen
1.1-beta-8
Improve tag caching
to improve memory consumption
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (IO-69) Add conditional file filters
[ http://issues.apache.org/jira/browse/IO-69?page=all ] Stephen Colebourne closed IO-69: > Add conditional file filters > > > Key: IO-69 > URL: http://issues.apache.org/jira/browse/IO-69 > Project: Commons IO > Type: Improvement > Versions: 1.0 Final > Environment: Operating System: All > Platform: All > Reporter: Steven Caswell > Priority: Minor > Fix For: 1.1 Final > Attachments: ConditionalAndFileFilter.java, > ConditionalAndFileFilterTestCase.java, ConditionalFileFilter.java, > ConditionalFileFilterAbstractTestCase.java, ConditionalOrFileFilter.java, > ConditionalOrFileFilterTestCase.java, IOFileFilterAbstractTestCase.java > > I am submitting as a donation two IOFileFilters: ConditionalAndFileFilter and > ConditionalOrFileFilter. Each take a list of IOFileFilters and performs a > conditional AND or OR, mirroring the functionality of the && and || operators. > I'm including test cases. Attachements to follow. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (IO-80) LineIterator should implement java.util.Iterator
[ http://issues.apache.org/jira/browse/IO-80?page=all ] Stephen Colebourne updated IO-80: - Fix Version: 1.3 > LineIterator should implement java.util.Iterator > > > Key: IO-80 > URL: http://issues.apache.org/jira/browse/IO-80 > Project: Commons IO > Type: Improvement > Versions: 1.2 Final > Reporter: Jörg Gottschling > Priority: Minor > Fix For: 1.3 > > I think the summary describes it all. I do not understand why this class does > not implement Iterator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (IO-69) Add conditional file filters
[ http://issues.apache.org/jira/browse/IO-69?page=all ] Stephen Colebourne updated IO-69: - Bugzilla Id: (was: 30705) Fix Version: 1.1 Final Version: 1.0 Final (was: 1.0.1 Final) Updating versions > Add conditional file filters > > > Key: IO-69 > URL: http://issues.apache.org/jira/browse/IO-69 > Project: Commons IO > Type: Improvement > Versions: 1.0 Final > Environment: Operating System: All > Platform: All > Reporter: Steven Caswell > Priority: Minor > Fix For: 1.1 Final > Attachments: ConditionalAndFileFilter.java, > ConditionalAndFileFilterTestCase.java, ConditionalFileFilter.java, > ConditionalFileFilterAbstractTestCase.java, ConditionalOrFileFilter.java, > ConditionalOrFileFilterTestCase.java, IOFileFilterAbstractTestCase.java > > I am submitting as a donation two IOFileFilters: ConditionalAndFileFilter and > ConditionalOrFileFilter. Each take a list of IOFileFilters and performs a > conditional AND or OR, mirroring the functionality of the && and || operators. > I'm including test cases. Attachements to follow. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (IO-58) Add new WildcardFilter class
[ http://issues.apache.org/jira/browse/IO-58?page=all ] Stephen Colebourne closed IO-58: > Add new WildcardFilter class > > > Key: IO-58 > URL: http://issues.apache.org/jira/browse/IO-58 > Project: Commons IO > Type: Improvement > Versions: 1.0 Final > Environment: Operating System: other > Platform: Other > Reporter: Jason Anderson > Priority: Minor > Fix For: 1.1 Final > Attachments: FileFilterTestCase.java, TestWildcardUtils.java, > WildcardFilter.java, WildcardUtils.java > > WildcardFilter will allow file filter(s) to be specified using the familiar > wildcard symbols * and ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (IO-58) Add new WildcardFilter class
[ http://issues.apache.org/jira/browse/IO-58?page=all ] Stephen Colebourne updated IO-58: - Bugzilla Id: (was: 31115) Fix Version: 1.1 Final Version: 1.0 Final (was: 1.0.1 Final) Updating fix version > Add new WildcardFilter class > > > Key: IO-58 > URL: http://issues.apache.org/jira/browse/IO-58 > Project: Commons IO > Type: Improvement > Versions: 1.0 Final > Environment: Operating System: other > Platform: Other > Reporter: Jason Anderson > Priority: Minor > Fix For: 1.1 Final > Attachments: FileFilterTestCase.java, TestWildcardUtils.java, > WildcardFilter.java, WildcardUtils.java > > WildcardFilter will allow file filter(s) to be specified using the familiar > wildcard symbols * and ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (IO-34) [io] FileSystemUtils returns incorrect free space on Linux
[ http://issues.apache.org/jira/browse/IO-34?page=all ] Stephen Colebourne updated IO-34: - Bugzilla Id: (was: 38574) Fix Version: 1.2 Final Version: 1.1 Final (was: 1.1.0) > [io] FileSystemUtils returns incorrect free space on Linux > -- > > Key: IO-34 > URL: http://issues.apache.org/jira/browse/IO-34 > Project: Commons IO > Type: Bug > Versions: 1.1 Final > Environment: Operating System: Linux > Platform: Other > Reporter: Niall Gallagher > Fix For: 1.2 Final > > Re: Commons-IO class FileSystemUtils > The method freeSpace(String path) returns free disk space in bytes on Windows, > and returns free disk space in kilobytes (not bytes) on Linux (possibly Unix / > Mac OS etc. also). > The internal method freeSpaceUnix javadoc reads "Find free space on the *nix > platform using the 'df' command." The value returned by df is read in to a > variable called bytes and returned. Man pages for df on Linux (Fedora Core 4) > read "Disk space is shown in 1K blocks by default". So method > freeSpaceUnix is returning the number of kilobytes free space, not bytes. > A simple fix could be to add line "bytes = bytes * 1024;" after bytes are > read in. > The javadocs for this class could be improved also. Comment "@return the > amount > of free drive space on the volume" could read "@return the amount of free > drive > space on the volume in bytes". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (IO-34) [io] FileSystemUtils returns incorrect free space on Linux
[ http://issues.apache.org/jira/browse/IO-34?page=all ] Stephen Colebourne closed IO-34: Resolution: Fixed > [io] FileSystemUtils returns incorrect free space on Linux > -- > > Key: IO-34 > URL: http://issues.apache.org/jira/browse/IO-34 > Project: Commons IO > Type: Bug > Versions: 1.1 Final > Environment: Operating System: Linux > Platform: Other > Reporter: Niall Gallagher > Fix For: 1.2 Final > > Re: Commons-IO class FileSystemUtils > The method freeSpace(String path) returns free disk space in bytes on Windows, > and returns free disk space in kilobytes (not bytes) on Linux (possibly Unix / > Mac OS etc. also). > The internal method freeSpaceUnix javadoc reads "Find free space on the *nix > platform using the 'df' command." The value returned by df is read in to a > variable called bytes and returned. Man pages for df on Linux (Fedora Core 4) > read "Disk space is shown in 1K blocks by default". So method > freeSpaceUnix is returning the number of kilobytes free space, not bytes. > A simple fix could be to add line "bytes = bytes * 1024;" after bytes are > read in. > The javadocs for this class could be improved also. Comment "@return the > amount > of free drive space on the volume" could read "@return the amount of free > drive > space on the volume in bytes". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Reopened: (IO-34) [io] FileSystemUtils returns incorrect free space on Linux
[ http://issues.apache.org/jira/browse/IO-34?page=all ] Stephen Colebourne reopened IO-34: -- Reopening to change versions > [io] FileSystemUtils returns incorrect free space on Linux > -- > > Key: IO-34 > URL: http://issues.apache.org/jira/browse/IO-34 > Project: Commons IO > Type: Bug > Versions: 1.1 Final > Environment: Operating System: Linux > Platform: Other > Reporter: Niall Gallagher > Fix For: 1.2 Final > > Re: Commons-IO class FileSystemUtils > The method freeSpace(String path) returns free disk space in bytes on Windows, > and returns free disk space in kilobytes (not bytes) on Linux (possibly Unix / > Mac OS etc. also). > The internal method freeSpaceUnix javadoc reads "Find free space on the *nix > platform using the 'df' command." The value returned by df is read in to a > variable called bytes and returned. Man pages for df on Linux (Fedora Core 4) > read "Disk space is shown in 1K blocks by default". So method > freeSpaceUnix is returning the number of kilobytes free space, not bytes. > A simple fix could be to add line "bytes = bytes * 1024;" after bytes are > read in. > The javadocs for this class could be improved also. Comment "@return the > amount > of free drive space on the volume" could read "@return the amount of free > drive > space on the volume in bytes". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 14 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-06062006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-06062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54)
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 14 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-06062006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-06062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54)
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 14 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 16 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-06062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Jun 6, 2006 4:31:06 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 14 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 16 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-06062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Jun 6, 2006 4:31:06 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.
[jira] Commented: (IO-80) LineIterator should implement java.util.Iterator
[ http://issues.apache.org/jira/browse/IO-80?page=comments#action_12414941 ] Stephen Colebourne commented on IO-80: -- Oops. It was supposed to... > LineIterator should implement java.util.Iterator > > > Key: IO-80 > URL: http://issues.apache.org/jira/browse/IO-80 > Project: Commons IO > Type: Improvement > Versions: 1.2 Final > Reporter: Jörg Gottschling > Priority: Minor > > I think the summary describes it all. I do not understand why this class does > not implement Iterator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 14 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-06062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] Root cause [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-classes/org/apache/commons/jelly/jsl/suite.jelly:123:89: You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.Temp
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 14 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-06062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-06062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-06062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] Root cause [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-classes/org/apache/commons/jelly/jsl/suite.jelly:123:89: You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.Temp
[jira] Created: (IO-80) LineIterator should implement java.util.Iterator
LineIterator should implement java.util.Iterator Key: IO-80 URL: http://issues.apache.org/jira/browse/IO-80 Project: Commons IO Type: Improvement Versions: 1.2 Final Reporter: Jörg Gottschling Priority: Minor I think the summary describes it all. I do not understand why this class does not implement Iterator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412047 - in /jakarta/commons/proper/httpclient/trunk/src: java/org/apache/commons/httpclient/methods/ test/org/apache/commons/httpclient/ test/org/apache/commons/httpclient/auth/
Author: olegk
Date: Tue Jun 6 01:50:08 2006
New Revision: 412047
URL: http://svn.apache.org/viewvc?rev=412047&view=rev
Log:
[HTTPCLIENT-536] misleading lack of javadoc in StringRequestEntity
Contributed by Oleg Kalnichevski
Reviewed by Roland Weber
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/EntityEnclosingMethod.java
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/StringRequestEntity.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestConnectionPersistence.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestEntityEnclosingMethod.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestNoncompliant.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestPostMethod.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestPostParameterEncoding.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestProxy.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestRedirects.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/auth/TestBasicAuth.java
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/EntityEnclosingMethod.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/EntityEnclosingMethod.java?rev=412047&r1=412046&r2=412047&view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/EntityEnclosingMethod.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/EntityEnclosingMethod.java
Tue Jun 6 01:50:08 2006
@@ -189,8 +189,11 @@
if (LOG.isWarnEnabled()) {
LOG.warn(charset + " not supported");
}
-this.requestEntity = new StringRequestEntity(
-requestString);
+try {
+this.requestEntity = new StringRequestEntity(
+requestString, null, null);
+} catch (UnsupportedEncodingException ignore) {
+}
}
}
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/StringRequestEntity.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/StringRequestEntity.java?rev=412047&r1=412046&r2=412047&view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/StringRequestEntity.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/methods/StringRequestEntity.java
Tue Jun 6 01:50:08 2006
@@ -1,5 +1,5 @@
/*
- * $Header:
/home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//httpclient/src/java/org/apache/commons/httpclient/methods/StringRequestEntity.java,v
1.3 2004/07/03 14:27:03 olegk Exp $
+ * $HeadURL$
* $Revision$
* $Date$
*
@@ -58,16 +58,11 @@
* will use the default platform charset to convert the content string
* and will provide no content type.
*
- * This constructor may be deprecated or changed to use the
- * default HTTP content charset (ISO-8859-1) in the release 3.1
- *
- * It is strongly recommended to use
- * [EMAIL PROTECTED] #StringRequestEntity(String, String, String)}
constructor
- * instead.
- *
* @see #StringRequestEntity(String, String, String)
*
* @param content The content to set.
+ *
+ * @deprecated use [EMAIL PROTECTED] #StringRequestEntity(String, String,
String)} instead
*/
public StringRequestEntity(String content) {
super();
Modified:
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestConnectionPersistence.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestConnectionPersistence.java?rev=412047&r1=412046&r2=412047&view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestConnectionPersistence.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestConnectionPersistence.java
Tue Jun 6 01:50:08 2006
@@ -78,7 +78,7 @@
this.client.setHttpConnectionManager(connman);
PostMethod httppost = new Post
[all] Board report time
Could the following components gain entries in the board report: Commons Collections Commons Logging Commons Pool Commons SCXML http://wiki.apache.org/jakarta/JakartaBoardReport-June2006 See previous quarters for a feel as to what to talk about. Primarily it is the release (or promotion in SCXML's case), but any other info is good. http://jakarta.apache.org/site/pmc/board-reports.html Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
