Re: [darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread Pascal Obry
Le vendredi 16 novembre 2018 à 15:25 -0700, Alan Lundin a écrit :
> Is there some reason the aspect ratio can't be specified with two
> input boxes:  x : y ?

That's already possible : x / y

See the manual.

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread Alan Lundin
Is there some reason the aspect ratio can't be specified with two
input boxes:  x : y ?

Then the person could imput 16 : 9   or   1. : 1   or  8 : 4.5
-- however they preferred.  [ And if they wanted it rotated, then
9 : 16 .]

Personally, I'd prefer the flexibility over the convenience.

--alan

* August Schwerdfeger (aug...@schwerdfeger.name) [181116 14:22]:
* Subject: Re: [darktable-dev] Feature request (Cropping module GUI):
> The problem with selecting these integers based on commonly-used aspect
> ratios, is that the only real use for this feature would be in "freehand"
> mode when cropping to an *unusual* aspect ratio; the common ones like 16:9
> are represented in the "aspect" combo box and it is much easier to select
> the "16:9, HDTV" option to constrain the ratio.
> 
> --
> August Schwerdfeger
> aug...@schwerdfeger.name
> 
> On Fri, Nov 16, 2018 at 2:51 PM Jan Ingwer Baer  wrote:
> 
> > On 16-Nov-18 18:26, Heiko Bauke wrote:
> > > Hi,
> > >
> > > Am Freitag, 16. November 2018 schrieb Jan Ingwer Baer:
> > >> If DT shows the aspect ratio it should try to find the nearest integral
> > >> fraction (of course with values below 30) like 3:2, 16:9, ...
> > >>
> > >>
> > >> For your exampel it should show 8.2:5, or it should use one of the
> > >> common denominators x:2, x:3, x:4, x:9 ...
> > >
> > > I don't think that this is a good idea, as the user can not know how
> > close the actual aspect ratio is to the approximate value that is indicated
> > in the UI.
> > >
> > > Heiko
> > >
> > Of course DT should not round, but it should show the Ratio with an
> > integer for the small-side. For me showing 8.2/5 or 3.28/2 (with the
> > pixel-ratio of the OP) is much more meaningful then 1.62/1. I think it
> > should be possible to select a usable integer numerator/denominator
> > based on the fractional ratio.
> >
> > If the user wants to create a crop with one of the common aspect ratios
> > showing it as simple float makes it very challenging to find the right
> > values. For example : The user wants to create a crop with 16/9.
> > Displaying the aspect ratio as 1.77/1 is not a big help.
> >
> > The challenge is to find the right integer. My idea is to define ratio
> > ranges for selection :
> >
> > 1.2 - 1.4 : set denominator to 3 gives  3.6/3 -  4.2/3 ( ~4/3)
> > 1.4 - 1.6 : set denominator to 2 gives  2.8/2 -  3.2/2 ( ~3/2)
> > 1.6 - 1.9 : set denominator to 9 gives 14.4/9 - 17.1/9 (~16/9)
> >
> >
> > ___
> > darktable developer mailing list
> > to unsubscribe send a mail to
> > darktable-dev+unsubscr...@lists.darktable.org
> >
> >
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread August Schwerdfeger
The problem with selecting these integers based on commonly-used aspect
ratios, is that the only real use for this feature would be in "freehand"
mode when cropping to an *unusual* aspect ratio; the common ones like 16:9
are represented in the "aspect" combo box and it is much easier to select
the "16:9, HDTV" option to constrain the ratio.

--
August Schwerdfeger
aug...@schwerdfeger.name

On Fri, Nov 16, 2018 at 2:51 PM Jan Ingwer Baer  wrote:

> On 16-Nov-18 18:26, Heiko Bauke wrote:
> > Hi,
> >
> > Am Freitag, 16. November 2018 schrieb Jan Ingwer Baer:
> >> If DT shows the aspect ratio it should try to find the nearest integral
> >> fraction (of course with values below 30) like 3:2, 16:9, ...
> >>
> >>
> >> For your exampel it should show 8.2:5, or it should use one of the
> >> common denominators x:2, x:3, x:4, x:9 ...
> >
> > I don't think that this is a good idea, as the user can not know how
> close the actual aspect ratio is to the approximate value that is indicated
> in the UI.
> >
> > Heiko
> >
> Of course DT should not round, but it should show the Ratio with an
> integer for the small-side. For me showing 8.2/5 or 3.28/2 (with the
> pixel-ratio of the OP) is much more meaningful then 1.62/1. I think it
> should be possible to select a usable integer numerator/denominator
> based on the fractional ratio.
>
> If the user wants to create a crop with one of the common aspect ratios
> showing it as simple float makes it very challenging to find the right
> values. For example : The user wants to create a crop with 16/9.
> Displaying the aspect ratio as 1.77/1 is not a big help.
>
> The challenge is to find the right integer. My idea is to define ratio
> ranges for selection :
>
> 1.2 - 1.4 : set denominator to 3 gives  3.6/3 -  4.2/3 ( ~4/3)
> 1.4 - 1.6 : set denominator to 2 gives  2.8/2 -  3.2/2 ( ~3/2)
> 1.6 - 1.9 : set denominator to 9 gives 14.4/9 - 17.1/9 (~16/9)
>
>
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread Jan Ingwer Baer

On 16-Nov-18 18:26, Heiko Bauke wrote:

Hi,

Am Freitag, 16. November 2018 schrieb Jan Ingwer Baer:

If DT shows the aspect ratio it should try to find the nearest integral
fraction (of course with values below 30) like 3:2, 16:9, ...


For your exampel it should show 8.2:5, or it should use one of the
common denominators x:2, x:3, x:4, x:9 ...


I don't think that this is a good idea, as the user can not know how close the 
actual aspect ratio is to the approximate value that is indicated in the UI.

Heiko

Of course DT should not round, but it should show the Ratio with an 
integer for the small-side. For me showing 8.2/5 or 3.28/2 (with the 
pixel-ratio of the OP) is much more meaningful then 1.62/1. I think it 
should be possible to select a usable integer numerator/denominator 
based on the fractional ratio.


If the user wants to create a crop with one of the common aspect ratios 
showing it as simple float makes it very challenging to find the right 
values. For example : The user wants to create a crop with 16/9. 
Displaying the aspect ratio as 1.77/1 is not a big help.


The challenge is to find the right integer. My idea is to define ratio 
ranges for selection :


1.2 - 1.4 : set denominator to 3 gives  3.6/3 -  4.2/3 ( ~4/3)
1.4 - 1.6 : set denominator to 2 gives  2.8/2 -  3.2/2 ( ~3/2)
1.6 - 1.9 : set denominator to 9 gives 14.4/9 - 17.1/9 (~16/9)


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Color picker and history again

2018-11-16 Thread Pascal Obry
Alexander,

> Current git has problems with active color picker (B/W module) and 
> history stack again.

Can you be more precise? I've certainly missed the previous discussion.
What the problems?

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Color picker and history again

2018-11-16 Thread Alexander Rabtchevich

Hello

Current git has problems with active color picker (B/W module) and 
history stack again.



With respect,
Alexander Rabtchevich
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread Pascal Obry
Le vendredi 16 novembre 2018 à 18:46 +0100, Andreas Schneider a écrit :
> The issue is gone if I disable OpenCL ...

Which is even more surprising since I do use OpenCL!

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread Andreas Schneider
On Friday, 16 November 2018 18:36:07 CET Pascal Obry wrote:
> Hu Andreas,

Hey!
 
> I cannot reproduce! Do you have this with all pictures or some only?
> What settings you're using? This module has not been changed recently.
> Any other module activated that could create bad interaction?

The issue is gone if I disable OpenCL ...


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread rawfiner
Hi
It seems that Aurélien reported this issue:
https://redmine.darktable.org/issues/12349
rawfiner

Le vendredi 16 novembre 2018, Pascal Obry  a écrit :

> Hu Andreas,
>
> > the local contrast laplacian filter doesn't work anymore, it produces
> halos
> > and strange artifacts. Here is just one example image showing the issue:
> >
> > https://xor.cryptomilk.org/darktable/dt_local_contrast_laplacian.jpg
> >
> > Was perfectly fine some days ago.
>
> I cannot reproduce! Do you have this with all pictures or some only?
> What settings you're using? This module has not been changed recently.
> Any other module activated that could create bad interaction?
>
> Thanks,
>
> --
>   Pascal Obry /  Magny Les Hameaux (78)
>
>   The best way to travel is by means of imagination
>
>   http://www.obry.net
>
>   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread Pascal Obry
Hu Andreas,

> the local contrast laplacian filter doesn't work anymore, it produces halos 
> and strange artifacts. Here is just one example image showing the issue:
> 
> https://xor.cryptomilk.org/darktable/dt_local_contrast_laplacian.jpg
> 
> Was perfectly fine some days ago.

I cannot reproduce! Do you have this with all pictures or some only?
What settings you're using? This module has not been changed recently.
Any other module activated that could create bad interaction?

Thanks,

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread Heiko Bauke
Hi,

Am Freitag, 16. November 2018 schrieb Jan Ingwer Baer:
> If DT shows the aspect ratio it should try to find the nearest integral 
> fraction (of course with values below 30) like 3:2, 16:9, ...
> 
> 
> For your exampel it should show 8.2:5, or it should use one of the 
> common denominators x:2, x:3, x:4, x:9 ...

I don't think that this is a good idea, as the user can not know how close the 
actual aspect ratio is to the approximate value that is indicated in the UI.

Heiko

-- 
-- Number Crunch Blog @ https://www.numbercrunch.de
--  Cluster Computing @ https://www.clustercomputing.de
--  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.or

[darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread Andreas Schneider
Hi,

the local contrast laplacian filter doesn't work anymore, it produces halos 
and strange artifacts. Here is just one example image showing the issue:

https://xor.cryptomilk.org/darktable/dt_local_contrast_laplacian.jpg

Was perfectly fine some days ago.


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread Jan Ingwer Baer
If DT shows the aspect ratio it should try to find the nearest integral 
fraction (of course with values below 30) like 3:2, 16:9, ...



For your exampel it should show 8.2:5, or it should use one of the 
common denominators x:2, x:3, x:4, x:9 ...


It's not easy to find the best...

On 16-Nov-18 14:22, Christian wrote:

Hi,
could the aspect ratio added to the cropping display
(module: Zuschneiden und Drehen)?

So instead of (4203 x 2564) show (4203 x 2564 / 1:1.64).

Chris


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org




___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Feature request (Cropping module GUI)

2018-11-16 Thread Christian

Hi,
could the aspect ratio added to the cropping display
(module: Zuschneiden und Drehen)?

So instead of (4203 x 2564) show (4203 x 2564 / 1:1.64).

Chris


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org