Bug#1062320: libgpiod: NMU diff for 64-bit time_t transition

[Benjamin Drung]

Source: libgpiod
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru libgpiod-1.6.3/debian/changelog libgpiod-1.6.3/debian/changelog
--- libgpiod-1.6.3/debian/changelog 2021-09-05 09:07:01.0 +
+++ libgpiod-1.6.3/debian/changelog 2024-02-28 12:27:40.0 +
@@ -1,3 +1,10 @@
+libgpiod (1.6.3-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062320
+
+ -- Benjamin Drung   Wed, 28 Feb 2024 12:27:40 +
+
 libgpiod (1.6.3-1) unstable; urgency=medium
 
   * Import new upstream release
diff -Nru libgpiod-1.6.3/debian/control libgpiod-1.6.3/debian/control
--- libgpiod-1.6.3/debian/control   2020-12-14 07:33:02.0 +
+++ libgpiod-1.6.3/debian/control   2024-02-28 12:27:40.0 +
@@ -2,7 +2,7 @@
 Section: misc
 Priority: optional
 Maintainer: SZ Lin (林上智) 
-Build-Depends: debhelper-compat (= 13),
+Build-Depends: dpkg-dev (>= 1.22.5), debhelper-compat (= 13),
autoconf-archive,
automake,
dh-sequence-python3 ,
@@ -26,7 +26,7 @@
 Multi-Arch: same
 Depends: ${shlibs:Depends},
  ${misc:Depends},
- libgpiod2 (= ${binary:Version})
+ libgpiod2t64 (= ${binary:Version})
 Suggests: libgpiod-doc
 Description: C library for interacting with Linux GPIO device - static 
libraries and headers
  libgpiod encapsulates the ioctl calls and data structures
@@ -56,7 +56,10 @@
  This package contains the doxygen generated HTML documentation for the
  libraries.
 
-Package: libgpiod2
+Package: libgpiod2t64
+Provides: ${t64:Provides}
+Replaces: libgpiod2
+Breaks: libgpiod2 (<< ${source:Version})
 Section: libs
 Architecture: linux-any
 Depends: ${shlibs:Depends},
@@ -97,7 +100,7 @@
 Depends: ${shlibs:Depends},
  ${misc:Depends},
  ${python3:Depends},
- libgpiod2 (= ${binary:Version})
+ libgpiod2t64 (= ${binary:Version})
 Description: Python bindings for libgpiod (Python 3)
  libgpiod encapsulates the ioctl calls and data structures
  behind a straightforward API. This new character device
diff -Nru libgpiod-1.6.3/debian/libgpiod2.install 
libgpiod-1.6.3/debian/libgpiod2.install
--- libgpiod-1.6.3/debian/libgpiod2.install 2020-05-08 09:50:38.0 
+
+++ libgpiod-1.6.3/debian/libgpiod2.install 1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*/libgpiod*.so.*
diff -Nru libgpiod-1.6.3/debian/libgpiod2.symbols 
libgpiod-1.6.3/debian/libgpiod2.symbols
--- libgpiod-1.6.3/debian/libgpiod2.symbols 2020-08-16 07:50:34.0 
+
+++ libgpiod-1.6.3/debian/libgpiod2.symbols 1970-01-01 00:00:00.0 
+
@@ -1,242 +0,0 @@
-libgpiod.so.2 libgpiod2 #MINVER#
-* Build-Depends-Package: libgpiod-dev
- gpiod_chip_close@Base 1.1
- gpiod_chip_find_line@Base 1.1
- gpiod_chip_find_lines@Base 1.1
- gpiod_chip_get_all_lines@Base 1.1
- gpiod_chip_get_line@Base 1.1
- gpiod_chip_get_lines@Base 1.1
- gpiod_chip_iter_free@Base 1.1
- gpiod_chip_iter_free_noclose@Base 1.1
- gpiod_chip_iter_new@Base 1.1
- gpiod_chip_iter_next@Base 1.1
- gpiod_chip_iter_next_noclose@Base 1.1
- gpiod_chip_label@Base 1.1
- gpiod_chip_name@Base 1.1
- gpiod_chip_num_lines@Base 1.1
- gpiod_chip_open@Base 1.1
- gpiod_chip_open_by_label@Base 1.1
- gpiod_chip_open_by_name@Base 1.1
- gpiod_chip_open_by_number@Base 1.1
- gpiod_chip_open_lookup@Base 1.1
- gpiod_ctxless_event_loop@Base 1.1
- gpiod_ctxless_event_loop_multiple@Base 1.1
- gpiod_ctxless_event_monitor@Base 1.2
- gpiod_ctxless_event_monitor_ext@Base 1.5.1
- gpiod_ctxless_event_monitor_multiple@Base 1.2
- gpiod_ctxless_event_monitor_multiple_ext@Base 1.5.1
- gpiod_ctxless_find_line@Base 1.1
- gpiod_ctxless_get_value@Base 1.1
- gpiod_ctxless_get_value_ext@Base 1.5.1
- gpiod_ctxless_get_value_multiple@Base 1.1
- gpiod_ctxless_get_value_multiple_ext@Base 1.5.1
- gpiod_ctxless_set_value@Base 1.1
- gpiod_ctxless_set_value_ext@Base 1.5.1
- gpiod_ctxless_set_value_multiple@Base 1.1
- gpiod_ctxless_set_value_multiple_ext@Base 1.5.1
- gpiod_line_active_state@Base 1.1
- gpiod_line_bias@Base 1.5.1
- gpiod_line_close_chip@Base 1.1
- gpiod_line_consumer@Base 1.1
- gpiod_line_direction@Base 1.1
- gpiod_line_event_get_fd@Base 1.1
- gpiod_line_event_read@Base 1.1
- gpiod_line_event_read_fd@Base 1.1
- gpiod_line_event_read_fd_multiple

Bug#1062320: libgpiod: NMU diff for 64-bit time_t transition

[Steve Langasek]

On Sun, Feb 18, 2024 at 12:36:34AM +0800, 賴建宇 wrote:
> Now I understand it. Thanks for the explanation!

> Currently, I am working on upgrading libgpiod. The upstream reworks the
> whole API since v2.0 [3], so I also plan to rename the package[1].

> To avoid renaming the package two times in a short time. Is it okay that I
> upload the new version with abi=+time64 [2] to experimental? I think the
> setting can make sure the newer version covers the 64-bit time topic.

> Does this idea make sense to you? I have almost completed the work. I hope
> I can upload it to Experimental ASAP if this idea makes sense. Thank you.

That sounds fine.  Cheers!

> [1]: Add libgpiod3 symbol table (3f480bd3) · Commits · Gavin Lai / libgpiod
> · GitLab (debian.org)
> 
> 
> [2]: d/rules: Use 64-bit time_t on 32-bit arch (da487e35) · Commits · Gavin
> Lai / libgpiod · GitLab (debian.org)
> 
> 
> [3]: NEWS · debian/master · Gavin Lai / libgpiod · GitLab
> 
> 
> 
> 
> Steve Langasek  於 2024年2月15日 週四 上午2:29寫道：
> 
> > Hello,
> >
> > On Thu, Feb 08, 2024 at 11:13:51PM +0800, 賴建宇 wrote:
> > > Hi Steve,
> >
> > > I am working on upgrading the libgpiod version, so I also took time to
> > > investigate this 64-bit time_t topic.
> >
> > > I noticed that the libgpiod2.symbols and libgpiod2t64.symbols are
> > identical
> > > in the debdiff file. I am wondering if it is necessary to rename this
> > > package in this case. Please correct me if I miss anything.
> >
> > > Thanks for your great effort.
> >
> > This report explains:
> >
> >
> > https://adrien.dcln.fr/misc/armhf-time_t/2024-02-03T09%3A18%3A00/compat_reports/libgpiod-dev/lfs_to_time_t/compat_report.html
> >
> > There are ABI changes that do not show up in the type signatures of C++
> > functions and therefore do not affect C++ symbol mangling.
> >
> > --
> > Steve Langasek   Give me a lever long enough and a Free OS
> > Debian Developer   to set it on, and I can move the world.
> > Ubuntu Developer   https://www.debian.org/
> > slanga...@ubuntu.com vor...@debian.org
> >

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature

Bug#1062320: libgpiod: NMU diff for 64-bit time_t transition

[賴建宇]

Hi,


Now I understand it. Thanks for the explanation!


Currently, I am working on upgrading libgpiod. The upstream reworks the
whole API since v2.0 [3], so I also plan to rename the package[1].


To avoid renaming the package two times in a short time. Is it okay that I
upload the new version with abi=+time64 [2] to experimental? I think the
setting can make sure the newer version covers the 64-bit time topic.


Does this idea make sense to you? I have almost completed the work. I hope
I can upload it to Experimental ASAP if this idea makes sense. Thank you.


[1]: Add libgpiod3 symbol table (3f480bd3) · Commits · Gavin Lai / libgpiod
· GitLab (debian.org)


[2]: d/rules: Use 64-bit time_t on 32-bit arch (da487e35) · Commits · Gavin
Lai / libgpiod · GitLab (debian.org)


[3]: NEWS · debian/master · Gavin Lai / libgpiod · GitLab




Steve Langasek  於 2024年2月15日 週四 上午2:29寫道：

> Hello,
>
> On Thu, Feb 08, 2024 at 11:13:51PM +0800, 賴建宇 wrote:
> > Hi Steve,
>
> > I am working on upgrading the libgpiod version, so I also took time to
> > investigate this 64-bit time_t topic.
>
> > I noticed that the libgpiod2.symbols and libgpiod2t64.symbols are
> identical
> > in the debdiff file. I am wondering if it is necessary to rename this
> > package in this case. Please correct me if I miss anything.
>
> > Thanks for your great effort.
>
> This report explains:
>
>
> https://adrien.dcln.fr/misc/armhf-time_t/2024-02-03T09%3A18%3A00/compat_reports/libgpiod-dev/lfs_to_time_t/compat_report.html
>
> There are ABI changes that do not show up in the type signatures of C++
> functions and therefore do not affect C++ symbol mangling.
>
> --
> Steve Langasek   Give me a lever long enough and a Free OS
> Debian Developer   to set it on, and I can move the world.
> Ubuntu Developer   https://www.debian.org/
> slanga...@ubuntu.com vor...@debian.org
>

Bug#1062320: libgpiod: NMU diff for 64-bit time_t transition

[Steve Langasek]

Hello,

On Thu, Feb 08, 2024 at 11:13:51PM +0800, 賴建宇 wrote:
> Hi Steve,

> I am working on upgrading the libgpiod version, so I also took time to
> investigate this 64-bit time_t topic.

> I noticed that the libgpiod2.symbols and libgpiod2t64.symbols are identical
> in the debdiff file. I am wondering if it is necessary to rename this
> package in this case. Please correct me if I miss anything.

> Thanks for your great effort.

This report explains:

https://adrien.dcln.fr/misc/armhf-time_t/2024-02-03T09%3A18%3A00/compat_reports/libgpiod-dev/lfs_to_time_t/compat_report.html

There are ABI changes that do not show up in the type signatures of C++
functions and therefore do not affect C++ symbol mangling.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature

Bug#1062320: libgpiod: NMU diff for 64-bit time_t transition

[賴建宇]

Hi Steve,

I am working on upgrading the libgpiod version, so I also took time to
investigate this 64-bit time_t topic.

I noticed that the libgpiod2.symbols and libgpiod2t64.symbols are identical
in the debdiff file. I am wondering if it is necessary to rename this
package in this case. Please correct me if I miss anything.

Thanks for your great effort.

Bug#1062320: libgpiod: NMU diff for 64-bit time_t transition

[Steve Langasek]

Source: libgpiod
Version: 1.6.3-1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
libgpiod as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for libgpiod
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru libgpiod-1.6.3/debian/changelog libgpiod-1.6.3/debian/changelog
--- libgpiod-1.6.3/debian/changelog 2021-09-05 09:07:01.0 +
+++ libgpiod-1.6.3/debian/changelog 2024-02-01 02:05:58.0 +
@@ -1,3 +1,10 @@
+libgpiod (1.6.3-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Steve Langasek   Thu, 01 Feb 2024 02:05:58 +
+
 libgpiod (1.6.3-1) unstable; urgency=medium
 
   * Import new upstream release
diff -Nru libgpiod-1.6.3/debian/control libgpiod-1.6.3/debian/control
--- libgpiod-1.6.3/debian/control   2020-12-14 07:33:02.0 +
+++ libgpiod-1.6.3/debian/control   2024-02-01 02:05:58.0 +
@@ -26,7 +26,7 @@
 Multi-Arch: same
 Depends: ${shlibs:Depends},
  ${misc:Depends},
- libgpiod2 (= ${binary:Version})
+ libgpiod2t64 (= ${binary:Version})
 Suggests: libgpiod-doc
 Description: C library for interacting with Linux GPIO device - static 
libraries and headers
  libgpiod encapsulates the ioctl calls and data structures
@@ -56,7 +56,10 @@
  This package contains the doxygen generated HTML documentation for the
  libraries.
 
-Package: libgpiod2
+Package: libgpiod2t64
+Provides: ${t64:Provides}
+Replaces: libgpiod2
+Breaks: libgpiod2 (<< ${source:Version})
 Section: libs
 Architecture: linux-any
 Depends: ${shlibs:Depends},
@@ -97,7 +100,7 @@
 Depends: ${shlibs:Depends},
  ${misc:Depends},
  ${python3:Depends},
- libgpiod2 (= ${binary:Version})
+ libgpiod2t64 (= ${binary:Version})
 Description: Python bindings for libgpiod (Python 3)
  libgpiod encapsulates the ioctl calls and data structures
  behind a straightforward API. This new character device
diff -Nru libgpiod-1.6.3/debian/libgpiod2.install 
libgpiod-1.6.3/debian/libgpiod2.install
--- libgpiod-1.6.3/debian/libgpiod2.install 2020-05-08 09:50:38.0 
+
+++ libgpiod-1.6.3/debian/libgpiod2.install 1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*/libgpiod*.so.*
diff -Nru libgpiod-1.6.3/debian/libgpiod2.symbols 
libgpiod-1.6.3/debian/libgpiod2.symbols
--- libgpiod-1.6.3/debian/libgpiod2.symbols 2020-08-16 07:50:34.0 
+
+++ libgpiod-1.6.3/debian/libgpiod2.symbols 1970-01-01 00:00:00.0 
+
@@ -1,242 +0,0 @@
-libgpiod.so.2 libgpiod2 #MINVER#
-* Build-Depends-Package: libgpiod-dev
- gpiod_chip_close@Base 1.1
- gpiod_chip_find_line@Base 1.1
- gpiod_chip_find_lines@Base 1.1
- gpiod_chip_get_all_lines@Base 1.1
- gpiod_chip_get_line@Base 1.1
- gpiod_chip_get_lines@Base 1.1
- gpiod_chip_iter_free@Base 1.1
- gpiod_chip_iter_free_noclose@Base 1.1
- gpiod_chip_iter_new@Base 1.1
- gpiod_chip_iter_next@Base 1.1
- gpiod_chip_iter_next_noclose@Base 1.1
- gpiod_chip_label@Base 1.1
- gpiod_chip_name@Base 1.1
- gpiod_chip_num_lines@Base 1.1
- gpiod_chip_open@Base 1.1
- gpiod_chip_op