Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-07 Thread Jakub Wilk
Does debian/patches/compilation_fixes really fix only "compilation on 
Debian systems"?


I see several problems with the __fls function:
- You can't use "__" in your own identifiers; such names are reserved.
- The implementation uses x86 assembly.
- The unsigned long -> int typecast looks redundant to me.

Typo in src/optimize/lbfgs.f: THE THE -> THE.
Typo in src/optimize/lbfgsb.f: easible -> feasible.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130108010649.ga2...@jwilk.net



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Giulio Paci
Il 02/01/2013 23:33, Jakub Wilk ha scritto:
> * Giulio Paci , 2013-01-02, 01:40:
>>> dh_shlibdeps -plibmitlm0
>>> dpkg-shlibdeps: warning: package could avoid a useless dependency if 
>>> debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against 
>>> libquadmath.so.0 (it uses none of
>>> the library's symbols)
>>
>> This warning is still there, but I do not know how to remove it. In this 
>> case -Wl,--as-needed did not work.
>> libquadmath linking is added by the autoconf check for gfortran, used to 
>> compile part of the library. Do you have any hints?
> 
> I guess we're running into #347650 here.

I think you are right.

> If it's too burdensome to implement a work-around for it, I think we can live 
> with this useless dependency...

As the problem comes from autoconf, I disabled the check for the fortran 
libraries by explicitly setting FLIBS="-lgfortran -lm" environment variable.
The warning is gone.

Bests,
Giulio.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50e4c098.2030...@gmail.com



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Jakub Wilk

* Giulio Paci , 2013-01-02, 01:40:

dh_shlibdeps -plibmitlm0
dpkg-shlibdeps: warning: package could avoid a useless dependency if 
debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against 
libquadmath.so.0 (it uses none of the library's symbols)


This warning is still there, but I do not know how to remove it. In 
this case -Wl,--as-needed did not work.
libquadmath linking is added by the autoconf check for gfortran, used 
to compile part of the library. Do you have any hints?


I guess we're running into #347650 here.
If it's too burdensome to implement a work-around for it, I think we can 
live with this useless dependency...


--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130102223302.ga6...@jwilk.net



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Giulio Paci
Il 02/01/2013 15:00, Jakub Wilk ha scritto:
> * Giulio Paci , 2013-01-02, 01:40:
>>> README says "The vector library is partially derived from the Flexible 
>>> Library for Efficient Numerical Solutions by Michael Lehn", but this 
>>> information is not included
>>> in the copyright file.
>> I added information in copyright file, but I am not sure how to handle the 
>> situation properly: the license is the same (BSD-3-clause), but the text is 
>> different because
>> they are citing explicitly the name of their institutions in the license 
>> text.
>> Should I use a generic version of the license text? Should I change one of 
>> the license identifiers to something different than BSD-3-clause?
> 
> The latter. This was discussed on debian-policy recently:
> https://lists.debian.org/debian-policy/2013/01/msg2.html

Thank you for the pointer. I changed one of the licenses short identifier to 
BSD-3-clause-.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50e4a9a0.5040...@gmail.com



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Jakub Wilk

* Giulio Paci , 2013-01-02, 01:40:
README says "The vector library is partially derived from the Flexible 
Library for Efficient Numerical Solutions by Michael Lehn", but this 
information is not included in the copyright file.
I added information in copyright file, but I am not sure how to handle 
the situation properly: the license is the same (BSD-3-clause), but the 
text is different because they are citing explicitly the name of their 
institutions in the license text.
Should I use a generic version of the license text? Should I change one 
of the license identifiers to something different than BSD-3-clause?


The latter. This was discussed on debian-policy recently:
https://lists.debian.org/debian-policy/2013/01/msg2.html


dh_shlibdeps -plibmitlm0
dpkg-shlibdeps: warning: package could avoid a useless dependency if 
debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against 
libquadmath.so.0 (it uses none of the library's symbols)
This warning is still there, but I do not know how to remove it. In 
this case -Wl,--as-needed did not work.
libquadmath linking is added by the autoconf check for gfortran, used 
to compile part of the library. Do you have any hints?


(I'll take a look at this later.)

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130102140008.ga...@jwilk.net



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-01 Thread Giulio Paci
Il 31/12/2012 21:21, Jakub Wilk ha scritto:
> * Giulio Paci , 2012-04-07, 13:30:
>> http://mentors.debian.net/debian/pool/main/m/mitlm/mitlm_0.4-1.dsc

Moved to git://anonscm.debian.org/collab-maint/mitlm.git

> README says "The vector library is partially derived from the Flexible 
> Library for Efficient Numerical Solutions by Michael Lehn", but this 
> information is not included in
> the copyright file.

I added information in copyright file, but I am not sure how to handle the 
situation properly: the license is the same (BSD-3-clause), but the text is 
different because
they are citing explicitly the name of their institutions in the license text.
Should I use a generic version of the license text? Should I change one of the 
license identifiers to something different than BSD-3-clause?

> debian/info is empty...

Dropped.

> There are some warnings from dpkg-shlibdeps:
> 
> dh_shlibdeps -pmitlm
> dpkg-shlibdeps: warning: package could avoid a useless dependency if 
> debian/mitlm/usr/bin/evaluate-ngram debian/mitlm/usr/bin/interpolate-ngram
> debian/mitlm/usr/bin/estimate-ngram were not linked against libgfortran.so.3 
> (they use none of the library's symbols)
> dpkg-shlibdeps: warning: package could avoid a useless dependency if 
> debian/mitlm/usr/bin/evaluate-ngram debian/mitlm/usr/bin/interpolate-ngram
> debian/mitlm/usr/bin/estimate-ngram were not linked against libquadmath.so.0 
> (they use none of the library's symbols)

I added -Wl,--as-needed to LDFLAGS and these two warnings went away.

> dh_shlibdeps -plibmitlm0
> dpkg-shlibdeps: warning: package could avoid a useless dependency if 
> debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against 
> libquadmath.so.0 (it uses none of the
> library's symbols)

This warning is still there, but I do not know how to remove it. In this case 
-Wl,--as-needed did not work.
libquadmath linking is added by the autoconf check for gfortran, used to 
compile part of the library. Do you have any hints?

Bests,
Giulio.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50e3821a.3050...@gmail.com



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2012-12-31 Thread Jakub Wilk

* Giulio Paci , 2012-04-07, 13:30:

http://mentors.debian.net/debian/pool/main/m/mitlm/mitlm_0.4-1.dsc


README says "The vector library is partially derived from the Flexible 
Library for Efficient Numerical Solutions by Michael Lehn", but this 
information is not included in the copyright file.


debian/info is empty...

There are some warnings from dpkg-shlibdeps:

dh_shlibdeps -pmitlm
dpkg-shlibdeps: warning: package could avoid a useless dependency if 
debian/mitlm/usr/bin/evaluate-ngram debian/mitlm/usr/bin/interpolate-ngram 
debian/mitlm/usr/bin/estimate-ngram were not linked against libgfortran.so.3 
(they use none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if 
debian/mitlm/usr/bin/evaluate-ngram debian/mitlm/usr/bin/interpolate-ngram 
debian/mitlm/usr/bin/estimate-ngram were not linked against libquadmath.so.0 
(they use none of the library's symbols)
[…]
dh_shlibdeps -plibmitlm0
dpkg-shlibdeps: warning: package could avoid a useless dependency if 
debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against 
libquadmath.so.0 (it uses none of the library's symbols)

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121231202124.ga...@jwilk.net



Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2012-04-07 Thread Giulio Paci
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

  I am looking for a sponsor for my package "mitlm"

* Package name: mitlm
  Version : 0.4
  Upstream Author : Bo-June (Paul) Hsu 
* URL : http://code.google.com/p/mitlm/
* License : BSD
  Programming Lang: (C, C++, Fortran)
  Section : misc

It builds those binary packages:

 libmitlm0  - MIT Language Modeling toolkit library
 libmitlm0-dbg - MIT Language Modeling toolkit debug symbols
 libmitlm0-dev - MIT Language Modeling toolkit development files
 mitlm - MIT Language Modeling toolkit

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/mitlm


Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/m/mitlm/mitlm_0.4-1.dsc

Regards,
   Giulio Paci



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f80256d.2030...@gmail.com