Bug#984501: unblock: libqb/2.0.3-1
Sebastian Ramacher writes: > The changes look ok. Under the assumption that the upload happens soon, > please go ahead. Thank you, uploaded. -- Regards, Feri
Bug#984501: unblock: libqb/2.0.3-1
Control: tags -1 confirmed On 2021-03-04 11:59:35 +0100, Ferenc Wágner wrote: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > > Please unblock package libqb > > Dear Release Team, > > Upstream made a new minor release of libqb yesterday. Since a new > upload wouldn't migrate before the hard freeze with the current 10 day > delay, I'm asking for an unblock in advance. > > 2.0.3 contains a single new feature extending the API and ABI in a > backwards-compatible way with a message-id parameter, which isn't the > main reason for this request. > > Included are two doxygen2man fixes, one of them already present in the > current 2.0.2-1 package as a Debian patch, and another fixing a groff > error in libqb's own manual pages. > > The really interesting stuff is a memory safety fix in the internal > strlcpy() implementation and a more thorough cleanup procedure, which > avoids filling up /dev/shm with stale files in certain error and > recovery conditions. > > Locking errors (insufficient locking) are also fixed in the timer code, > and the unit tests are extended appropriately. > > The last fix corrects another unit test but entails no change in > behaviour. > > It would be possible to cherry pick the fix commits into Debian patches > leaving out the final one adding the new API, but I'd prefer the > cleaner solution of uploading 2.0.3 at this stage. The changes look ok. Under the assumption that the upload happens soon, please go ahead. Cheers > > debdiff against the package in testing: > > diff -Nru libqb-2.0.2/ChangeLog libqb-2.0.3/ChangeLog > --- libqb-2.0.2/ChangeLog 2020-12-03 14:07:32.0 +0100 > +++ libqb-2.0.3/ChangeLog 2021-03-03 09:34:26.0 +0100 > @@ -1,3 +1,57 @@ > +2021-03-03 Christine Caulfield > + > + release: bump library version for 2.0.3 release > + > +2021-03-01 Aleksei Burlakov > + root > + > + syslog: Add a message-id parameter for messages (#433) > + The message-id parameter will enable systemd catalogs. > + To enable message-id's the libqb should be configured with the > + --enable-systemd-journal option. > + > +2021-02-08 Chrissie Caulfield > + > + tests: Fix up resources.test (#435) > + resources.test has not checked the right filenames for a while. > + Fix this, and also make sure we don't count (but remove) the dlock > + test files. > + > + timers: Add some locking (#436) > + Fix several locking issues reported by helgrind > + > +2021-01-25 Chrissie Caulfield > + > + ipcc: Have a few goes at tidying up after a dead server (#434) > + This is an attempt to make sure that /dev/shm is cleaned up when a > + server exits unexpectedly. Normally it's the server's responsibility > + to tidy up sockets, but if it crashes or is killed with SIGKILL then > + the client (us) makes a reasonable attempt to tidy up the server sockets > + we have connected. The extra delay here just gives the server chance to > + disappear fully. As a client we can get here pretty quickly but shutting > + down a large server may take a little longer even when SIGKILLed. > + The 1/100th of a second is an arbitrary delay (of course) but seems to > + catch most servers in 2 tries or less. > + > +2021-01-13 Chrissie Caulfield > + > + strlcpy: Check for maxlen underflow (#432) > + * strlcpy: Check for maxlen underflow > + https://github.com/ClusterLabs/libqb/issues/429 > + * Always terminate the string if maxlen is > 0 > + > +2021-01-07 Chrissie Caulfield > + > + doxygen2man: fix printing of lines starting with '.' (#431) > + if a line starts with a '.' (eg the '...' in qbarray.h) then > + nroff thinks it's looking for a macro called '..'. > + The easiest solution is to add a dummy format at the start of the line > + (just adding \ seems not to work). > + > +2021-01-04 wferi > + > + doxygen2man: ignore all-whitespace brief descriptions (#430) > + > 2020-12-03 Christine Caulfield > > lib: Update library version for 2.0.2 release > diff -Nru libqb-2.0.2/configure libqb-2.0.3/configure > --- libqb-2.0.2/configure 2020-12-03 14:07:14.0 +0100 > +++ libqb-2.0.3/configure 2021-03-03 09:34:07.0 +0100 > @@ -1,6 +1,6 @@ > #! /bin/sh > # Guess values for system-dependent variables and create Makefiles. > -# Generated by GNU Autoconf 2.69 for libqb 2.0.2. > +# Generated by GNU Autoconf 2.69 for libqb 2.0.3. > # > # Report bugs to . > # > @@ -590,8 +590,8 @@ > # Identity of this package. > PACKAGE_NAME='libqb' > PACKAGE_TARNAME='libqb' > -PACKAGE_VERSION='2.0.2' > -PACKAGE_STRING='libqb 2.0.2' > +PACKAGE_VERSION='2.0.3' > +PACKAGE_STRING='libqb 2.0.3' > PACKAGE_BUGREPORT='develop...@clusterlabs.org' > PACKAGE_URL='' > > @@ -1426,7 +1426,7 @@ ># Omit some internal or obsolete options to make the list less imposing. ># This me
Processed: Re: Bug#984501: unblock: libqb/2.0.3-1
Processing control commands: > tags -1 confirmed Bug #984501 [release.debian.org] unblock: libqb/2.0.3-1 Added tag(s) confirmed. -- 984501: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984501 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#984501: unblock: libqb/2.0.3-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package libqb Dear Release Team, Upstream made a new minor release of libqb yesterday. Since a new upload wouldn't migrate before the hard freeze with the current 10 day delay, I'm asking for an unblock in advance. 2.0.3 contains a single new feature extending the API and ABI in a backwards-compatible way with a message-id parameter, which isn't the main reason for this request. Included are two doxygen2man fixes, one of them already present in the current 2.0.2-1 package as a Debian patch, and another fixing a groff error in libqb's own manual pages. The really interesting stuff is a memory safety fix in the internal strlcpy() implementation and a more thorough cleanup procedure, which avoids filling up /dev/shm with stale files in certain error and recovery conditions. Locking errors (insufficient locking) are also fixed in the timer code, and the unit tests are extended appropriately. The last fix corrects another unit test but entails no change in behaviour. It would be possible to cherry pick the fix commits into Debian patches leaving out the final one adding the new API, but I'd prefer the cleaner solution of uploading 2.0.3 at this stage. debdiff against the package in testing: diff -Nru libqb-2.0.2/ChangeLog libqb-2.0.3/ChangeLog --- libqb-2.0.2/ChangeLog 2020-12-03 14:07:32.0 +0100 +++ libqb-2.0.3/ChangeLog 2021-03-03 09:34:26.0 +0100 @@ -1,3 +1,57 @@ +2021-03-03 Christine Caulfield + + release: bump library version for 2.0.3 release + +2021-03-01 Aleksei Burlakov + root + + syslog: Add a message-id parameter for messages (#433) + The message-id parameter will enable systemd catalogs. + To enable message-id's the libqb should be configured with the +--enable-systemd-journal option. + +2021-02-08 Chrissie Caulfield + + tests: Fix up resources.test (#435) + resources.test has not checked the right filenames for a while. + Fix this, and also make sure we don't count (but remove) the dlock + test files. + + timers: Add some locking (#436) + Fix several locking issues reported by helgrind + +2021-01-25 Chrissie Caulfield + + ipcc: Have a few goes at tidying up after a dead server (#434) + This is an attempt to make sure that /dev/shm is cleaned up when a + server exits unexpectedly. Normally it's the server's responsibility + to tidy up sockets, but if it crashes or is killed with SIGKILL then + the client (us) makes a reasonable attempt to tidy up the server sockets + we have connected. The extra delay here just gives the server chance to + disappear fully. As a client we can get here pretty quickly but shutting + down a large server may take a little longer even when SIGKILLed. + The 1/100th of a second is an arbitrary delay (of course) but seems to + catch most servers in 2 tries or less. + +2021-01-13 Chrissie Caulfield + + strlcpy: Check for maxlen underflow (#432) + * strlcpy: Check for maxlen underflow + https://github.com/ClusterLabs/libqb/issues/429 + * Always terminate the string if maxlen is > 0 + +2021-01-07 Chrissie Caulfield + + doxygen2man: fix printing of lines starting with '.' (#431) + if a line starts with a '.' (eg the '...' in qbarray.h) then + nroff thinks it's looking for a macro called '..'. + The easiest solution is to add a dummy format at the start of the line + (just adding \ seems not to work). + +2021-01-04 wferi + + doxygen2man: ignore all-whitespace brief descriptions (#430) + 2020-12-03 Christine Caulfield lib: Update library version for 2.0.2 release diff -Nru libqb-2.0.2/configure libqb-2.0.3/configure --- libqb-2.0.2/configure 2020-12-03 14:07:14.0 +0100 +++ libqb-2.0.3/configure 2021-03-03 09:34:07.0 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for libqb 2.0.2. +# Generated by GNU Autoconf 2.69 for libqb 2.0.3. # # Report bugs to . # @@ -590,8 +590,8 @@ # Identity of this package. PACKAGE_NAME='libqb' PACKAGE_TARNAME='libqb' -PACKAGE_VERSION='2.0.2' -PACKAGE_STRING='libqb 2.0.2' +PACKAGE_VERSION='2.0.3' +PACKAGE_STRING='libqb 2.0.3' PACKAGE_BUGREPORT='develop...@clusterlabs.org' PACKAGE_URL='' @@ -1426,7 +1426,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures libqb 2.0.2 to adapt to many kinds of systems. +\`configure' configures libqb 2.0.3 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1496,7 +1496,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short |
