[GitHub] activemq-artemis pull request: Update vendor to ASF

[davsclaus]

GitHub user davsclaus opened a pull request:

https://github.com/apache/activemq-artemis/pull/10

Update vendor to ASF



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davsclaus/activemq-artemis irc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit fe1065ad6dfaf80832e421a453be82b0f09365ac
Author: Claus Ibsen 
Date:   2015-05-30T06:37:28Z

Update vendor to ASF




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Website & Dist for Artemis 1.0.0 is up

[Claus Ibsen]

Hi

Should Artemis not be listed as a sub-project from the main ActiveMQ web site at
http://activemq.apache.org/


On Fri, May 29, 2015 at 7:36 PM, Hiram Chirino  wrote:
> The website is up now at:
> http://activemq.apache.org/artemis/
>
> If anyone needs to tweak it, just check it out and update it via SVN from:
> https://svn.apache.org/repos/infra/websites/production/activemq/content/artemis
>
> The distro has also been deployed to:
> http://apache.org/dist/activemq/activemq-artemis/1.0.0/
>
> But I noticed that the Artemis website Download page is has wrong
> links to the distros.  It should be using the Mirror chooser.  Kinda
> like:
>
> http://www.apache.org/dyn/closer.cgi?path=activemq/activemq-artemis/1.0.0/apache-artemis-1.0.0-bin.zip
>
>
>
> --
> Hiram Chirino
> Engineering | Red Hat, Inc.
> hchir...@redhat.com | fusesource.com | redhat.com
> skype: hiramchirino | twitter: @hiramchirino



-- 
Claus Ibsen
-
Red Hat, Inc.
Email: cib...@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
hawtio: http://hawt.io/
fabric8: http://fabric8.io/

Jenkins build is unstable: ActiveMQ-SysTest-Trunk #11

[Apache Jenkins Server]

See 

Jenkins build is still unstable: ActiveMQ-SysTest-Trunk » ActiveMQ :: System Tests #11

[Apache Jenkins Server]

See 

Build failed in Jenkins: ActiveMQ Protocol Buffer #16

[Apache Jenkins Server]

See 

--
Started by an SCM change
Building remotely on ubuntu-6 (docker Ubuntu ubuntu) in workspace 

Unpacking 
http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.10-bin.zip to 
/home/jenkins/tools/maven/apache-maven-2.0.10 on ubuntu-6
Checking out a fresh workspace because 
 doesn't 
exist
Cleaning local Directory trunk
Checking out https://svn.apache.org/repos/asf/activemq/activemq-protobuf/trunk 
at revision '2015-05-30T03:00:13.286 +'
A activemq-protobuf-test
A activemq-protobuf-test/src
A activemq-protobuf-test/src/test
A activemq-protobuf-test/src/test/java
A activemq-protobuf-test/src/test/java/org
A activemq-protobuf-test/src/test/java/org/apache
A activemq-protobuf-test/src/test/java/org/apache/activemq
A activemq-protobuf-test/src/test/java/org/apache/activemq/protobuf
A 
activemq-protobuf-test/src/test/java/org/apache/activemq/protobuf/EqualsTest.java
A 
activemq-protobuf-test/src/test/java/org/apache/activemq/protobuf/DeferredUnmarshalTest.java
A activemq-protobuf-test/src/test/java/com
A activemq-protobuf-test/src/test/java/com/google
A activemq-protobuf-test/src/test/java/com/google/protobuf
A activemq-protobuf-test/src/test/java/com/google/protobuf/TestUtil.java
A 
activemq-protobuf-test/src/test/java/com/google/protobuf/multiple_files_test.proto
A 
activemq-protobuf-test/src/test/java/com/google/protobuf/WireFormatTest.java
A 
activemq-protobuf-test/src/test/java/com/google/protobuf/GeneratedMessageTest.java
A 
activemq-protobuf-test/src/test/java/com/google/protobuf/MessageTest.java
A activemq-protobuf-test/src/main
A activemq-protobuf-test/src/main/java
A activemq-protobuf-test/src/main/proto
A activemq-protobuf-test/src/main/proto/multiple_files_test.proto
A activemq-protobuf-test/src/main/proto/unittest.proto
A 
activemq-protobuf-test/src/main/proto/unittest_embed_optimize_for.proto
A activemq-protobuf-test/src/main/proto/deferred_decode.proto
A activemq-protobuf-test/src/main/proto/unittest_optimize_for.proto
A activemq-protobuf-test/src/main/proto/unittest_mset.proto
A activemq-protobuf-test/src/main/proto/unittest_import.proto
A activemq-protobuf-test/pom.xml
A activemq-protobuf
A activemq-protobuf/NOTICE
AUactivemq-protobuf/LICENSE
A activemq-protobuf/src
A activemq-protobuf/src/main
A activemq-protobuf/src/main/javacc
A activemq-protobuf/src/main/javacc/proto-parser.jj
A activemq-protobuf/src/main/resources
A activemq-protobuf/src/main/resources/META-INF
A activemq-protobuf/src/main/resources/META-INF/NOTICE
A activemq-protobuf/src/main/java
A activemq-protobuf/src/main/java/org
A activemq-protobuf/src/main/java/org/apache
A activemq-protobuf/src/main/java/org/apache/activemq
A activemq-protobuf/src/main/java/org/apache/activemq/protobuf
AU
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/BufferInputStream.java
AU
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/BufferOutputStream.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/PBMessage.java
AU
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/Buffer.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/CodedInputStream.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/CodedOutputStream.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/MessageBufferSupport.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/MessageBuffer.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/BaseMessage.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/WireFormat.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/UTF8Buffer.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/InvalidProtocolBufferException.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/AsciiBuffer.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/Message.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/DeferredDecodeMessage.java
A activemq-protobuf/src/main/java/org/apache/activemq/protobuf/compiler
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/compiler/ProtoDescriptor.java
A 
activemq-protobuf/src/main/java/org/apache/activemq/protobuf/compiler/EnumDescriptor.java
A 
ac

[GitHub] activemq pull request: AMQ-5713 - making accessors public to remov...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq pull request: AMQ-5713 - making accessors public to remov...

[mfrazier63]

GitHub user mfrazier63 opened a pull request:

https://github.com/apache/activemq/pull/106

AMQ-5713 - making accessors public to remove startup error.

Includes unit test DestinationBridgeAccessorsTest which replicated the 
problem and now passes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mfrazier63/activemq AMQ-5713

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit dcc7b11347fbaa91e6e387fdb8b0dfd67f719287
Author: mfrazier 
Date:   2015-05-29T23:13:41Z

AMQ-5713 - making accessors public to remove startup error.

Includes unit test DestinationBridgeAccessorsTest which replicated the 
problem and now passes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq pull request: AMQ-5713 - adding getDoHandlReplyTo to sati...

[mfrazier63]

Github user mfrazier63 closed the pull request at:

https://github.com/apache/activemq/pull/90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Completing the IP clearance for Artemis

[John D. Ament]

Mmmm it wasn't particularly clear that your email was the standard 72 hour
lazy consensus vote we usually do for IP Clearance.

John

On Fri, May 29, 2015 at 1:28 PM Hiram Chirino 
wrote:

> Ok I've not heard any objections from the incubator folks either.
> I'll take care of pushing the releases up.
>
> On Fri, May 29, 2015 at 7:35 AM, Gary Tully  wrote:
> > looks good to me too.
> >
> > On 27 May 2015 at 18:04, Hiram Chirino  wrote:
> >> Ok I think the IP clearance form is now complete:
> >>
> http://svn.apache.org/repos/asf/incubator/public/trunk/content/ip-clearance/hornetq.xml
> >>
> >> Could some more PMC members please review and let me know if it looks
> >> good to them?
> >>
> >> On Wed, May 27, 2015 at 12:51 PM, Hiram Chirino 
> wrote:
> >>> Now that the release looks good.  I think the ip clearance docs need
> >>> to be completed.
> >>> Current status is up at:
> >>> http://incubator.apache.org/ip-clearance/hornetq.html
> >>>
> >>> The remaining items are Copyright and 3rd party license stuff which we
> >>> have validated is correct in the this release so I'm going to fill
> >>> them out as completed today.
> >>>
> >>> --
> >>> Hiram Chirino
> >>> Engineering | Red Hat, Inc.
> >>> hchir...@redhat.com | fusesource.com | redhat.com
> >>> skype: hiramchirino | twitter: @hiramchirino
> >>
> >>
> >>
> >> --
> >> Hiram Chirino
> >> Engineering | Red Hat, Inc.
> >> hchir...@redhat.com | fusesource.com | redhat.com
> >> skype: hiramchirino | twitter: @hiramchirino
>
>
>
> --
> Hiram Chirino
> Engineering | Red Hat, Inc.
> hchir...@redhat.com | fusesource.com | redhat.com
> skype: hiramchirino | twitter: @hiramchirino
>

Website & Dist for Artemis 1.0.0 is up

[Hiram Chirino]

The website is up now at:
http://activemq.apache.org/artemis/

If anyone needs to tweak it, just check it out and update it via SVN from:
https://svn.apache.org/repos/infra/websites/production/activemq/content/artemis

The distro has also been deployed to:
http://apache.org/dist/activemq/activemq-artemis/1.0.0/

But I noticed that the Artemis website Download page is has wrong
links to the distros.  It should be using the Mirror chooser.  Kinda
like:

http://www.apache.org/dyn/closer.cgi?path=activemq/activemq-artemis/1.0.0/apache-artemis-1.0.0-bin.zip



-- 
Hiram Chirino
Engineering | Red Hat, Inc.
hchir...@redhat.com | fusesource.com | redhat.com
skype: hiramchirino | twitter: @hiramchirino

Re: Completing the IP clearance for Artemis

[Hiram Chirino]

Ok I've not heard any objections from the incubator folks either.
I'll take care of pushing the releases up.

On Fri, May 29, 2015 at 7:35 AM, Gary Tully  wrote:
> looks good to me too.
>
> On 27 May 2015 at 18:04, Hiram Chirino  wrote:
>> Ok I think the IP clearance form is now complete:
>> http://svn.apache.org/repos/asf/incubator/public/trunk/content/ip-clearance/hornetq.xml
>>
>> Could some more PMC members please review and let me know if it looks
>> good to them?
>>
>> On Wed, May 27, 2015 at 12:51 PM, Hiram Chirino  
>> wrote:
>>> Now that the release looks good.  I think the ip clearance docs need
>>> to be completed.
>>> Current status is up at:
>>> http://incubator.apache.org/ip-clearance/hornetq.html
>>>
>>> The remaining items are Copyright and 3rd party license stuff which we
>>> have validated is correct in the this release so I'm going to fill
>>> them out as completed today.
>>>
>>> --
>>> Hiram Chirino
>>> Engineering | Red Hat, Inc.
>>> hchir...@redhat.com | fusesource.com | redhat.com
>>> skype: hiramchirino | twitter: @hiramchirino
>>
>>
>>
>> --
>> Hiram Chirino
>> Engineering | Red Hat, Inc.
>> hchir...@redhat.com | fusesource.com | redhat.com
>> skype: hiramchirino | twitter: @hiramchirino



-- 
Hiram Chirino
Engineering | Red Hat, Inc.
hchir...@redhat.com | fusesource.com | redhat.com
skype: hiramchirino | twitter: @hiramchirino

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[clebertsuconic]

Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/8#issuecomment-106879458
  
Please correct those as we have error-prone on the compilation.
Look at my last commit and the post to the activemq-dev-list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[gaohoward]

Github user gaohoward commented on the pull request:

https://github.com/apache/activemq-artemis/pull/8#issuecomment-106868119
  
last time I ran the test suite I got a little over 30% pass rate. So there 
still a long way to fix it. I don't think we should enable it by default for 
now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[gaohoward]

Github user gaohoward commented on the pull request:

https://github.com/apache/activemq-artemis/pull/8#issuecomment-106867647
  
Hi Clebert,
those @deprecated tags are from activemq 5 source code, we don't need to 
correct them imo. 
This module just get them from amq repository verbatim, and are not part of 
our code.

Anyway I'm not aware we have such check, local build on my machine doesn't 
throw out those errors.
Howard


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[clebertsuconic]

Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/8#issuecomment-106826140
  
Howard, your PR doesn't build because of these issues:


/work/apache/six-merge/artemis-selector/target/generated-sources/javacc/org/apache/activemq/artemis/selector/hyphenated/SimpleCharStream.java:223:
 error: [DepAnn] Deprecated item is not annotated with @Deprecated
  public int getColumn() {
 ^
(see http://errorprone.info/bugpattern/DepAnn)
  Did you mean '@Deprecated'?

/work/apache/six-merge/artemis-selector/target/generated-sources/javacc/org/apache/activemq/artemis/selector/hyphenated/SimpleCharStream.java:232:
 error: [DepAnn] Deprecated item is not annotated with @Deprecated
  public int getLine() {
 ^
(see http://errorprone.info/bugpattern/DepAnn)
  Did you mean '@Deprecated'?

/work/apache/six-merge/artemis-selector/target/generated-sources/javacc/org/apache/activemq/artemis/selector/strict/SimpleCharStream.java:223:
 error: [DepAnn] Deprecated item is not annotated with @Deprecated
  public int getColumn() {
 ^
(see http://errorprone.info/bugpattern/DepAnn)
  Did you mean '@Deprecated'?

/work/apache/six-merge/artemis-selector/target/generated-sources/javacc/org/apache/activemq/artemis/selector/strict/SimpleCharStream.java:232:
 error: [DepAnn] Deprecated item is not annotated with @Deprecated
  public int getLine() {
 ^
(see http://errorprone.info/bugpattern/DepAnn)
  Did you mean '@Deprecated'?
Note: Some input files use unchecked or unsafe operations.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[clebertsuconic]

Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/8#issuecomment-106826266
  
Please, rebase and fix those?

http://errorprone.info/bugpattern/DepAnn


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[andytaylor]

Github user andytaylor commented on the pull request:

https://github.com/apache/activemq-artemis/pull/8#issuecomment-106816951
  
most of the tests fail clebert so we shouldn't have it enabled by default i 
dont think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Cleanup issues reported by error pr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Cleanup issues reported by error pr...

[andytaylor]

Github user andytaylor commented on the pull request:

https://github.com/apache/activemq-artemis/pull/7#issuecomment-106815858
  
i'll get this merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-128 ClassCastException in o...

[gaohoward]

Github user gaohoward commented on the pull request:

https://github.com/apache/activemq-artemis/pull/9#issuecomment-106797988
  
cherry-picked into ARTEMIS-127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-128 ClassCastException in o...

[gaohoward]

Github user gaohoward closed the pull request at:

https://github.com/apache/activemq-artemis/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-128 ClassCastException in o...

[gaohoward]

Github user gaohoward commented on the pull request:

https://github.com/apache/activemq-artemis/pull/9#issuecomment-106797031
  
ok.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-128 ClassCastException in o...

[clebertsuconic]

Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/9#issuecomment-106791273
  
This PR seems dependent on #8, why don't you cherry-pick this commit into 
that branch and have a single PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-128 ClassCastException in o...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/9

ARTEMIS-128 ClassCastException in openwire message conversion



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis Artemis128_master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit 284630fba66c2a0d7c8e78ff339e4de8eaa5963e
Author: Howard Gao 
Date:   2015-05-29T12:18:17Z

ARTEMIS-128 ClassCastException in openwire message conversion




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSSION] Error prone plugin on codebase

[Lazar Bankovic]

unsubscribe

2015-05-29 4:33 GMT+02:00 Clebert Suconic :

> Thiago Kronig has recently added error prone to the Artemis codebase,
> so any mistakes would be noticed at compilation time.
>
> I actually liked it quite a lot... Liking even more now as I realize
> what is doing :)
>
>
>
> I'm now cleaning up all the warnings we had on the codebase based on
> the plugin and I'm pushing the parameters a step further:
>
> These following mistakes will now be reported as compilation errors:
>
> -Xep:NonAtomicVolatileUpdate:ERROR
> -Xep:SynchronizeOnNonFinalField:ERROR
> -Xep:StaticAccessedFromInstance:ERROR
> -Xep:WaitNotInLoop:ERROR
>
>
> For more information on their meaning:
>
> http://errorprone.info/bugpattern/NonAtomicVolatileUpdate
> http://errorprone.info/bugpattern/SynchronizeOnNonFinalField
> http://errorprone.info/bugpattern/StaticAccessedFromInstance
> http://errorprone.info/bugpattern/WaitNotInLoop
>
>
> Any objections?
> https://github.com/apache/activemq-artemis/pull/7
>
>
> Clebert
>

Re: Completing the IP clearance for Artemis

[Gary Tully]

looks good to me too.

On 27 May 2015 at 18:04, Hiram Chirino  wrote:
> Ok I think the IP clearance form is now complete:
> http://svn.apache.org/repos/asf/incubator/public/trunk/content/ip-clearance/hornetq.xml
>
> Could some more PMC members please review and let me know if it looks
> good to them?
>
> On Wed, May 27, 2015 at 12:51 PM, Hiram Chirino  
> wrote:
>> Now that the release looks good.  I think the ip clearance docs need
>> to be completed.
>> Current status is up at:
>> http://incubator.apache.org/ip-clearance/hornetq.html
>>
>> The remaining items are Copyright and 3rd party license stuff which we
>> have validated is correct in the this release so I'm going to fill
>> them out as completed today.
>>
>> --
>> Hiram Chirino
>> Engineering | Red Hat, Inc.
>> hchir...@redhat.com | fusesource.com | redhat.com
>> skype: hiramchirino | twitter: @hiramchirino
>
>
>
> --
> Hiram Chirino
> Engineering | Red Hat, Inc.
> hchir...@redhat.com | fusesource.com | redhat.com
> skype: hiramchirino | twitter: @hiramchirino

Re: [DISCUSSION] Error prone plugin on codebase

[Christopher Shannon]

+1 for adding Error Prone and for adding those 4 mistakes. It should
probably be enabled by default since it is compile time and it will help
catch problems early.

On Fri, May 29, 2015 at 1:47 AM, Thiago Kronig 
wrote:

> It can be very helpful*
>
> On Fri, May 29, 2015, 02:46 Thiago Kronig  wrote:
>
> > Just explaining a bit: Error Prone differs on Pmd and FindBugs as it
> works
> > at compile time, leveraging the AST to do the work. Or can be very
> helpful
> > as it emits compile warnings and errors.
> >
> > We could, of course, just limit to a specific profile, as it is plugged
> as
> > a build maven plugin.
> >
> > On Thu, May 28, 2015, 23:34 Clebert Suconic 
> > wrote:
> >
> >> Thiago Kronig has recently added error prone to the Artemis codebase,
> >> so any mistakes would be noticed at compilation time.
> >>
> >> I actually liked it quite a lot... Liking even more now as I realize
> >> what is doing :)
> >>
> >>
> >>
> >> I'm now cleaning up all the warnings we had on the codebase based on
> >> the plugin and I'm pushing the parameters a step further:
> >>
> >> These following mistakes will now be reported as compilation errors:
> >>
> >> -Xep:NonAtomicVolatileUpdate:ERROR
> >> -Xep:SynchronizeOnNonFinalField:ERROR
> >> -Xep:StaticAccessedFromInstance:ERROR
> >> -Xep:WaitNotInLoop:ERROR
> >>
> >>
> >> For more information on their meaning:
> >>
> >> http://errorprone.info/bugpattern/NonAtomicVolatileUpdate
> >> http://errorprone.info/bugpattern/SynchronizeOnNonFinalField
> >> http://errorprone.info/bugpattern/StaticAccessedFromInstance
> >> http://errorprone.info/bugpattern/WaitNotInLoop
> >>
> >>
> >> Any objections?
> >> https://github.com/apache/activemq-artemis/pull/7
> >>
> >>
> >> Clebert
> >>
> >
>

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/8

ARTEMIS-127 Adding activemq unit test module to Artemis

This test module brings in activemq unit tests and run them
against Artemis broker.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis artemis127_master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 9b89104339fae58ac55ba45a2a9bfd12f0954e38
Author: Howard Gao 
Date:   2015-05-29T07:43:33Z

ARTEMIS-127 Adding activemq unit test module to Artemis

This test module brings in activemq unit tests and run them
against Artemis broker.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---