[GitHub] ant issue #57: Make junitreport with Saxon
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 @adamretter The test failure https://builds.apache.org/job/Ant%20Github-PR-Windows/37/testReport/junit/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/ looks related to this change. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/58 Overall, IMO, this can't be a general find/replace change and instead needs to be checked for individuals places where the `StringBuffer` is used and whether the change to `StringBuilder` will impact any thread safety guarantees if any. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166183671
--- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java ---
@@ -377,7 +377,7 @@ public synchronized void run() {
}
// now did any of the threads throw an exception
-exceptionMessage = new StringBuffer();
+exceptionMessage = new StringBuilder();
--- End diff --
Same comment as above.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183611 --- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java --- @@ -102,7 +102,7 @@ private static final String DEFAULT_MIME_TYPE = "text/plain"; /** Buffer in which the message is constructed prior to sending */ -private StringBuffer buffer = new StringBuffer(); +private StringBuilder buffer = new StringBuilder(); --- End diff -- I'm not too sure this change here, in this class is correct. The `StringBuffer` is a thread-safe class whereas the `StringBuilder` isn't. Having said that I haven't checked yet whether MailLogger class is expected to be thread safe nor have I checked its usage thoroughly. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant git commit: Generate manifest files and add automatic module names for JPMS
I agree. -1. On a related note, I don't think we should be doing any of these commits especially when there's a RC out which we plan to release. IMO, only blocker issues need to be addressed when the RC is out. -Jaikiran On 06/02/18 1:41 AM, Stefan Bodewig wrote: Generate manifest files and add automatic module names for JPMS -1 please remove the Automatic-Module-Name attributes as our jars are no proper JPMS modules. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant git commit: Generate manifest files and add automatic module names for JPMS
Besides, we can move classes and build an apache-bwc.jar that contains placeholders and/or deprecated classes. ScriptRunner is a good example of that. Gintas 2018-02-05 21:38 GMT+01:00 Gintautas Grigelionis : > I adjusted the proposal and I hope that I addressed your criticism. > Most of the non-JPMS stuff is deprecated anyway, we need maybe decide what > to do with BCEL support. > > Gintas > > 2018-02-05 21:11 GMT+01:00 Stefan Bodewig : > >> >> > Generate manifest files and add automatic module names for JPMS >> >> -1 >> >> please remove the Automatic-Module-Name attributes as our jars are no >> proper JPMS modules. >> >> Stefan >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org >> For additional commands, e-mail: dev-h...@ant.apache.org >> >> >
Re: ant git commit: Generate manifest files and add automatic module names for JPMS
I adjusted the proposal and I hope that I addressed your criticism. Most of the non-JPMS stuff is deprecated anyway, we need maybe decide what to do with BCEL support. Gintas 2018-02-05 21:11 GMT+01:00 Stefan Bodewig : > > > Generate manifest files and add automatic module names for JPMS > > -1 > > please remove the Automatic-Module-Name attributes as our jars are no > proper JPMS modules. > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
Re: [VOTE] Release Apache Ant 1.10.2 based on RC1
2018-02-05 21:02 GMT+01:00 Stefan Bodewig : > On 2018-02-05, Gintautas Grigelionis wrote: > > > Houston, we have a problem: JPMS explicitly forbids broken packages. > > Ant's jar can never be Java9 modules. If we wanted them to be modules, > we'd have to move classes and seriously break backwards compatibility. > > Fortunately there is no reason for the jars to become modules. > Suppose an application (say, an IDE) would like to have all components on module path rather than classpath. Well, for now I'll remove the automatic module name from jars that cannot be made into modules without breaking BWC. That way we will know better what to expect eventually. Gintas
Re: ant git commit: Generate manifest files and add automatic module names for JPMS
> Generate manifest files and add automatic module names for JPMS -1 please remove the Automatic-Module-Name attributes as our jars are no proper JPMS modules. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.2 based on RC1
On 2018-02-05, Gintautas Grigelionis wrote: > Houston, we have a problem: JPMS explicitly forbids broken packages. I was about to answer this to your Automatic-Module-Name question. Ant's jar can never be Java9 modules. If we wanted them to be modules, we'd have to move classes and seriously break backwards compatibility. Fortunately there is no reason for the jars to become modules. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.2 based on RC1
Houston, we have a problem: JPMS explicitly forbids broken packages. Currently: - apache-oro.jar and apache-regexp.jar are in the same package (org.apache.tools.ant.util.regexp) which is also present in ant.jar and ant-testutil.jar - ant-commons-logging.jar and ant-apache-log4j.jar are in the same package (org.apache.tools.ant.listener) which is also present in ant.jar - ant-antlr.jar, ant-netrexx.jar, ant-apache-xalan2.jar, ant-apache-bsf.jar are in the same package (org.apache.tools.ant.taskdefs.optional), the latter partially overlaps with ant.jar - ant-junit.jar and ant-junit4.jar are in the same package (org.apache.tools.ant.taskdefs.junit) - - ant-testutil.jar overlaps with multiple packages in ant.jar - ant-apache-bcel.jar partially overlaps with a org.apache.tools.filters.util package in ant.jar ant-apache-resolver.jar, ant-commons-net.jar, ant-jai.jar, ant-javamail.jar, ant-jdepend.jar, ant-jmf.jar, ant-jsch.jar, ant-swing.jar and ant-xz.jar are fine. There is no way Ant can play nice with JPMS without breaking backwards compatibility. Ant 2, anybody? ;-) Gintas 2018-02-05 14:00 GMT+01:00 Jaikiran Pai : > +1. > > - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new > version. > > - Ran some existing projects against this new version > > - Checked some documentation in the manual. > > Tested the projects using this version of Ant against both Java 8 and Java > 9. > > -Jaikiran > > > > > On 03/02/18 10:36 PM, Stefan Bodewig wrote: > >> Hi all >> >> I've created a release candidate for 1.10.2: >> >> git tag: ANT_1.10.2_RC1 >> on commit: 0eba7eb >> tarballs: https://dist.apache.org/repos/dist/dev/ant/ >>revision: 24668 >> Maven artifacts: >> https://repository.apache.org/content/repositories/orgapache >> ant-1021/org/apache/ant/ >> >> This Vote will be open at least for 72 hours and close no earlier than >> 2018-02-06 17:00UTC. >> >> Cheers >> >> Stefan >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org >> For additional commands, e-mail: dev-h...@ant.apache.org >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/58 Use StringBuilder instead of StringBuffer as it offers high performan⦠â¦ce in single thread places as it is generally the case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant builder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit bf3d0b448ed055eea7dcc036397e8b0f7cbc50fe Author: reudismam Date: 2018-02-05T16:18:05Z Use StringBuilder instead of StringBuffer as it offers high performance in single thread places as it is generally the case. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/58 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/58 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Ant 1.9.10 based on RC1
+1 We did test this version in our environment, no issues were found. Maarten Van: Stefan Bodewig Aan: dev@ant.apache.org Verzonden: zaterdag 3 februari 17:32 2018 Onderwerp: [VOTE] Release Ant 1.9.10 based on RC1 Hi all I've created a release candidate for 1.9.10: git tag: ANT_1_9_10_RC1 on commit: 528c94e tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 24666 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1020/org/apache/ant/ This Vote will be open at least for 72 hours and close no earlier than 2018-02-06 16:30UTC. Cheers Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #62: IVY-1572 - Check for Thread interruption while resolving ...
Github user apupier commented on the issue: https://github.com/apache/ant-ivy/pull/62 Seems that there was an issue with the Jenkins webhook. Jan Matèrne mentioned that the build was in success https://issues.apache.org/jira/browse/IVY-1572?focusedCommentId=16316345&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16316345 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.2 based on RC1
+1. - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new version. - Ran some existing projects against this new version - Checked some documentation in the manual. Tested the projects using this version of Ant against both Java 8 and Java 9. -Jaikiran On 03/02/18 10:36 PM, Stefan Bodewig wrote: Hi all I've created a release candidate for 1.10.2: git tag: ANT_1.10.2_RC1 on commit: 0eba7eb tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 24668 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1021/org/apache/ant/ This Vote will be open at least for 72 hours and close no earlier than 2018-02-06 17:00UTC. Cheers Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.2 based on RC1
1.10.2 must contain the corrected fetch.xml Now that we take Java 9 into account, should we add Automatic-Module-Name to all manifests? Gintas 2018-02-05 11:38 GMT+01:00 Jan Matèrne (jhm) : > +1 > Jan > > > -Ursprüngliche Nachricht- > > Von: Stefan Bodewig [mailto:bode...@apache.org] > > Gesendet: Samstag, 3. Februar 2018 18:07 > > An: dev@ant.apache.org > > Betreff: [VOTE] Release Apache Ant 1.10.2 based on RC1 > > > > Hi all > > > > I've created a release candidate for 1.10.2: > > > > git tag: ANT_1.10.2_RC1 > > on commit: 0eba7eb > > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > > revision: 24668 > > Maven artifacts: > > > > https://repository.apache.org/content/repositories/orgapacheant- > > 1021/org/apache/ant/ > > > > This Vote will be open at least for 72 hours and close no earlier than > > 2018-02-06 17:00UTC. > > > > Cheers > > > > Stefan > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional > > commands, e-mail: dev-h...@ant.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
Re: [VOTE] Release Ant 1.9.10 based on RC1
1.9.10 must contain the corrected fetch.xml; otherwise it works for my projects. 2018-02-05 11:18 GMT+01:00 Jan Matèrne (jhm) : > +1 > > Jan > > > > https://dist.apache.org/repos/dist/dev/ant/manual/ does not contain the > manual for 1.10.2, only 1.9.10. > > Try apache-ant-1.9.10 on Java7 > - ant -f fetch.xml all -Ddest=system > ==> works, but downloading JAI fails: > Downloading: javax/media/jai-core/1.1.3/jai-core-1.1.3.pom from > repository central at http://repo1.maven.org/maven2 > Unable to locate resource in repository > - license file present > - manual present, version correct > - "...1.9.10\...\bin\ant clean dist" on Ant's trunk (Java8) > build.xml:904: Problem: failed to create task or type setpermissions > ==> ok, is Ant 1.10+, so that buildfile requires Ant > 1.10+. > > > Try apache-ant-1.10.2 on Java8 > - ant -f fetch.xml all -Ddest=system > ==> works, but downloading JAI fails: > - license file present > - manual present, version correct > - "...1.10.2\...\bin\ant clean dist" on Ant's trunk (Java8) > ok > > > apache-ant-1.9.10-src > - try "build dist" with Java7 on Win7 > ==> ok > > > apache-ant-1.10.2-src > - try "build dist" with Java8 on Win7 > -- javadoc failes due 23 errors (missing libs) > try "build dist -Djavadoc.notrequired=true" with Java8 on Win7 > -- 4 AntUnit tests are failing > setpermissions-test_xml:testRequiresNestedResources > Expected build failure with message 'At least one > resource-collection is required' > but was 'Problem: failed to create task or type setpermissions > Cause: The name is undefined. ... > tstamp-test_xml:testMagicPropertyIso > Expected property 'DSTAMP' to have value '19720417' but was > '20180205' > tstamp-test_xml:testMagicPropertyBoth > Expected property 'DSTAMP' to have value '19720417' but was > '19700102' > ownedby-test_xml:testRequiresOwner > Expected build failure with message 'the owner attribute is > required' > but was 'isfileselected doesn't support the nested "ownedBy" > element.' > ==> ok > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
AW: [VOTE] Release Apache Ant 1.10.2 based on RC1
+1 Jan > -Ursprüngliche Nachricht- > Von: Stefan Bodewig [mailto:bode...@apache.org] > Gesendet: Samstag, 3. Februar 2018 18:07 > An: dev@ant.apache.org > Betreff: [VOTE] Release Apache Ant 1.10.2 based on RC1 > > Hi all > > I've created a release candidate for 1.10.2: > > git tag: ANT_1.10.2_RC1 > on commit: 0eba7eb > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > revision: 24668 > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant- > 1021/org/apache/ant/ > > This Vote will be open at least for 72 hours and close no earlier than > 2018-02-06 17:00UTC. > > Cheers > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional > commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
AW: [VOTE] Release Ant 1.9.10 based on RC1
+1 Jan https://dist.apache.org/repos/dist/dev/ant/manual/ does not contain the manual for 1.10.2, only 1.9.10. Try apache-ant-1.9.10 on Java7 - ant -f fetch.xml all -Ddest=system ==> works, but downloading JAI fails: Downloading: javax/media/jai-core/1.1.3/jai-core-1.1.3.pom from repository central at http://repo1.maven.org/maven2 Unable to locate resource in repository - license file present - manual present, version correct - "...1.9.10\...\bin\ant clean dist" on Ant's trunk (Java8) build.xml:904: Problem: failed to create task or type setpermissions ==> ok, is Ant 1.10+, so that buildfile requires Ant 1.10+. Try apache-ant-1.10.2 on Java8 - ant -f fetch.xml all -Ddest=system ==> works, but downloading JAI fails: - license file present - manual present, version correct - "...1.10.2\...\bin\ant clean dist" on Ant's trunk (Java8) ok apache-ant-1.9.10-src - try "build dist" with Java7 on Win7 ==> ok apache-ant-1.10.2-src - try "build dist" with Java8 on Win7 -- javadoc failes due 23 errors (missing libs) try "build dist -Djavadoc.notrequired=true" with Java8 on Win7 -- 4 AntUnit tests are failing setpermissions-test_xml:testRequiresNestedResources Expected build failure with message 'At least one resource-collection is required' but was 'Problem: failed to create task or type setpermissions Cause: The name is undefined. ... tstamp-test_xml:testMagicPropertyIso Expected property 'DSTAMP' to have value '19720417' but was '20180205' tstamp-test_xml:testMagicPropertyBoth Expected property 'DSTAMP' to have value '19720417' but was '19700102' ownedby-test_xml:testRequiresOwner Expected build failure with message 'the owner attribute is required' but was 'isfileselected doesn't support the nested "ownedBy" element.' ==> ok - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
